Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12_3_X] Add EGM HLT tags to data GTs and introduce fixed snapshot in online GTs #37883

Merged

Conversation

francescobrivio
Copy link
Contributor

PR description:

Backport of #37870
This PR is a follow-up of PR #37557. As agreed here, the EGM supercluster regression for HLT was included also in the Run3 offline GTs (auto:run3_data and auto:run3_data_relval) and to the Prompt GT.

The tags included in the GTs are:

Label: pfscecal_EBCorrection_online, Tag: pfscecal_EBCorrection_hlt_v1
Label: pfscecal_EBUncertainty_online, Tag: pfscecal_EBUncertainty_hlt_v1
Label: pfscecal_EECorrection_online, Tag: pfscecal_EECorrection_hlt_v1
Label: pfscecal_EEUncertainty_online, Tag: pfscecal_EEUncertainty_hlt_v1

We also take the chance to do a forward port of PR #37670 on what concerns the revival of an AlCaDB policy of not having any GT with an infinite snapshot in autoCond.py. The new GTs with fixed snapshot are: 123X_dataRun3_HLT_frozen_v2, 123X_dataRun3_Express_frozen_v1 and 123X_dataRun3_Prompt_frozen_v1.

The differences in GTs are shown below.

run3_hlt
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//123X_dataRun3_HLT_frozen_v1/123X_dataRun3_HLT_v7

run3_data_express
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//123X_dataRun3_Express_frozen_v1/123X_dataRun3_Express_v5

run3_data_prompt
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//123X_dataRun3_Prompt_frozen_v1/123X_dataRun3_Prompt_v7

run3_data
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//123X_dataRun3_v5/123X_dataRun3_v4

run3_data_relval
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//123X_dataRun3_relval_v4/123X_dataRun3_relval_v3

PR validation:

Validated with runTheMatrix.py -l 138.4,138.3,136.897 --ibeos -j16

Backport:

Backport of #37870
Forwardport of #37670

@cmsbuild
Copy link
Contributor

cmsbuild commented May 10, 2022

A new Pull Request was created by @francescobrivio for CMSSW_12_3_X.

It involves the following packages:

  • Configuration/AlCa (alca)

@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@francescobrivio
Copy link
Contributor Author

backport of #37870

@francescobrivio
Copy link
Contributor Author

test parameters:

  • workflows=138.3,136.897

@francescobrivio
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-99f6a3/24571/summary.html
COMMIT: 74ab983
CMSSW: CMSSW_12_3_X_2022-05-09-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37883/24571/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-99f6a3/136.897_RunCosmics2021CRUZET+RunCosmics2021CRUZET+RECOCOSDRUN3+ALCACOSDRUN3+HARVESTDCR3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-99f6a3/138.3_Splashes+RunMinimumBias2021Splash+COPYPASTER3+RECODR3Splash+HARVESTDR3

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3799361
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3799331
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 212 log files, 48 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@malbouis
Copy link
Contributor

+alca

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit d7e2888 into cms-sw:CMSSW_12_3_X May 11, 2022
@francescobrivio francescobrivio deleted the alca-add_relval_GTs_12_3_X branch May 16, 2022 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants