-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EGM HLT tags to data GTs and introduce fixed snapshot in online GTs #37870
Add EGM HLT tags to data GTs and introduce fixed snapshot in online GTs #37870
Conversation
test parameters:
|
@malbouis , thanks for this follow-up. One question: would it make sense to also update IIuc, with this PR we would have It seems like it would make things clearer (I don't think it would make much of a difference in the actual tests). |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37870/29818
|
A new Pull Request was created by @malbouis for master. It involves the following packages:
@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@missirol , good point! I have created a new GT |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37870/29836
|
test parameters:
|
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d5696d/24546/summary.html Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
+alca
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR is a follow-up of PR #37557. As agreed here, the EGM supercluster regression for HLT was included also in the Run3 offline GTs (
auto:run3_data
andauto:run3_data_relval
) and to the Prompt GT.The tags included in the GTs are:
Label:
pfscecal_EBCorrection_online
, Tag:pfscecal_EBCorrection_hlt_v1
Label:
pfscecal_EBUncertainty_online
, Tag:pfscecal_EBUncertainty_hlt_v1
Label:
pfscecal_EECorrection_online
, Tag:pfscecal_EECorrection_hlt_v1
Label:
pfscecal_EEUncertainty_online
, Tag:pfscecal_EEUncertainty_hlt_v1
We also take the chance to do a forward port of PR #37670 on what concerns the revival of an AlCaDB policy of not having any GT with an infinite snapshot in autoCond.py. The new GTs with fixed snapshot are:
123X_dataRun3_HLT_frozen_v2
,123X_dataRun3_Express_frozen_v1
and123X_dataRun3_Prompt_frozen_v1
.The difference in GTs are shown below. We expect to see as differences only the EGM tags listed above for the offline and Prompt GTs and no differences for the HLT and Express frozen GTs.
run3_hlt
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//123X_dataRun3_HLT_frozen_v2/123X_dataRun3_HLT_v7
run3_data_express
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//123X_dataRun3_Express_frozen_v1/123X_dataRun3_Express_v5
run3_data_prompt
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//123X_dataRun3_Prompt_frozen_v1/123X_dataRun3_Prompt_v7
run3_data
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//123X_dataRun3_v5/123X_dataRun3_v4
run3_data_relval
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//123X_dataRun3_relval_v4/123X_dataRun3_relval_v3
FYI @Martin-Grunewald , @missirol , @cms-sw/egamma-pog-l2
PR validation:
nohup runTheMatrix.py -l 138.4,138.3,136.897 --ibeos -j16
if this PR is a backport please specify the original PR and why you need to backport that PR:
forward port of PR #37670
there will be a backport to 123X.