Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't run HLT DQM monitoring in wf 138.4 #37812

Merged
merged 1 commit into from
May 9, 2022

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented May 5, 2022

PR description:

Title says it all, should clean a lot of warnings in the step2, visible also in IBs: log
Suggested fix at #37670 (comment)
The wf was added by @francescobrivio in PR #36133

PR validation:

Run runTheMatrix.py -l 138.4 and do not observe anymore missing products warnings.

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37812/29728

  • This PR adds an extra 48KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2022

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)

@jordan-martins, @bbilin, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen can you please review it and eventually sign? Thanks.
@makortel, @kpedro88, @fabiocos, @Martin-Grunewald, @missirol, @trtomei, @beaucero, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented May 5, 2022

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3307e6/24463/summary.html
COMMIT: 36eb90d
CMSSW: CMSSW_12_4_X_2022-05-04-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37812/24463/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 14 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3695886
  • DQMHistoTests: Total failures: 21
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3695842
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -32540.763 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 138.4 ): -12302.247 KiB HLT/Tracking
  • DQMHistoSizes: changed ( 138.4 ): -10388.740 KiB HLT/SiStrip
  • DQMHistoSizes: changed ( 138.4 ): -5333.370 KiB HLT/Pixel
  • DQMHistoSizes: changed ( 138.4 ): -1747.062 KiB HLT/EXO
  • DQMHistoSizes: changed ( 138.4 ): -1741.970 KiB HLT/EGM
  • DQMHistoSizes: changed ( 138.4 ): -823.855 KiB HLT/Vertexing
  • DQMHistoSizes: changed ( 138.4 ): -111.727 KiB DQM/TimerService
  • DQMHistoSizes: changed ( 138.4 ): -39.145 KiB HLT/LumiMonitoring
  • DQMHistoSizes: changed ( 138.4 ): -24.806 KiB HLT/HIG
  • DQMHistoSizes: changed ( 138.4 ): -10.719 KiB HLT/B2G
  • DQMHistoSizes: changed ( 138.4 ): ...
  • Checked 206 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented May 5, 2022

+1

@mmusich
Copy link
Contributor Author

mmusich commented May 9, 2022

@cms-sw/pdmv-l2 @cms-sw/upgrade-l2 any feedback on this?
Thank you.

@kskovpen
Copy link
Contributor

kskovpen commented May 9, 2022

+pdmv

@srimanob
Copy link
Contributor

srimanob commented May 9, 2022

+Upgrade

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2022

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented May 9, 2022

+1

@cmsbuild cmsbuild merged commit 962561e into cms-sw:master May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants