-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of tau embedding in relval wfs #37736
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37736/29595
|
A new Pull Request was created by @kskovpen for master. It involves the following packages:
@jordan-martins, @bbilin, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
test parameters:
|
please test |
does this replace the wf [7.3] ? |
The existing wfs are untouched. |
The question is: should this wf replace the outdated config in the 7.3 ? |
?? |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-81f2d6/24329/summary.html Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-81f2d6/24335/summary.html Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37736/29923
|
Pull request #37736 was updated. @jordan-martins, @bbilin, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen can you please check and sign again. |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-81f2d6/24616/summary.html Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-81f2d6/24628/summary.html Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
+pdmv |
+Upgrade Small change after the last sign, on definition of RUN to be used. |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
First implementation of tau embedding wfs in the relval machinery, following the discussion at the PPD meeting: https://indico.cern.ch/event/1146289/contributions/4811411/attachments/2426987/4155240/PPD-Embedding-2022-04-14.pdf. One wf (136.9) is introduced in a separate tauembed definition or relvals that will be used for tests in the production system.
PR validation:
The new wf runs fine locally.
if this PR is a backport please specify the original PR and why you need to backport that PR:
Not a backport.