HLT menu development for `12_3_X` #37152

missirol · 2022-03-06T06:35:42Z

PR description:

Development of HLT menus for CMSSW_12_3_X.

Includes the integration of the following JIRA tickets.

CMSHLT-2211: Triggers for LLP searches.
CMSHLT-2221: New DoubleTau+Jet HLT path for H→ττ and HH→bbττ.
CMSHLT-2224: New VBF+ττ HLT path for H→ττ.
CMSHLT-2240: Removal of τ+MET triggers.
CMSHLT-2241: Removal of outdated γγ HLT path.
CMSHLT-2243: Removal of obsolete Run-2 Scouting paths.

PR validation:

TSG tests.

If this PR is a backport, please specify the original PR and why you need to backport that PR:

N/A

cmsbuild · 2022-03-06T06:40:44Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37152/28701

This PR adds an extra 784KB to repository

cmsbuild · 2022-03-06T06:41:14Z

A new Pull Request was created by @missirol (Marino Missiroli) for master.

It involves the following packages:

HLTrigger/Configuration (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

missirol · 2022-03-06T06:41:32Z

please test

missirol · 2022-03-06T10:26:49Z

Looks like the tests are having trouble starting (from quick a look, it seems to be happening for other PRs as well).

Edit : they eventually started.

cmsbuild · 2022-03-06T16:25:01Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a76537/22881/summary.html
COMMIT: 6cb4ba7
CMSSW: CMSSW_12_3_X_2022-03-05-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37152/22881/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 22 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3982683
DQMHistoTests: Total failures: 1522
DQMHistoTests: Total nulls: 103
DQMHistoTests: Total successes: 3981036
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 1749.928 KiB( 48 files compared)
DQMHistoSizes: changed ( 11634.0,... ): 575.473 KiB HLT/JME
DQMHistoSizes: changed ( 11634.0,... ): -145.715 KiB HLT/TAU
DQMHistoSizes: changed ( 11634.0,... ): -54.248 KiB HLT/HIG
DQMHistoSizes: changed ( 11634.0,... ): -50.805 KiB HLT/EXO
DQMHistoSizes: changed ( 11634.0,... ): -35.098 KiB HLT/Objects
DQMHistoSizes: changed ( 11634.0,... ): 9.352 KiB HLT/HLTEgammaValidation
DQMHistoSizes: changed ( 11634.0,... ): -6.535 KiB HLT/Higgs
DQMHistoSizes: changed ( 11634.0,... ): -5.961 KiB HLT/Exotica
DQMHistoSizes: changed ( 11634.0,... ): 5.191 KiB HLT/Filters
DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
Checked 204 log files, 45 edm output root files, 49 DQM output files
TriggerResults: found differences in 6 / 48 workflows

missirol · 2022-03-06T16:48:44Z

+hlt

differences in the outputs of Run-3 wfs are consistent with the updates of the HLT GRun menu
@perrotta @qliphy , unless you have comments on this PR, it would be useful to have it already in the 23:00 IB (to spot any possible issues early, as the 12_3_0_pre6 deadline approaches)

cmsbuild · 2022-03-06T16:49:05Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2022-03-06T18:11:23Z

@missirol with this PR this additional warning message shows up in the step3 logs (see the several "workflows with reco comparison differences" in the "Comparison failed" menu, where they all differ for the additional warning message):

%MSG-w TriggerObjectStandAlone::packFilterLabels():   PATTriggerObjectStandAloneSlimmer:slimmedPatTrigger 06-Mar-2022 14:09:27 CET  Run: 1 Event: 3
Warning: can't resolve 'hltL3fDimuonL1f0ppL2NV2Chaf10L3NVf0Veto1Prompt' to a label index. idx: 3
%MSG
%MSG-w TriggerObjectStandAlone::packFilterLabels():   PATTriggerObjectStandAloneSlimmer:slimmedPatTrigger 06-Mar-2022 14:09:27 CET  Run: 1 Event: 3
Warning: can't resolve 'hltL3fDimuonL1f0ppL2NV2Chaf10L3NVf0Veto1Prompt' to a label index. idx: 1
%MSG

This is probably something you want to cure before merging this.

missirol · 2022-03-06T18:36:42Z

@perrotta , thanks for spotting this. I checked the menu, and I don't think there is anything to change on that side.

What is 'special' about that filter (hltL3fDimuonL1f0ppL2NV2Chaf10L3NVf0Veto1Prompt) is that a new Path uses it with a negation (the Path uses ~hltL3fDimuonL1f0ppL2NV2Chaf10L3NVf0Veto1Prompt, prepending with a tilde; can be seen by ctrl+find of the GRun menu in this PR). I can only guess that PATTriggerObjectStandAloneSlimmer is complaining about that (the tilde), but I don't know how to fix that (that module is not under HLT, and if a fix is needed it might take me some time).

missirol · 2022-03-06T23:35:19Z

To confirm: I tested wf 11634.0, reproduced the additional warning, then verified that modifying the GRun menu as follows

+ [..] + hltL3fDimuonL1f0ppL2NV2Chaf10L3NVf0Veto1Prompt
- [..] + ~hltL3fDimuonL1f0ppL2NV2Chaf10L3NVf0Veto1Prompt

makes the warning disappear (to be clear: this was just a test, the tilde needs to remain in place in the new GRun menu).
This is consistent with PATTriggerObjectStandAloneSlimmer somehow not being able to handle the presence of the tilde operator.

Martin-Grunewald · 2022-03-07T06:35:55Z

Hmm, we used ~ filters in HLT menus the past so that type of PAT error message was there already unless filtered out.

Martin-Grunewald · 2022-03-07T06:57:32Z

I can not see the error message in the files you are pointing to. Where are they precisely? Which log file? I looked a at log files from those links:

DefaDefault comparison: Workflows with reco comparison differences
WF #	Differences
all_OldVSNew_PyquenZEEMMppRECOin2021wf312p0	2
all_OldVSNew_RunJetHT2016EreMINIAODwf136p7611	1
all_OldVSNew_RunJetHT2018DreMINIAODULwf136p88811	1
all_OldVSNew_TTbar14TeV2021wf11634p0	3
all_OldVSNew_TTbar14TeV2021wf11634p7	3
all_OldVSNew_TTbar14TeV2021DD4wf11634p911	3
all_OldVSNew_TTbar14TeV2021DDDBwf11634p914	3
all_OldVSNew_TTbar14TeVPU2021wf11834p0	3
all_OldVSNew_TTbar14TeV2023wf12434p0	3

missirol · 2022-03-07T07:25:44Z

I could not see them there either. I found one example in "Matrix Test Outputs":
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a76537/22881/runTheMatrix-results/11634.0_TTbar_14TeV+2021+TTbar_14TeV_TuneCP5_GenSim+Digi+RecoNano+HARVESTNano+ALCA/step3_TTbar_14TeV+2021+TTbar_14TeV_TuneCP5_GenSim+Digi+RecoNano+HARVESTNano+ALCA.log

perrotta · 2022-03-07T07:39:05Z

I could not see them there either. I found one example in "Matrix Test Outputs": https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a76537/22881/runTheMatrix-results/11634.0_TTbar_14TeV+2021+TTbar_14TeV_TuneCP5_GenSim+Digi+RecoNano+HARVESTNano+ALCA/step3_TTbar_14TeV+2021+TTbar_14TeV_TuneCP5_GenSim+Digi+RecoNano+HARVESTNano+ALCA.log

Indeed: all workflows listed in https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_12_3_X_2022-03-05-1100+a76537/48748/validateJR.html for which the report says that there is one extra warning message, the extra warning message is exatly that one, and it can be found in the step3 log.

perrotta · 2022-03-07T07:41:39Z

Hmm, we used ~ filters in HLT menus the past so that type of PAT error message was there already unless filtered out.

In the current GRun menu there is another negated filter, in Status_OnCPU. However that fragment probably enter in a different way (or even not enter at all) in the PATTriggerObjectStandAloneSlimmer

Martin-Grunewald · 2022-03-07T07:48:11Z

Thanks! (I mean also in Run2 - 2018 etc.) Anyway, please consider integration despite this.

perrotta · 2022-03-07T09:21:52Z

+1

Let have this merged in order to ease the further developments of the Run3 HLT menu
The issue of the wrongly mapped HLT path in PAT must anyhow be fixed: issue HLT menu does not map correctly in PAT when negated filters are present #37157 was opened for it

missirol · 2022-03-07T09:23:08Z

Thanks @perrotta .

HLT menu development for 12_3_X

6cb4ba7

cmsbuild added this to the CMSSW_12_3_X milestone Mar 6, 2022

cmsbuild added code-checks-pending hlt-pending orp-pending pending-signatures tests-pending labels Mar 6, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 6, 2022

cmsbuild added tests-started and removed tests-pending labels Mar 6, 2022

cmsbuild added tests-approved and removed tests-started labels Mar 6, 2022

cmsbuild added fully-signed hlt-approved and removed hlt-pending pending-signatures labels Mar 6, 2022

perrotta mentioned this pull request Mar 7, 2022

HLT menu does not map correctly in PAT when negated filters are present #37157

Closed

cmsbuild added orp-approved and removed orp-pending labels Mar 7, 2022

cmsbuild merged commit f841373 into cms-sw:master Mar 7, 2022

missirol deleted the HLTdevelopment123X branch March 7, 2022 09:22

This was referenced Mar 7, 2022

[ROOT626] Updated root to tip of branch v6-26-00-patches cms-sw/cmsdist#7670

Merged

Define HOST_DEVICE_CONSTANT to implement constexpr aggregate host/device constants #37159

Merged

missirol mentioned this pull request Mar 8, 2022

handle inverted filters in TriggerObjectStandAlone #37181

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HLT menu development for `12_3_X` #37152

HLT menu development for `12_3_X` #37152

missirol commented Mar 6, 2022 •

edited

Loading

cmsbuild commented Mar 6, 2022

cmsbuild commented Mar 6, 2022

missirol commented Mar 6, 2022

missirol commented Mar 6, 2022 •

edited

Loading

cmsbuild commented Mar 6, 2022

missirol commented Mar 6, 2022

cmsbuild commented Mar 6, 2022

perrotta commented Mar 6, 2022

missirol commented Mar 6, 2022 •

edited

Loading

missirol commented Mar 6, 2022 •

edited

Loading

Martin-Grunewald commented Mar 7, 2022

Martin-Grunewald commented Mar 7, 2022 •

edited

Loading

missirol commented Mar 7, 2022 •

edited

Loading

perrotta commented Mar 7, 2022

perrotta commented Mar 7, 2022

Martin-Grunewald commented Mar 7, 2022

perrotta commented Mar 7, 2022

missirol commented Mar 7, 2022

HLT menu development for 12_3_X #37152

HLT menu development for 12_3_X #37152

Conversation

missirol commented Mar 6, 2022 • edited Loading

PR description:

PR validation:

If this PR is a backport, please specify the original PR and why you need to backport that PR:

cmsbuild commented Mar 6, 2022

cmsbuild commented Mar 6, 2022

missirol commented Mar 6, 2022

missirol commented Mar 6, 2022 • edited Loading

cmsbuild commented Mar 6, 2022

Comparison Summary

missirol commented Mar 6, 2022

cmsbuild commented Mar 6, 2022

perrotta commented Mar 6, 2022

missirol commented Mar 6, 2022 • edited Loading

missirol commented Mar 6, 2022 • edited Loading

Martin-Grunewald commented Mar 7, 2022

Martin-Grunewald commented Mar 7, 2022 • edited Loading

missirol commented Mar 7, 2022 • edited Loading

perrotta commented Mar 7, 2022

perrotta commented Mar 7, 2022

Martin-Grunewald commented Mar 7, 2022

perrotta commented Mar 7, 2022

missirol commented Mar 7, 2022

HLT menu development for `12_3_X` #37152

HLT menu development for `12_3_X` #37152

missirol commented Mar 6, 2022 •

edited

Loading

missirol commented Mar 6, 2022 •

edited

Loading

missirol commented Mar 6, 2022 •

edited

Loading

missirol commented Mar 6, 2022 •

edited

Loading

Martin-Grunewald commented Mar 7, 2022 •

edited

Loading

missirol commented Mar 7, 2022 •

edited

Loading