HLT menu does not map correctly in PAT when negated filters are present

[perrotta]

After the integration of the HLT menu development for 12_3_X (as coded in PR #37152) several warning messages from PATTriggerObjectStandAloneSlimmer suggest that the slimmer cannot handle the cases where a tilde is added in front of a filter, in order to negate its boolean outcome, in any of the HLT paths.

The message reported in the step3 logs of the workflows run by bot while testing the PR is the following:

%MSG-w TriggerObjectStandAlone::packFilterLabels():   PATTriggerObjectStandAloneSlimmer:slimmedPatTrigger 06-Mar-2022 14:09:27 CET  Run: 1 Event: 3
Warning: can't resolve 'hltL3fDimuonL1f0ppL2NV2Chaf10L3NVf0Veto1Prompt' to a label index. idx: 3
%MSG
%MSG-w TriggerObjectStandAlone::packFilterLabels():   PATTriggerObjectStandAloneSlimmer:slimmedPatTrigger 06-Mar-2022 14:09:27 CET  Run: 1 Event: 3
Warning: can't resolve 'hltL3fDimuonL1f0ppL2NV2Chaf10L3NVf0Veto1Prompt' to a label index. idx: 1
%MSG

@missirol verified that it was indeed the tilde in front of the filter that originated that warning, as reported in #37152 (comment):
"
To confirm: I tested wf 11634.0, reproduced the additional warning, then verified that modifying the GRun menu as follows

+ [..] + hltL3fDimuonL1f0ppL2NV2Chaf10L3NVf0Veto1Prompt
- [..] + ~hltL3fDimuonL1f0ppL2NV2Chaf10L3NVf0Veto1Prompt

makes the warning disappear (to be clear: this was just a test, the tilde needs to remain in place in the new GRun menu).
This is consistent with PATTriggerObjectStandAloneSlimmer somehow not being able to handle the presence of the tilde operator.
"

PR #37152 is now merged anyhow, to ease further HLT trigger developments for Run3.
But obviously having one HLT path wrongly mirrored in PAT is a bug that must be fixed before that miniAOD starts being used for the analyses.

The fix must be applied quite likely in PhysicsTools/PatAlgos/plugins/PATTriggerObjectStandAloneSlimmer.cc, but of course some expert must take care of it in order to implemen it correctly

[cmsbuild]

A new Issue was created by @perrotta Andrea Perrotta.

@Dr15Jones, @perrotta, @dpiparo, @makortel, @smuzaffar, @qliphy can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

[perrotta]

assign hlt,xpog

[cmsbuild]

New categories assigned: hlt,xpog

@mariadalfonso,@gouskos,@missirol,@fgolf,@Martin-Grunewald you have been requested to review this Pull request/Issue and eventually sign? Thanks

[Martin-Grunewald]

Who is currently maintaining the PAT trigger code? I believe the developer Volker Adler did so in the past, originated it, but it seems he has left CMS years ago, and there has not been any development since then (apart of technical changes).

[missirol]

HLT provided a fix in #37181, but I'd suggest to keep this issue open for now to clarify #37157 (comment) and #37181 (comment) .

[vlimant]

@missirol : I think it's better to close this issue and open a specific one for #37181 (comment) so that it gets assigned properly without ambiguity.

[vlimant]

please close

[missirol]

+hlt

[perrotta]

@missirol : I think it's better to close this issue and open a specific one for #37181 (comment) so that it gets assigned properly without ambiguity.

@vlimant @missirol : and was such an alternative issue actually opened while closing this one?

[missirol]

and was such an alternative issue actually opened while closing this one?

Well.. I didn't close this one, so I didn't think it was up to me to open a new one. In any case, it's done: #40007.