-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option in IgProfService to dump profiles at {pre,post}ModuleEvent #36923
Conversation
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36923/28239
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
3fd41df
to
a81bdd2
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36923/28240
|
A new Pull Request was created by @makortel (Matti Kortelainen) for master. It involves the following packages:
@cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5d3ace/22318/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR adds an option to dump IgProf profiles at {pre,post}ModuleEvent signals. The behavior can be configured with
reportModules
(vstring
for module labels) andreportModuleTypes
(vstring for module C++ types) parameters: if the current module has either the label inreportModules
or type inreportModuleTypes
, the profile is dumped. The profile file names can be set withreportToFileAt{Pre,Post}ModuleEvent (string for file name pattern) parameters. A new pattern
%M` is added for the module name.PR validation: