Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the MLPF model #3

Merged
merged 1 commit into from
Feb 11, 2022

Conversation

jpata
Copy link
Contributor

@jpata jpata commented Jan 31, 2022

Accompanying the PR cms-sw/cmssw#36841, we update the MLPF model file. No physics changes in standard workflows are expected.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @jpata (Joosep Pata) for branch master.

@smuzaffar, @iarspider, @clacaputo, @cmsbuild, @slava77, @jpata can you please review it and eventually sign? Thanks.
@mmarionncern, @lgray, @seemasharmafnal, @hatakeyamak this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

@clacaputo
Copy link

@cmsbuild please test

@perrotta
Copy link

perrotta commented Feb 10, 2022

@jpata would you mind signing this one also?
By the way, where is the old RecoParticleFlow/PFProducer/data/mlpf/mlpf_2020_11_04.pb file? I don't see it removed in this PR, but probably it should.

@jpata
Copy link
Contributor Author

jpata commented Feb 10, 2022

Correct, we should remove the old file. Is a follow-up OK?

@perrotta
Copy link

Correct, we should remove the old file. Is a follow-up OK?

This won't require other signature than your own: please do it now.
Then this and the accompanying PR can be merged together.

@cmsbuild
Copy link
Contributor

Pull request #3 was updated.

@jpata
Copy link
Contributor Author

jpata commented Feb 10, 2022

please test

@jpata jpata force-pushed the mlpf_v2_CMSSW_12_1_0_pre3_updated branch from 27c5c03 to b1b5f74 Compare February 10, 2022 18:02
@cmsbuild
Copy link
Contributor

Pull request #3 was updated.

@jpata
Copy link
Contributor Author

jpata commented Feb 10, 2022

please abort

1 similar comment
@perrotta
Copy link

please abort

@perrotta
Copy link

please test with #36841

@perrotta
Copy link

@smuzaffar I think the tests are stuck...
Is there anything to fix, or should I just try restarting them?

@smuzaffar
Copy link

please test with cms-sw/cmssw#36841

@perrotta note the correct cmssw PR name :-)

@perrotta
Copy link

Ops...
Thank you @smuzaffar !

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-630899/22346/summary.html
COMMIT: b1b5f74
CMSSW: CMSSW_12_3_X_2022-02-10-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-data/RecoParticleFlow-PFProducer/3/22346/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-630899/22346/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-630899/22346/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3764395
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3764371
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 193 log files, 42 edm output root files, 46 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link

@jpata can you sign as soon as you want to notify us that you are happy with the data PR?

@jpata
Copy link
Contributor Author

jpata commented Feb 11, 2022

+reconstruction

@smuzaffar
Copy link

+externals

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link

+1

@perrotta
Copy link

merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants