-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update the MLPF model #3
update the MLPF model #3
Conversation
A new Pull Request was created by @jpata (Joosep Pata) for branch master. @smuzaffar, @iarspider, @clacaputo, @cmsbuild, @slava77, @jpata can you please review it and eventually sign? Thanks. |
@cmsbuild please test |
@jpata would you mind signing this one also? |
Correct, we should remove the old file. Is a follow-up OK? |
This won't require other signature than your own: please do it now. |
Pull request #3 was updated. |
please test |
27c5c03
to
b1b5f74
Compare
Pull request #3 was updated. |
please abort |
1 similar comment
please abort |
please test with #36841 |
@smuzaffar I think the tests are stuck... |
please test with cms-sw/cmssw#36841 @perrotta note the correct cmssw PR name :-) |
Ops... |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-630899/22346/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison SummarySummary:
|
@jpata can you sign as soon as you want to notify us that you are happy with the data PR? |
+reconstruction
|
+externals |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
merge |
Accompanying the PR cms-sw/cmssw#36841, we update the MLPF model file. No physics changes in standard workflows are expected.