Update GEM reco geometry for Run3 MC GTs #36860

@cms-sw/geometry-l2 @cms-sw/orp-l2 @srimanob this is the PR with updated GTs.
Given the comment in #36835 (comment) do we need a fix PR from @cvuosalo before starting the tests?

srimanob · 2022-02-02T08:51:18Z

@cmsbuild please test

@francescobrivio
Thanks for the PR. I think the fix is for the payload creation. It has no effect on the simulation/reconstruction/physics result at all of the workflows. @cvuosalo may confirm.

francescobrivio · 2022-02-02T08:52:52Z

@cmsbuild please test

@francescobrivio Thanks for the PR. I think the fix is for the payload creation. It has no effect on the simulation/reconstruction/physics result at all of the workflows. @cvuosalo may confirm.

Thanks @srimanob! Do we need #36835 for the tests then?

srimanob · 2022-02-02T08:55:09Z

@cmsbuild please abort

srimanob · 2022-02-02T08:56:14Z

test parameters:

workflows = 12034.0,7.23,12834.0,11634.911,11634.914
pull_request = fix ge2/1 demonstrator in validation #36835

srimanob · 2022-02-02T08:57:48Z

@cmsbuild please test

Thanks @francescobrivio for reminding since the PR just merged 2 hour ago.

cmsbuild · 2022-02-02T12:46:32Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8a2cef/22147/summary.html
COMMIT: 9f13177
CMSSW: CMSSW_12_3_X_2022-02-01-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36860/22147/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

The workflows 1001.0, 1000.0, 136.88811, 136.874, 136.8311, 136.793, 136.7611, 136.731, 4.22 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-8a2cef/12034.0_TTbar_14TeV+2021Design+TTbar_14TeV_TuneCP5_GenSim+Digi+RecoNano+HARVESTNano
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-8a2cef/7.23_Cosmics_UP21+Cosmics_UP21+DIGICOS_UP21+RECOCOS_UP21+ALCACOS_UP21+HARVESTCOS_UP21

Summary:

No significant changes to the logs found
Reco comparison results: 37 differences found in the comparisons
DQMHistoTests: Total files compared: 43
DQMHistoTests: Total histograms compared: 3449612
DQMHistoTests: Total failures: 105
DQMHistoTests: Total nulls: 7
DQMHistoTests: Total successes: 3449478
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 223.67 KiB( 42 files compared)
DQMHistoSizes: changed ( 11634.0,... ): 33.682 KiB GEM/Efficiency
DQMHistoSizes: changed ( 11634.0,... ): 1.448 KiB GEM/Digis
DQMHistoSizes: changed ( 11634.0,... ): 0.849 KiB GEM/SimHits
DQMHistoSizes: changed ( 11634.0,... ): 0.531 KiB GEM/Pad
DQMHistoSizes: changed ( 11634.0,... ): 0.432 KiB GEM/PadCluster
DQMHistoSizes: changed ( 11634.0,... ): 0.299 KiB GEM/RecHits
DQMHistoSizes: changed ( 11634.911 ): 0.234 KiB GEM/SimHits
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
Checked 181 log files, 42 edm output root files, 43 DQM output files
TriggerResults: no differences found

tvami · 2022-02-02T14:41:28Z

+alca

differences can be seen in the GEM plots which is expected

cmsbuild · 2022-02-02T14:41:52Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2022-02-02T15:01:32Z

In the step3 of the wfs affected by this geometry update, the following warning message systematically shows up:

%MSG
%MSG-w MonitorElement:   GEMEfficiencyAnalyzer:gemEfficiencyAnalyzerSta@streamBeginRun  02-Feb-2022 10:42:50 CET Run: 1 Stream: 0
*** MonitorElement: WARNING:setBinLabel: attempting to set label of non-existent bin number for ME: GEM/Efficiency/type2/Efficiency/detector_GE21-P-L2 

%MSG
%MSG-w MonitorElement:   GEMEfficiencyAnalyzer:gemEfficiencyAnalyzerTightGlb@streamBeginRun  02-Feb-2022 10:42:50 CET Run: 1 Stream: 0
*** MonitorElement: WARNING:setBinLabel: attempting to set label of non-existent bin number for ME: GEM/Efficiency/type1/Efficiency/detector_GE21-P-L2 

%MSG

This is probably something @cms-sw/dqm-l2 should be also made aware of, in ordeer to setup a possible fix

jfernan2 · 2022-02-02T17:16:19Z

@hyunyong @sgrzegorz @quark2 @seungjin-yang
as GEM DQM developers, please provide a fix for the issue above
Thanks

seungjin-yang · 2022-02-03T05:41:18Z

@hyunyong @sgrzegorz @quark2 @seungjin-yang as GEM DQM developers, please provide a fix for the issue above Thanks

Hi @jfernan2, the above warning is due to offline DQM not handling the new GEM geometry properly. We're aware of the issue and I will fix it. Thank you for reminding me about this issue.

perrotta · 2022-02-03T10:03:36Z

@hyunyong @sgrzegorz @quark2 @seungjin-yang as GEM DQM developers, please provide a fix for the issue above Thanks

Hi @jfernan2, the above warning is due to offline DQM not handling the new GEM geometry properly. We're aware of the issue and I will fix it. Thank you for reminding me about this issue.

Thank you @seungjin-yang
Please notice that this is quite urgent: do you have an idea about the time you need for it?

@francescobrivio I understand that the fix above will go in a different PR: I would wait for that PR being (at least) ready before merging this PR, unless the time needed for it would unacceptably delay this (and in particular the backport) PR. Please advise if you have a different opinion about it.

francescobrivio · 2022-02-03T10:09:53Z

@francescobrivio I understand that the fix above will go in a different PR: I would wait for that PR being (at least) ready before merging this PR, unless the time needed for it would unacceptably delay this (and in particular the backport) PR. Please advise if you have a different opinion about it.

@perrotta For me it's fine if it's a matter of waiting 1 or 2 days: I'm thinking especially at the backport and the need to cut (and properly test) a new 12_2 release in time for the Feb MWGR (in ~2 weeks).

perrotta · 2022-02-03T10:19:05Z

@francescobrivio for the MWGR CMSSW_12_2_0_patch1 could also be used (it only misses #36866, but as far as I understand we could temporarily survive even without it, at worst).
By the way, was CMSSW_12_2_0_patch1 already deployed at T0? We were hurried up to produce that patch release for it, but until recently it was not yet deployed there...

francescobrivio · 2022-02-03T10:25:04Z

@francescobrivio for the MWGR CMSSW_12_2_0_patch1 could also be used (it only misses #36866, but as far as I understand we could temporarily survive even without it, at worst).

True for MWGR we can probably survive with CMSSW_12_2_0_patch1.

By the way, was CMSSW_12_2_0_patch1 already deployed at T0? We were hurried up to produce that patch release for it, but until recently it was not yet deployed there...

It was not deployed for production but used in two replays (both successful btw):

2018 replay for Pixel LA PCL test dmwm/T0#4635 --> prompted further development of the new SiPixel LA PCL wf
2018 replay for PPS PCL test dmwm/T0#4640) --> proved newly introduced PPS alcarecos and wfs run in Tier0 withut issues

…related to cms-sw#36860

tvami · 2022-02-03T19:57:00Z

@perrotta since the DQM PR is somewhat independent of this one, can we just merge this PR? We have another update coming in here https://cms-talk.web.cern.ch/t/gt-mc-update-to-csc-bad-chambers-for-run-3-simulation/5617/2 (that is independent of the geometry changes)

tvami · 2022-02-04T00:28:49Z

@perrotta since the DQM PR is somewhat independent of this one, can we just merge this PR? We have another update coming in here https://cms-talk.web.cern.ch/t/gt-mc-update-to-csc-bad-chambers-for-run-3-simulation/5617/2 (that is independent of the geometry changes)

Or @qliphy

qliphy · 2022-02-04T02:28:12Z

@perrotta since the DQM PR is somewhat independent of this one, can we just merge this PR? We have another update coming in here https://cms-talk.web.cern.ch/t/gt-mc-update-to-csc-bad-chambers-for-run-3-simulation/5617/2 (that is independent of the geometry changes)

Or @qliphy

@tvami Unfortunately I am on vacation for the lunar new year until the weekend. I think probably GEM developers should address (@hyunyong @sgrzegorz @quark2 @seungjin-yang) or at least reply to the above comments:
#36860 (comment)

seungjin-yang · 2022-02-04T05:29:53Z

@perrotta @tvami @qliphy I can create a PR to fix this issue in a few hours. As @tvami mentioned, my PR should be independent of this PR.

perrotta · 2022-02-04T07:45:18Z

+1

Let have this GT change merged
@seungjin-yang please notice that the DQM fix is needed quite urgently, and a backport will be also needed for 12_2_X

seungjin-yang · 2022-02-04T08:51:18Z

@perrotta I created a PR #36883 to fix MonitorElement: WARNING:setBinLabel.

perrotta · 2022-02-04T09:00:11Z

@perrotta I created a PR #36883 to fix MonitorElement: WARNING:setBinLabel.

Thank you @seungjin-yang !

update GEM reco geometry for Run3 MC GTs

9f13177

cmsbuild added this to the CMSSW_12_3_X milestone Feb 2, 2022

cmsbuild added alca-pending code-checks-pending orp-pending pending-signatures tests-pending labels Feb 2, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 2, 2022

cmsbuild added tests-started and removed tests-pending labels Feb 2, 2022

cmsbuild added tests-pending and removed tests-started labels Feb 2, 2022

cmsbuild added the requires-external label Feb 2, 2022

cmsbuild added tests-started and removed tests-pending labels Feb 2, 2022

francescobrivio mentioned this pull request Feb 2, 2022

Update final Run3 MC geometry [12_2_X] #36785

Merged

cmsbuild added tests-approved and removed tests-started labels Feb 2, 2022

cmsbuild added alca-approved fully-signed and removed alca-pending pending-signatures labels Feb 2, 2022

seungjin-yang added a commit to slowmoyang/cmssw that referenced this pull request Feb 3, 2022

Add flags to enable/disable monitoring for GEM stations. This fix is …

ff05356

…related to cms-sw#36860

cmsbuild added orp-approved and removed orp-pending labels Feb 4, 2022

cmsbuild merged commit 93dd1eb into cms-sw:master Feb 4, 2022

seungjin-yang mentioned this pull request Feb 4, 2022

Fix GEM Offline DQM for GE2/1 Demonstrator #36883

Merged

cmsbuild mentioned this pull request Feb 4, 2022

Updated boost to 1.78 cms-sw/cmsdist#7529

Merged

seungjin-yang mentioned this pull request Feb 8, 2022

Fix GEM Offline DQM for GE2/1 Demonstrator (backport of #36883, 12_2_X) #36906

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update GEM reco geometry for Run3 MC GTs #36860

Update GEM reco geometry for Run3 MC GTs #36860

francescobrivio commented Feb 2, 2022 •

edited

Loading

francescobrivio commented Feb 2, 2022

cmsbuild commented Feb 2, 2022

cmsbuild commented Feb 2, 2022

francescobrivio commented Feb 2, 2022

srimanob commented Feb 2, 2022 •

edited

Loading

francescobrivio commented Feb 2, 2022

srimanob commented Feb 2, 2022

srimanob commented Feb 2, 2022

srimanob commented Feb 2, 2022

cmsbuild commented Feb 2, 2022

tvami commented Feb 2, 2022

cmsbuild commented Feb 2, 2022

perrotta commented Feb 2, 2022

jfernan2 commented Feb 2, 2022

seungjin-yang commented Feb 3, 2022

perrotta commented Feb 3, 2022

francescobrivio commented Feb 3, 2022

perrotta commented Feb 3, 2022

francescobrivio commented Feb 3, 2022 •

edited

Loading

tvami commented Feb 3, 2022 •

edited

Loading

tvami commented Feb 4, 2022

qliphy commented Feb 4, 2022 •

edited

Loading

seungjin-yang commented Feb 4, 2022

perrotta commented Feb 4, 2022

seungjin-yang commented Feb 4, 2022

perrotta commented Feb 4, 2022

Update GEM reco geometry for Run3 MC GTs #36860

Update GEM reco geometry for Run3 MC GTs #36860

Conversation

francescobrivio commented Feb 2, 2022 • edited Loading

PR description:

PR validation:

Backport:

francescobrivio commented Feb 2, 2022

cmsbuild commented Feb 2, 2022

cmsbuild commented Feb 2, 2022

francescobrivio commented Feb 2, 2022

srimanob commented Feb 2, 2022 • edited Loading

francescobrivio commented Feb 2, 2022

srimanob commented Feb 2, 2022

srimanob commented Feb 2, 2022

srimanob commented Feb 2, 2022

cmsbuild commented Feb 2, 2022

Comparison Summary

tvami commented Feb 2, 2022

cmsbuild commented Feb 2, 2022

perrotta commented Feb 2, 2022

jfernan2 commented Feb 2, 2022

seungjin-yang commented Feb 3, 2022

perrotta commented Feb 3, 2022

francescobrivio commented Feb 3, 2022

perrotta commented Feb 3, 2022

francescobrivio commented Feb 3, 2022 • edited Loading

tvami commented Feb 3, 2022 • edited Loading

tvami commented Feb 4, 2022

qliphy commented Feb 4, 2022 • edited Loading

seungjin-yang commented Feb 4, 2022

perrotta commented Feb 4, 2022

seungjin-yang commented Feb 4, 2022

perrotta commented Feb 4, 2022

francescobrivio commented Feb 2, 2022 •

edited

Loading

srimanob commented Feb 2, 2022 •

edited

Loading

francescobrivio commented Feb 3, 2022 •

edited

Loading

tvami commented Feb 3, 2022 •

edited

Loading

qliphy commented Feb 4, 2022 •

edited

Loading