Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated boost to 1.78 #7529

Merged
merged 4 commits into from
Feb 7, 2022
Merged

Updated boost to 1.78 #7529

merged 4 commits into from
Feb 7, 2022

Conversation

davidlange6
Copy link
Contributor

(at least to see what unit tests fail)

(at least to see what unit tests fail)
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @davidlange6 (David Lange) for branch IB/CMSSW_12_3_X/master.

@cmsbuild, @smuzaffar, @iarspider, @ddaina can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

@davidlange6
Copy link
Contributor Author

davidlange6 commented Dec 28, 2021

test parameters:

@davidlange6
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-662d04/21483/summary.html
COMMIT: d11b941
CMSSW: CMSSW_12_3_X_2021-12-28-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7529/21483/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

Patch #0 (boost-1.75.0-disable-statx):
+ patch --no-backup-if-mismatch -p1 --fuzz=0
patching file libs/filesystem/build/Jamfile.v2
Hunk #1 FAILED at 53.
1 out of 1 hunk FAILED -- saving rejects to file libs/filesystem/build/Jamfile.v2.rej
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.8cAFoj (%prep)


RPM build errors:
Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.8cAFoj (%prep)



@davidlange6
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

Pull request #7529 was updated.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-662d04/21496/summary.html
COMMIT: adeedf7
CMSSW: CMSSW_12_3_X_2021-12-28-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7529/21496/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 43
  • DQMHistoTests: Total histograms compared: 3461692
  • DQMHistoTests: Total failures: 5
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3461665
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 42 files compared)
  • Checked 181 log files, 42 edm output root files, 43 DQM output files
  • TriggerResults: no differences found

@davidlange6
Copy link
Contributor Author

please test

@smuzaffar
Copy link
Contributor

please test

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2022

Pull request #7529 was updated.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2022

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-662d04/22216/summary.html
COMMIT: 6f5cf42
CMSSW: CMSSW_12_3_X_2022-02-03-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7529/22216/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-662d04/22216/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-662d04/22216/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test DRNTest had ERRORS

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 36 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3765022
  • DQMHistoTests: Total failures: 109
  • DQMHistoTests: Total nulls: 7
  • DQMHistoTests: Total successes: 3764884
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 223.444 KiB( 45 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 33.682 KiB GEM/Efficiency
  • DQMHistoSizes: changed ( 11634.0,... ): 1.448 KiB GEM/Digis
  • DQMHistoSizes: changed ( 11634.0,... ): 0.849 KiB GEM/SimHits
  • DQMHistoSizes: changed ( 11634.0,... ): 0.531 KiB GEM/Pad
  • DQMHistoSizes: changed ( 11634.0,... ): 0.432 KiB GEM/PadCluster
  • DQMHistoSizes: changed ( 11634.0,... ): 0.299 KiB GEM/RecHits
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 193 log files, 42 edm output root files, 46 DQM output files
  • TriggerResults: no differences found

@francescobrivio
Copy link

Hi @davidlange6 and @smuzaffar!
Just out of curiosity (and to better organize things in AlCa), is there already a timeline / planned release to make this updated boost version the default in CMSSW?

@smuzaffar
Copy link
Contributor

@davidlange6 , was there any thing in boost 1.78 which you think is needed for cxxmodules IBs?
@francescobrivio , no there is no timeline or planned release for this to go in. Basic PR tests are passed. If you need an env to test it then we can include this in DEVEL IBs to have full scale Ib tests.

@davidlange6
Copy link
Contributor Author

davidlange6 commented Feb 7, 2022 via email

@smuzaffar
Copy link
Contributor

OK, lets get this it DEVEL IB so that db/alca can run tests if needed

@smuzaffar smuzaffar changed the base branch from IB/CMSSW_12_3_X/master to IB/CMSSW_12_3_X/devel February 7, 2022 14:10
@smuzaffar
Copy link
Contributor

+externals
unit tests failure is due to data package update which was not included in this test
merging this for 12.3.DEVEL.X IBs to run full scale tests

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2022

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_3_X/devel IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@francescobrivio
Copy link

@smuzaffar we don't have specific tests, just a couple of scripts (outside CMSSW, such as the condition uploader) that just need to be made aware of this change.

@smuzaffar smuzaffar deleted the davidlange6-patch-1 branch February 8, 2022 13:22
@smuzaffar
Copy link
Contributor

@cms-sw/alca-l2 @cms-sw/db-l2 this has been integrated in DEVEL IBs now. All tests look good. The serialization part of boost contains only build system releated changed e.g. boostorg/serialization@boost-1.75.0...boost-1.78.0 .

@tvami
Copy link

tvami commented Feb 9, 2022

We finished with our tests, AlCaDB is OK with integrating this in the main CMSSW release too, @cms-sw/orp-l2 @smuzaffar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants