-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated boost to 1.78 #7529
Updated boost to 1.78 #7529
Conversation
(at least to see what unit tests fail)
A new Pull Request was created by @davidlange6 (David Lange) for branch IB/CMSSW_12_3_X/master. @cmsbuild, @smuzaffar, @iarspider, @ddaina can you please review it and eventually sign? Thanks. |
test parameters:
|
please test |
-1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-662d04/21483/summary.html External BuildI found compilation error when building: Patch #0 (boost-1.75.0-disable-statx): + patch --no-backup-if-mismatch -p1 --fuzz=0 patching file libs/filesystem/build/Jamfile.v2 Hunk #1 FAILED at 53. 1 out of 1 hunk FAILED -- saving rejects to file libs/filesystem/build/Jamfile.v2.rej error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.8cAFoj (%prep) RPM build errors: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.8cAFoj (%prep) |
please test |
Pull request #7529 was updated. |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-662d04/21496/summary.html Comparison SummarySummary:
|
please test |
please test |
please test |
Pull request #7529 was updated. |
-1 Failed Tests: UnitTests The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Unit TestsI found errors in the following unit tests: ---> test DRNTest had ERRORS Comparison SummarySummary:
|
Hi @davidlange6 and @smuzaffar! |
@davidlange6 , was there any thing in boost 1.78 which you think is needed for cxxmodules IBs? |
Not needed no, useful, yes - I'd rather not wait another year to update boost. Being not yet in data taking, it seemed the right time.
… On Feb 7, 2022, at 2:44 PM, Malik Shahzad Muzaffar ***@***.***> wrote:
@davidlange6 , was there any thing in boost 1.78 which you think is needed for cxxmodules IBs?
@francescobrivio , no there is no timeline or planned release for this to go in. Basic PR tests are passed. If you need an env to test it then we can include this in DEVEL IBs to have full scale Ib tests.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you were mentioned.
|
OK, lets get this it DEVEL IB so that db/alca can run tests if needed |
+externals |
This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_3_X/devel IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
@smuzaffar we don't have specific tests, just a couple of scripts (outside CMSSW, such as the condition uploader) that just need to be made aware of this change. |
@cms-sw/alca-l2 @cms-sw/db-l2 this has been integrated in DEVEL IBs now. All tests look good. The serialization part of boost contains only build system releated changed e.g. boostorg/serialization@boost-1.75.0...boost-1.78.0 . |
We finished with our tests, AlCaDB is OK with integrating this in the main CMSSW release too, @cms-sw/orp-l2 @smuzaffar |
(at least to see what unit tests fail)