Improvements on SiPixelLorentzAngle PCL workflow: layer-dependent cluster size cut and output maps

[mmusich]

PR description:

This PR collects a series of improvements coming from the commissioning of the SiPixelLorentzAngle PCL workflow being commissioned at dmwm/T0#4635 and builds on top of PRs #36565 and #36538:

• adds output LorentzAngle maps to SiPixelLorentzAnglePCLHarvester (6f7e47f and ea87669)
• layer-dependent cluster y-size cut in SiPixelLorentzAnglePCLWorker (e0df5ae)
• add SiPixelLorentzAngleFullMapCompare to Pixel Payload Inspector (6dcc84e), triggers also DQM signature

PR validation:

Privately run

 cmsDriver.py testReAlCa -s ALCA:PromptCalibProdSiPixelLorentzAngle --conditions 121X_dataRun3_Express_TIER0_REPLAY_Run2_v1 --scenario pp --data --era Run2_2018 --datatier ALCARECO --eventcontent ALCARECO --processName=ReAlCa -n 100000 --dasquery='file dataset=/StreamExpress/Tier0_REPLAY_2021-SiPixelCalSingleMuon-Express-v1/ALCARECO' --customise_commands='process.ALCARECOCalSignleMuonFilterForSiPixelLorentzAngle.TriggerResultsTag = cms.InputTag ( "TriggerResults","","HLT" ) ; process.ALCARECOCalSignleMuonFilterForSiPixelLorentzAngle.HLTPaths = ["*"]' --nThreads=4 

followed by:

 cmsDriver.py stepHarvest -s ALCAHARVEST:SiPixelLA --conditions 121X_dataRun3_Express_TIER0_REPLAY_Run2_v1 --scenario pp --data --era Run2_2018 --filein file:PromptCalibProdSiPixelLorentzAngle.root -n -1

For what concerns the PI update (6dcc84e), here's an example of plot obtainable (using the results of the Tier-0 replay):

if this PR is a backport please specify the original PR and why you need to backport that PR:

WIll be backported to CMSSW_12_2_X

[tvami]

urgent

• @cms-sw/orp-l2 this is the PR I just mentioned

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36853/28082

• This PR adds an extra 52KB to repository

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

• CalibTracker/SiPixelLorentzAngle (alca)
• CondCore/SiPixelPlugins (db)
• DQM/TrackerRemapper (dqm)

@malbouis, @yuanchao, @pmandrik, @emanueleusai, @ahmad3213, @tvami, @cmsbuild, @jfernan2, @ggovi, @francescobrivio, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@hdelanno, @tocheng, @VinInn, @OzAmram, @dkotlins, @fioriNTU, @jandrea, @ferencek, @idebruyn, @mmusich, @threus, @tvami this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[tvami]

@cmsbuild , please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-401fce/22129/summary.html
COMMIT: ea87669
CMSSW: CMSSW_12_3_X_2022-02-01-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36853/22129/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 43
• DQMHistoTests: Total histograms compared: 3449612
• DQMHistoTests: Total failures: 50
• DQMHistoTests: Total nulls: 2
• DQMHistoTests: Total successes: 3449538
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 8.389 KiB( 42 files compared)
• DQMHistoSizes: changed ( 1001.0 ): 8.385 KiB AlCaReco/SiPixelLorentzAngleHarvesting
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 181 log files, 42 edm output root files, 43 DQM output files
• TriggerResults: no differences found

[tvami]

+1

• changes as expected: https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_12_3_X_2022-02-01-1100+401fce/48158/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVDSIPIXELCALRUN1+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5+ALCAHARVD7/AlCaReco_SiPixelLorentzAngle_SectorMonitoring.html
• every other diff is in MsgLogger only

[emanueleusai]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1