-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix of a check on the geometry in the RPCConeBuilder #36803
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36803/27953
|
A new Pull Request was created by @elfontan (Elisa Fontanesi) for master. It involves the following packages:
@epalencia, @cmsbuild, @cecilecaillol, @rekovic can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b07e54/22003/summary.html Comparison SummarySummary:
|
+l1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36803/27971
|
Pull request #36803 was updated. @epalencia, @cmsbuild, @cecilecaillol, @rekovic can you please check and sign again. |
@cmsbuild Please test |
urgent |
+l1 |
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b07e54/22036/summary.html Comparison SummarySummary:
|
+1 |
ED_RPConeBuilderFix222 Backport the fix of a check on the geometry in RPCConeBuilder due to elfontan in #36803
PR description:
Temporary fix of an issue encountered while testing the new CMSSW_12_3_0_pre4 release to run the L1 emulation.
All details about the issue can be found in this GitHub issue.
Some follow-up is needed with L1 RPC people who agreed for now with the proposed solution of removing the problematic check on the geometry. It is supposed to check if the geometry has a complete ring, however in the case of demo chambers only two sectors are added and the ring is not filled, so that the check fails.
PR validation:
Basic tests performed successfully starting from CMSSW_12_3_0_pre4.
From CMSSW_12_3_0_pre4/src: