Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix of a check on the geometry in the RPCConeBuilder #36803

Merged
merged 3 commits into from
Jan 27, 2022

Conversation

elfontan
Copy link
Contributor

PR description:

Temporary fix of an issue encountered while testing the new CMSSW_12_3_0_pre4 release to run the L1 emulation.
All details about the issue can be found in this GitHub issue.
Some follow-up is needed with L1 RPC people who agreed for now with the proposed solution of removing the problematic check on the geometry. It is supposed to check if the geometry has a complete ring, however in the case of demo chambers only two sectors are added and the ring is not filled, so that the check fails.

PR validation:

Basic tests performed successfully starting from CMSSW_12_3_0_pre4.
From CMSSW_12_3_0_pre4/src:

scram b distclean
git cms-checkdeps -a -A
scram b -j 8
scram b runtests
scram build code-checks
scram build code-format
runTheMatrix.py -l limited -i all --ibeos

@cmsbuild cmsbuild added this to the CMSSW_12_3_X milestone Jan 25, 2022
@elfontan elfontan changed the title Commented a check on the geometry as a temporary fix Temporary fix of the RPCConeBuilder Jan 25, 2022
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36803/27953

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @elfontan (Elisa Fontanesi) for master.

It involves the following packages:

  • L1Trigger/RPCTrigger (l1)

@epalencia, @cmsbuild, @cecilecaillol, @rekovic can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b07e54/22003/summary.html
COMMIT: af3cc8a
CMSSW: CMSSW_12_3_X_2022-01-25-1700/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36803/22003/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 7 differences found in the comparisons
  • DQMHistoTests: Total files compared: 43
  • DQMHistoTests: Total histograms compared: 3449324
  • DQMHistoTests: Total failures: 11
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3449290
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 42 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 181 log files, 42 edm output root files, 43 DQM output files
  • TriggerResults: no differences found

@cecilecaillol
Copy link
Contributor

+l1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36803/27971

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

Pull request #36803 was updated. @epalencia, @cmsbuild, @cecilecaillol, @rekovic can you please check and sign again.

@bsunanda
Copy link
Contributor

@cmsbuild Please test

@civanch
Copy link
Contributor

civanch commented Jan 27, 2022

urgent

@cecilecaillol
Copy link
Contributor

+l1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b07e54/22036/summary.html
COMMIT: 5692778
CMSSW: CMSSW_12_3_X_2022-01-26-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36803/22036/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 43
  • DQMHistoTests: Total histograms compared: 3449324
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3449296
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 42 files compared)
  • Checked 181 log files, 42 edm output root files, 43 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit bd7c302 into cms-sw:master Jan 27, 2022
cmsbuild added a commit that referenced this pull request Jan 28, 2022
ED_RPConeBuilderFix222 Backport the fix of a check on the geometry in RPCConeBuilder due to elfontan in #36803
@elfontan elfontan deleted the EF_RPCConeBuilderFix branch March 2, 2022 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants