Skip to content

Commit

Permalink
Backport the fix of a check on the geometry in RPCConeBuilder due to …
Browse files Browse the repository at this point in the history
…elfontan in cms-sw#36803
  • Loading branch information
Sunanda committed Jan 27, 2022
1 parent f7e638b commit 995d285
Showing 1 changed file with 8 additions and 3 deletions.
11 changes: 8 additions & 3 deletions L1Trigger/RPCTrigger/plugins/RPCConeBuilder.cc
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@
//
/**\class RPCConeBuilder RPCConeBuilder.h L1Trigger/RPCTriggerConfig/src/RPCConeBuilder.cc
Description: <one line class summary>
Description: The RPCConeBuilder class is the emulator of the Run 1 RPC PAC Trigger.
It is not used in the L1 Trigger decision since 2016.
It might be needed just for the re-emulation of the Run 1 data.
Implementation:
<Notes on implementation>
Expand Down Expand Up @@ -121,7 +123,7 @@ void RPCConeBuilder::buildCones(RPCGeometry const* rpcGeom,
it.second.fillWithVirtualStrips();
}

// Xcheck, if rings are symettrical
// Xcheck, if rings are symmetrical
for (auto& it : ringsMap) {
int key = it.first;
int sign = key / 100 - (key / 1000) * 10;
Expand All @@ -132,7 +134,10 @@ void RPCConeBuilder::buildCones(RPCGeometry const* rpcGeom,
key -= 100;
}

if (key != 2000) { // Hey 2100 has no counterring
// Check if the geometry has a complete ring:
// note that in the case of demo chambers, the ring is not filled because only 2 sectors are added.
// (3014 and 4014 lack counter-rings)
if (key != 2000 && key != 3014 && key != 4014) { // Key 2100 has no counter-ring
if (it.second.size() != ringsMap[key].size()) {
throw cms::Exception("RPCInternal") << " Size differs for ring " << key << " +- 100 \n";
}
Expand Down

0 comments on commit 995d285

Please sign in to comment.