-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run3-gex108XD Modify muon numbering, adding scenarios for the corretced Run3 geometry in CMSSW version 12_2_X #36782
Conversation
A new Pull Request was created by @bsunanda (Sunanda Banerjee) for CMSSW_12_2_X. It involves the following packages:
@malbouis, @civanch, @yuanchao, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob, @Dr15Jones, @tvami, @francescobrivio can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
-1 @bsunanda I don't think copy-pasting 12_3_X GTs in 12_2_X is the correct way to go. |
Pull request #36782 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please check and sign again. |
Hi @bsunanda please include [12_2_X] in the PR title, thanks! |
backport of #36654 |
backport of #36679 |
@tvami I have made the changes as suggested by you |
Pull request #36782 was updated. @perrotta, @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob, @qliphy, @fabiocos, @davidlange6 can you please check and sign again. |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7f1617/22093/summary.html Comparison SummarySummary:
|
+Upgrade For the upgrade side, checking on dict2021 shows identical with master. The backport looks OK and changes are as expected as in the master #36679 for Run-3. |
+1 |
+operations |
This pull request is fully signed and it will be integrated in one of the next CMSSW_12_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Modify muon numbering, adding scenarios for the corretced Run3 geometry. Backport the 2 PR's #36654, #36679. Need a fresh PR for GT to make it work
PR validation:
To be tested with the PR's #36740, #36780, #36781 and #36785
if this PR is a backport please specify the original PR and why you need to backport that PR:
Backporting the PR's already in the master to make the correct Run3 geometry scenario