-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run3-gex108XB Backport SimCore/SimG4CMS related files which can work with the new Run3 geometry #36780
Conversation
A new Pull Request was created by @bsunanda (Sunanda Banerjee) for CMSSW_12_2_X. It involves the following packages:
@perrotta, @civanch, @mdhildreth, @cmsbuild, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild Please test |
-1 Failed Tests: RelVals-INPUT RelVals-INPUT
Comparison SummarySummary:
|
+1 |
@@ -0,0 +1,3 @@ | |||
import FWCore.ParameterSet.Config as cms | |||
|
|||
run2_ECAL_2018 = cms.Modifier() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This modifier does not seem to be needed: please remove
@@ -0,0 +1,4 @@ | |||
import FWCore.ParameterSet.Config as cms | |||
|
|||
run3_geomOld = cms.Modifier() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This modifier must be backported with #36782, where it is missing, instead
@@ -86,6 +86,7 @@ | |||
RestorePhysicsTables = cms.untracked.bool(False), | |||
UseParametrisedEMPhysics = cms.untracked.bool(True), | |||
ThresholdForGeometryExceptions = cms.double(0.01), ## in GeV | |||
TraceExceptions = cms.bool(False), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where does it come from?
Why is it needed?
## | ||
from Configuration.Eras.Modifier_run3_common_cff import run3_common | ||
run3_common.toModify( g4SimHits, CastorSD = dict( useShowerLibrary = False ) ) | ||
run3_common.toModify( g4SimHits, LHCTransport = False ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comes from #36524: could you please clean up from unwanted commits?
phase2_timing.toModify( g4SimHits.ECalSD, | ||
StoreLayerTimeSim = cms.untracked.bool(True), | ||
TimeSliceUnit = cms.double(0.001) ) | ||
phase2_timing.toModify( g4SimHits, ECalSD = dict( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comes from #36524: could you please clean up from unwanted commits?
## | ||
## Disable PPS from Run 3 PbPb runs | ||
## | ||
from Configuration.Eras.Modifier_pp_on_PbPb_run3_cff import pp_on_PbPb_run3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is from #36411: is it needed? I would say no, because LHCTransport is already disabled for Run3. It would deserve a comment, anyhow
h2tb.toModify(g4SimHits.CaloSD, | ||
EminHits = cms.vdouble(0.0,0.0,0.0,0.0,0.0), | ||
TmaxHits = cms.vdouble(1000.0,1000.0,1000.0,1000.0,2000.0) ) | ||
h2tb.toModify(g4SimHits, CaloSD = dict( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also from #36524
@@ -652,9 +666,13 @@ | |||
dd4hep.toModify( g4SimHits, g4GeometryDD4hepSource = True ) | |||
|
|||
## | |||
## Selection of SD's for Phase2 | |||
## Selection of SD's for Phase2, exclude PPS | |||
## | |||
|
|||
from Configuration.Eras.Modifier_phase2_common_cff import phase2_common | |||
phase2_common.toModify(g4SimHits, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is from #36411: is it needed? I would say no, because LHCTransport is already disabled for Run3. It would deserve a comment, anyhow
Pull request #36780 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again. |
@cmsbuild Please test |
@bsunanda @civanch please agree about the appropriateness of backporting #36680, as it is done now (and possibly also the other exception related PRs as mentioned in #36780 (comment)). This is the only remaining issue with this backport PR, once #36780 (review) will also get addressed, |
Thank you Sunanda. |
@perrotta Which fix to be cured - do you mean remove the line LHCTransport = False for phase2 modification? |
No: to add it, as now it is missing |
LHCTRansport = False is set with Run3Common. I am now doing it in Phase2 as well |
Pull request #36780 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again. |
@cmsbuild Please test |
@perrotta Only one thing I did in this update: added back the "LHCTransport = False" in g4SimHits_cfi.py |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-135f05/22196/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_12_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Backport SimCore/SimG4CMS related files which can work with the new Run3 geometry
PR validation:
Use the runTheMatrix test workflows
if this PR is a backport please specify the original PR and why you need to backport that PR:
Backporting the PR's #36652, #36680, #36750, #36411, #36524 which were used to introduce the new Run3 geometry