-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support arbitrary path names in the TriggerResultsFilter in HLTPathStatus mode [12.2.x] #36733
Support arbitrary path names in the TriggerResultsFilter in HLTPathStatus mode [12.2.x] #36733
Conversation
backport #36732 |
please test |
A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_12_2_X. It involves the following packages:
@Martin-Grunewald, @missirol can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
-1 Failed Tests: RelVals-INPUT RelVals-INPUT
Comparison SummarySummary:
|
To state the obvious: the error in "RelVals-INPUT" is unrelated to this PR, and is being seen in other PRs today. Nevertheless, I guess it would be best to rerun the tests once the issue is solved. |
…atus mode Other changes: - clean up and modernise the module - add a new unit test for the HLTPathStatus mode
b12fbfa
to
a729d1c
Compare
Pull request #36733 was updated. @cmsbuild, @missirol, @Martin-Grunewald can you please check and sign again. |
please test |
-1 Failed Tests: RelVals-INPUT RelVals-INPUT
Comparison SummarySummary:
|
+hlt |
This pull request is fully signed and it will be integrated in one of the next CMSSW_12_2_X IBs (but tests are reportedly failing) and once validation in the development release cycle CMSSW_12_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
please test |
-1 Failed Tests: RelVals-INPUT RelVals-INPUT
Comparison SummarySummary:
|
+1 |
merge |
PR description:
Support arbitrary path names in the TriggerResultsFilter in HLTPathStatus mode
Other changes:
PR validation:
The new unit tests should run.
Backport status
This PR is a backport to 12.2.x of #36732 .