Support arbitrary path names in the TriggerResultsFilter in HLTPathStatus mode #36732

fwyzard · 2022-01-18T12:26:32Z

PR description:

Support arbitrary path names in the TriggerResultsFilter in HLTPathStatus mode

Other changes:

clean up and modernise the module
add a new unit test for the HLTPathStatus mode

PR validation:

The new unit tests should run.

fwyzard · 2022-01-18T12:26:43Z

please test

cmsbuild · 2022-01-18T12:35:14Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36732/27831

This PR adds an extra 24KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File HLTrigger/HLTcore/interface/TriggerExpressionConstant.h modified in PR(s): Unit test crash in edm::checkForModuleDependencyCorrectness #36725
- File HLTrigger/HLTcore/interface/TriggerExpressionData.h modified in PR(s): Unit test crash in edm::checkForModuleDependencyCorrectness #36725
- File HLTrigger/HLTcore/interface/TriggerExpressionEvaluator.h modified in PR(s): Unit test crash in edm::checkForModuleDependencyCorrectness #36725
- File HLTrigger/HLTcore/interface/TriggerExpressionOperators.h modified in PR(s): Unit test crash in edm::checkForModuleDependencyCorrectness #36725
- File HLTrigger/HLTcore/interface/TriggerExpressionPathReader.h modified in PR(s): Unit test crash in edm::checkForModuleDependencyCorrectness #36725
- File HLTrigger/HLTcore/src/TriggerExpressionData.cc modified in PR(s): Unit test crash in edm::checkForModuleDependencyCorrectness #36725
- File HLTrigger/HLTfilters/plugins/TriggerResultsFilter.cc modified in PR(s): Unit test crash in edm::checkForModuleDependencyCorrectness #36725
- File HLTrigger/HLTfilters/plugins/TriggerResultsFilter.h modified in PR(s): Unit test crash in edm::checkForModuleDependencyCorrectness #36725
- File HLTrigger/HLTfilters/test/BuildFile.xml modified in PR(s): Unit test crash in edm::checkForModuleDependencyCorrectness #36725
- File HLTrigger/HLTfilters/test/triggerResultsFilter_by_PathStatus.py modified in PR(s): Unit test crash in edm::checkForModuleDependencyCorrectness #36725
- File HLTrigger/HLTfilters/test/triggerResultsFilter_by_TriggerResults.py modified in PR(s): Unit test crash in edm::checkForModuleDependencyCorrectness #36725
- File HLTrigger/HLTfilters/test/triggerResultsFilter.py modified in PR(s): Unit test crash in edm::checkForModuleDependencyCorrectness #36725

cmsbuild · 2022-01-18T12:35:34Z

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

HLTrigger/HLTcore (hlt)
HLTrigger/HLTfilters (hlt)

@Martin-Grunewald, @missirol can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2022-01-18T17:01:27Z

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9c45cc/21771/summary.html
COMMIT: b12fbfa
CMSSW: CMSSW_12_3_X_2022-01-17-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36732/21771/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

4.764.76_ZMuSkim2012D+ZMuSkim2012D+HLTDSKIM2+RECODR1reHLT2+HARVESTDR1reHLT/step2_ZMuSkim2012D+ZMuSkim2012D+HLTDSKIM2+RECODR1reHLT2+HARVESTDR1reHLT.log

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 43
DQMHistoTests: Total histograms compared: 3464860
DQMHistoTests: Total failures: 5
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 3464832
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.004 KiB( 42 files compared)
DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
Checked 181 log files, 42 edm output root files, 43 DQM output files
TriggerResults: no differences found

…atus mode Other changes: - clean up and modernise the module - add a new unit test for the HLTPathStatus mode

fwyzard · 2022-01-18T22:37:43Z

please test

cmsbuild · 2022-01-18T22:46:33Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36732/27847

This PR adds an extra 16KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File HLTrigger/HLTcore/interface/TriggerExpressionConstant.h modified in PR(s): Unit test crash in edm::checkForModuleDependencyCorrectness #36725
- File HLTrigger/HLTcore/interface/TriggerExpressionData.h modified in PR(s): Unit test crash in edm::checkForModuleDependencyCorrectness #36725
- File HLTrigger/HLTcore/interface/TriggerExpressionEvaluator.h modified in PR(s): Unit test crash in edm::checkForModuleDependencyCorrectness #36725
- File HLTrigger/HLTcore/interface/TriggerExpressionOperators.h modified in PR(s): Unit test crash in edm::checkForModuleDependencyCorrectness #36725
- File HLTrigger/HLTcore/interface/TriggerExpressionPathReader.h modified in PR(s): Unit test crash in edm::checkForModuleDependencyCorrectness #36725
- File HLTrigger/HLTcore/src/TriggerExpressionData.cc modified in PR(s): Unit test crash in edm::checkForModuleDependencyCorrectness #36725
- File HLTrigger/HLTfilters/plugins/TriggerResultsFilter.cc modified in PR(s): Unit test crash in edm::checkForModuleDependencyCorrectness #36725
- File HLTrigger/HLTfilters/plugins/TriggerResultsFilter.h modified in PR(s): Unit test crash in edm::checkForModuleDependencyCorrectness #36725
- File HLTrigger/HLTfilters/test/BuildFile.xml modified in PR(s): Unit test crash in edm::checkForModuleDependencyCorrectness #36725
- File HLTrigger/HLTfilters/test/triggerResultsFilter_by_PathStatus.py modified in PR(s): Unit test crash in edm::checkForModuleDependencyCorrectness #36725
- File HLTrigger/HLTfilters/test/triggerResultsFilter_by_TriggerResults.py modified in PR(s): Unit test crash in edm::checkForModuleDependencyCorrectness #36725
- File HLTrigger/HLTfilters/test/triggerResultsFilter.py modified in PR(s): Unit test crash in edm::checkForModuleDependencyCorrectness #36725

cmsbuild · 2022-01-18T22:46:59Z

Pull request #36732 was updated. @Martin-Grunewald, @missirol can you please check and sign again.

cmsbuild · 2022-01-19T04:28:05Z

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9c45cc/21792/summary.html
COMMIT: a729d1c
CMSSW: CMSSW_12_3_X_2022-01-18-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36732/21792/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

4.764.76_ZMuSkim2012D+ZMuSkim2012D+HLTDSKIM2+RECODR1reHLT2+HARVESTDR1reHLT/step2_ZMuSkim2012D+ZMuSkim2012D+HLTDSKIM2+RECODR1reHLT2+HARVESTDR1reHLT.log

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 43
DQMHistoTests: Total histograms compared: 3464860
DQMHistoTests: Total failures: 5
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3464833
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 42 files compared)
Checked 181 log files, 42 edm output root files, 43 DQM output files
TriggerResults: no differences found

missirol · 2022-01-22T14:13:18Z

HLTrigger/HLTfilters/test/triggerResultsFilter_by_PathStatus.py

+
+# L1-like path name
+process.filter_l1path_pattern = triggerResultsFilter.clone(
+    triggerConditions = ( 'L1_Path', ),


Hi @fwyzard, thanks for the PR. I just wanted to ask one clarification before signing it.

In the unit test, I see that the path L1_Path always returns true, but the corresponding TriggerResultFilter (i.e. filter_l1path_pattern) always returns false (for filter_l1path_pattern, I see that m_expression->patterns() is empty). Is this related to how strings starting with L1_ are handled in TriggerExpressionParser.h? Could you please elaborate a bit? (I admit I don't follow the details of this)

fwyzard · 2022-01-22T14:22:42Z

Yes, strings of the format "L1_Something" are always matched to L1 GT/uGT trigger results, even if a corresponding path exists in CMSSW. If I remember correctly the Phase-2 HLT menu uses "L1T_Something" for L1-like selections.

missirol · 2022-01-22T14:26:48Z

+hlt

cmsbuild · 2022-01-22T14:27:05Z

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2022-01-22T19:07:55Z

+1

perrotta · 2022-01-22T19:08:34Z

merge

cmsbuild added this to the CMSSW_12_3_X milestone Jan 18, 2022

cmsbuild added code-checks-pending hlt-pending orp-pending pending-signatures tests-started labels Jan 18, 2022

fwyzard mentioned this pull request Jan 18, 2022

Support arbitrary path names in the TriggerResultsFilter in HLTPathStatus mode [12.2.x] #36733

Merged

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 18, 2022

cmsbuild added tests-rejected and removed tests-started labels Jan 18, 2022

Support arbitrary path names in the TriggerResultsFilter in HLTPathSt…

a729d1c

…atus mode Other changes: - clean up and modernise the module - add a new unit test for the HLTPathStatus mode

fwyzard force-pushed the triggerResultsFilter_by_TriggerResults branch from b12fbfa to a729d1c Compare January 18, 2022 22:37

cmsbuild added code-checks-pending tests-started and removed tests-rejected code-checks-approved labels Jan 18, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 18, 2022

cmsbuild added tests-rejected and removed tests-started labels Jan 19, 2022

Dr15Jones mentioned this pull request Jan 19, 2022

Unit test crash in edm::checkForModuleDependencyCorrectness #36725

Closed

missirol reviewed Jan 22, 2022

View reviewed changes

cmsbuild added fully-signed hlt-approved and removed hlt-pending pending-signatures labels Jan 22, 2022

cmsbuild added orp-approved and removed orp-pending labels Jan 22, 2022

cmsbuild merged commit 772908a into cms-sw:master Jan 22, 2022

fwyzard deleted the triggerResultsFilter_by_TriggerResults branch July 31, 2022 13:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support arbitrary path names in the TriggerResultsFilter in HLTPathStatus mode #36732

Support arbitrary path names in the TriggerResultsFilter in HLTPathStatus mode #36732

fwyzard commented Jan 18, 2022

fwyzard commented Jan 18, 2022

cmsbuild commented Jan 18, 2022

cmsbuild commented Jan 18, 2022

cmsbuild commented Jan 18, 2022

fwyzard commented Jan 18, 2022

cmsbuild commented Jan 18, 2022

cmsbuild commented Jan 18, 2022

cmsbuild commented Jan 19, 2022

missirol Jan 22, 2022

fwyzard commented Jan 22, 2022 via email

missirol commented Jan 22, 2022

cmsbuild commented Jan 22, 2022

perrotta commented Jan 22, 2022

perrotta commented Jan 22, 2022

Support arbitrary path names in the TriggerResultsFilter in HLTPathStatus mode #36732

Support arbitrary path names in the TriggerResultsFilter in HLTPathStatus mode #36732

Conversation

fwyzard commented Jan 18, 2022

PR description:

PR validation:

fwyzard commented Jan 18, 2022

cmsbuild commented Jan 18, 2022

cmsbuild commented Jan 18, 2022

cmsbuild commented Jan 18, 2022

RelVals-INPUT

Comparison Summary

fwyzard commented Jan 18, 2022

cmsbuild commented Jan 18, 2022

cmsbuild commented Jan 18, 2022

cmsbuild commented Jan 19, 2022

RelVals-INPUT

Comparison Summary

missirol Jan 22, 2022

Choose a reason for hiding this comment

fwyzard commented Jan 22, 2022 via email

missirol commented Jan 22, 2022

cmsbuild commented Jan 22, 2022

perrotta commented Jan 22, 2022

perrotta commented Jan 22, 2022