-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DD4hep] use DD4hep consistently in configurations #36004
[DD4hep] use DD4hep consistently in configurations #36004
Conversation
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36004/26439
|
A new Pull Request was created by @ianna (Ianna Osborne) for master. It involves the following packages:
@malbouis, @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @AdrianoDee, @srimanob, @yuanchao, @ggovi, @tvami, @francescobrivio can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7e7a6c/20273/summary.html CMS StaticAnalyzer warnings: There are 2 EventSetupRecord::get warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7e7a6c/20273/llvm-analysis/esrget-sa.txt for details. Comparison SummarySummary:
|
+1
|
+Upgrade Technical PR to resolve the issue of mixing between DD4hep and else (DD4Hep,...). No change is expected. |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
The file Should they be changed for consistency? |
@@ -18,7 +18,7 @@ class HcalTB02ParametersFromDD { | |||
|
|||
private: | |||
static constexpr double k_ScaleFromDDDToG4 = 1.0; | |||
static constexpr double k_ScaleFromDD4HepToG4 = 10.0; | |||
static constexpr double k_ScaleFromDD4hepToG4 = 10.0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bsunanda Not related to this PR, but this value looks wrong. This file may have been missed in the units conversion. I think it should be:
static constexpr double k_ScaleFromDD4hepToG4 = (1.0 / dd4hep::mm);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK Carl I shall take care of this
Doing |
Moreover: with lxr I still can find 53 files with "DD4Hep" in the name: Noteworthy, there are also two files in \test with "DD4HEP" in full capital letters in their names: |
@cvuosalo - thanks! I'll have another go at CMSSW now that it is merged. There were way too many hits before. Thanks! |
There are around 70 places where plus a few I'll take care of it in a subsequent PR. |
PR description:
address issue #33373
PR validation:
if this PR is a backport please specify the original PR and why you need to backport that PR:
Before submitting your pull requests, make sure you followed this checklist: