[DD4hep] [CMSSW_12_1] use DD4hep consistently in configurations - back port to 12_1

[ianna]

PR description:

back port to 12_1: address issue #33373

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

Before submitting your pull requests, make sure you followed this checklist:

• verify that the PR is really intended for the chosen branch
• verify that changes follow CMS Naming, Coding, And Style Rules
• verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

[ianna]

please test

[cmsbuild]

A new Pull Request was created by @ianna (Ianna Osborne) for CMSSW_12_1_X.

It involves the following packages:

• Alignment/MuonAlignment (alca)
• Alignment/OfflineValidation (alca)
• CondTools/DT (db)
• CondTools/Geometry (db)
• Geometry/CMSCommonData (geometry, upgrade)
• Geometry/CaloEventSetup (geometry)
• Geometry/DTGeometry (geometry)
• Geometry/DTGeometryBuilder (geometry)
• Geometry/EcalAlgo (geometry)
• Geometry/EcalCommonData (geometry)
• Geometry/ForwardCommonData (geometry)
• Geometry/GEMGeometryBuilder (geometry, upgrade)
• Geometry/HGCalCommonData (geometry, upgrade)
• Geometry/HcalAlgo (geometry)
• Geometry/HcalCommonData (geometry)
• Geometry/HcalTestBeamData (geometry)
• Geometry/HcalTowerAlgo (geometry)
• Geometry/MuonNumbering (geometry)
• Geometry/RPCGeometryBuilder (geometry)
• Geometry/TrackerGeometryBuilder (geometry)
• Geometry/VeryForwardGeometryBuilder (geometry)
• SimG4Core/Application (simulation)
• SimG4Core/Configuration (simulation)
• SimG4Core/Geometry (simulation)
• SimG4Core/GeometryProducer (simulation)
• SimG4Core/PrintGeomInfo (simulation)

@malbouis, @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @AdrianoDee, @srimanob, @yuanchao, @ggovi, @tvami, @francescobrivio can you please review it and eventually sign? Thanks.
@abbiendi, @CeliaFernandez, @argiro, @jshlee, @bsunanda, @jhgoh, @thomreis, @tlampen, @slomeo, @venturia, @pakhotin, @battibass, @makortel, @JanFSchulte, @watson-ij, @simonepigazzini, @trocino, @cvuosalo, @fabferro, @rovere, @VinInn, @dildick, @tocheng, @mmusich, @ptcox, @mtosi, @fabiocos, @adewit, @rchatter, @jan-kaspar this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

• Backported from [DD4hep] use DD4hep consistently in configurations #36004

[cmsbuild]

Pull request #36003 was updated. @malbouis, @civanch, @yuanchao, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob, @Dr15Jones, @ggovi, @tvami, @francescobrivio can you please check and sign again.

[ianna]

please test

[tvami]

backport of #36004

[tvami]

Hi @ianna please edit the PR title by including [12_1_X] in it (signaling that this now is a backport)

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d64f31/20271/summary.html
COMMIT: 532fb7d
CMSSW: CMSSW_12_1_X_2021-11-04-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36003/20271/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 22 differences found in the comparisons
• DQMHistoTests: Total files compared: 42
• DQMHistoTests: Total histograms compared: 2901440
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2901417
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
• Checked 177 log files, 37 edm output root files, 42 DQM output files
• TriggerResults: no differences found

[tvami]

+1

• tests come back all good
• PR title should change to reflect that this is a backport to 12_1_X

[srimanob]

+Upgrade

Backport of #36004.
Technical PR to resolve the issue of mix using of DD4hep and else.

[perrotta]

@ianna I don't understand the reason to backport these PRs to 12_1_X, which is a short term cycle only intended to produce the digi premix samples.
Could you please either close or explain which is the purpose of the backport?

[ianna]

@ianna I don't understand the reason to backport these PRs to 12_1_X, which is a short term cycle only intended to produce the digi premix samples.
Could you please either close or explain which is the purpose of the backport?

It's just to make sure we have clean naming conventions and no accidental reference to an old naming. The PR does not change any functionality.

[civanch]

+1

PR is correct @perrotta , @qliphy , it is your decision accept or not.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

PR is correct @perrotta , @qliphy , it is your decision accept or not.

Thank you all!
However, such large code changes (with, at best, no practical effect on the productions foreseen with the release) cannot be accepted in closed release cycles. Let have it in 12_2_X, and in all subsequent cycles as a consequence.

[perrotta]

-1

[qliphy]

close by above comments.