-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
customize OnlineBeamSpotESProducer
inputs to be refreshed at each LS in online DQM [12.0.X]
#35897
customize OnlineBeamSpotESProducer
inputs to be refreshed at each LS in online DQM [12.0.X]
#35897
Conversation
A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_12_0_X. It involves the following packages:
@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@ahmad3213 @pmandrik @jfernan2 this should be tested with playback on run 346373 please. |
urgent |
type bug-fix |
@cmsbuild please test |
695a822
to
338c01b
Compare
Pull request #35897 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please check and sign again. |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a97f80/20045/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_12_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
@perrotta @qliphy this is all signed, would be good to merge it asap so DQM (@ahmad3213 and @pmandrik) can deploy in production in P5 for the SB tonight. The validation comes from this plot: which shows 1 peak around zero rather than 2 peaks as it was seen online yesterday in: |
@francescobrivio Ok, we can merge it now. But notice usually we need the master PR to be merged first. |
+1 |
backport of #35896
PR description:
During the 2021 October LHC beam test run it was noticed that, while in the first run with reasonable placing of the LHC luminous region (346373) an online beamspot measurement was available at around LS=10 (see online DQM GUI and log of the upload to the Conditions Database),
the information about the change of condition was not propagated properly to the other clients (see e.g. this plot from the same run of the track distance w.r.t BeamSpot: online DQM GUI).
This likely means that at P5 the refresh of the conditions needed for the
OnlineBeamSposESProducer
arbitration was not enabled (as I think the frontier connection is configured as for the HLT).We provide hear the same customization of the
GlobalTag
ESSource
used in the HLT menu to recover from this issue.I notice en passant that the next run (346374) did pick up the right conditions in the online GUI ( link ) and the Express DQM instead picked up the right conditions in both cases, corroborating the case for a missing refresh of the input.
PR validation:
This PR should be tested in the DQM online playback system using run 346373.
if this PR is a backport please specify the original PR and why you need to backport that PR:
backport of #35896
cc:
@gennai @francescobrivio @mtosi @vmariani