-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
customize OnlineBeamSpotESProducer
inputs to be refreshed at each LS in online DQM
#35896
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35896/26297
|
@cmsbuild please test |
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages:
@emanueleusai, @ahmad3213, @jfernan2, @rvenditti, @pbo0, @pmandrik can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
2f5825f
to
58bd87e
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35896/26298
|
Pull request #35896 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please check and sign again. |
please test |
-1 Failed Tests: UnitTests RelVals-INPUT Unit TestsI found errors in the following unit tests: ---> test TestDQMServicesDemo had ERRORS RelVals-INPUT
Comparison SummarySummary:
|
please test with #35890 |
-1 Failed Tests: UnitTests Unit TestsI found errors in the following unit tests: ---> test TestDQMServicesDemo had ERRORS Comparison SummarySummary:
|
please test with #35921 |
@cms-sw/cms-sw-admins it seems that the command above was not executed by the bot: #35896 (comment) |
@cmsbuild ping |
please test with #35921 |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15708c/20143/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
During the 2021 October LHC beam test run it was noticed that, while in the first run with reasonable placing of the LHC luminous region (346373) an online beamspot measurement was available at around LS=10 (see online DQM GUI and log of the upload to the Conditions Database),
the information about the change of condition was not propagated properly to the other clients (see e.g. this plot from the same run of the track distance w.r.t BeamSpot: online DQM GUI).
This likely means that at P5 the refresh of the conditions needed for the
OnlineBeamSposESProducer
arbitration was not enabled (as I think the frontier connection is configured as for the HLT).We provide here the same customization of the
GlobalTag
ESSource
used in the HLT menu to recover this issue.I notice en passant that the next run (346374) did pick up the right conditions in the online GUI ( link ) and the Express DQM instead picked up the right conditions in both cases, corroborating the case for a missing refresh of the input.
PR validation:
The backport of this PR should be tested in the DQM online playback system using run 346373.
if this PR is a backport please specify the original PR and why you need to backport that PR:
Not a backport, but will be backported.
cc:
@gennai @francescobrivio @mtosi @vmariani