Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

customize OnlineBeamSpotESProducer inputs to be refreshed at each LS in online DQM #35896

Merged
merged 1 commit into from
Nov 2, 2021

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Oct 29, 2021

PR description:

During the 2021 October LHC beam test run it was noticed that, while in the first run with reasonable placing of the LHC luminous region (346373) an online beamspot measurement was available at around LS=10 (see online DQM GUI and log of the upload to the Conditions Database),

image

the information about the change of condition was not propagated properly to the other clients (see e.g. this plot from the same run of the track distance w.r.t BeamSpot: online DQM GUI).

image

This likely means that at P5 the refresh of the conditions needed for the OnlineBeamSposESProducer arbitration was not enabled (as I think the frontier connection is configured as for the HLT).
We provide here the same customization of the GlobalTag ESSource used in the HLT menu to recover this issue.
I notice en passant that the next run (346374) did pick up the right conditions in the online GUI ( link ) and the Express DQM instead picked up the right conditions in both cases, corroborating the case for a missing refresh of the input.

PR validation:

The backport of this PR should be tested in the DQM online playback system using run 346373.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not a backport, but will be backported.
cc:
@gennai @francescobrivio @mtosi @vmariani

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35896/26297

  • This PR adds an extra 12KB to repository

@francescobrivio
Copy link
Contributor

@cmsbuild please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • DQM/Integration (dqm)

@emanueleusai, @ahmad3213, @jfernan2, @rvenditti, @pbo0, @pmandrik can you please review it and eventually sign? Thanks.
@battibass, @threus, @batinkov, @francescobrivio this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35896/26298

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

Pull request #35896 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Oct 29, 2021

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15708c/20046/summary.html
COMMIT: 58bd87e
CMSSW: CMSSW_12_1_X_2021-10-28-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35896/20046/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test TestDQMServicesDemo had ERRORS

RelVals-INPUT

  • 138.3138.3_RunMinimumBias2021Splash+RunMinimumBias2021Splash+RECODR3Splash+HARVESTDR3/step2_RunMinimumBias2021Splash+RunMinimumBias2021Splash+RECODR3Splash+HARVESTDR3.log

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 2901440
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2901411
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented Oct 29, 2021

please test with #35890

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15708c/20074/summary.html
COMMIT: 58bd87e
CMSSW: CMSSW_12_2_X_2021-10-29-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35896/20074/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test TestDQMServicesDemo had ERRORS

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 2901440
  • DQMHistoTests: Total failures: 12
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2901405
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 41 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented Oct 31, 2021

please test with #35921

@mmusich
Copy link
Contributor Author

mmusich commented Nov 1, 2021

@cms-sw/cms-sw-admins it seems that the command above was not executed by the bot: #35896 (comment)

@mmusich
Copy link
Contributor Author

mmusich commented Nov 1, 2021

@cmsbuild ping

@mmusich
Copy link
Contributor Author

mmusich commented Nov 1, 2021

please test with #35921

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15708c/20143/summary.html
COMMIT: 58bd87e
CMSSW: CMSSW_12_2_X_2021-10-31-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35896/20143/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 2901890
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2901868
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

jfernan2 commented Nov 2, 2021

+1
Backport tested in Online DQM at P5

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Nov 2, 2021

+1

@cmsbuild cmsbuild merged commit 2d78b66 into cms-sw:master Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants