Enable GEM trigger clusters from EMTF in GEM L1T DQM #35666

dildick · 2021-10-14T01:51:37Z

PR description:

Data vs emulation for GEM TPs in GEM L1T DQM. The purpose of this PR is not to figure out the differences, but rather update the L1T GEM DQM for Run-3. Basically, valMuonGEMPadDigiClusters is replaced with emtfStage2Digis since we now have GEM trigger data arriving at the EMTF. The data is not necessarily good, and I think it shows in the data-vs-emulation plots.

PR validation:

Tested on 10k events of RAW Run-3 data, run 344064. There are many differences, to be discussed at GEM-CSC meetings.

GEM_dataVsEmul_CMS_Run_344064.pdf

Instructions to reproduce the slides on lxplus:

## unpack+re-emulate+dqm
cmsRun L1Trigger/CSCTriggerPrimitives/test/runCSCTriggerPrimitiveProducer_cfg.py l1GEM=True mc=False dqmGEM=True \
inputFiles=root:///eos/cms/store/data/Commissioning2021/Cosmics/RAW/v1/000/344/064/00000/dade01f7-bc85-491f-9c9c-7457af399849.root \
maxEvents=10000 dqm=True unpack=True unpackGEM=True l1=True useEmtfGEM=True

## dqm client
cmsRun L1Trigger/CSCTriggerPrimitives/test/runCSCL1TDQMClient_cfg.py useGEMs=True

## validation report
cmsRun L1Trigger/L1TGEM/test/runGEMTriggerPrimitiveAnalyzer_cfg.py dataVsEmulation=True runNumber=344064 \
dataVsEmulationFile=file:DQM_V0001_R000344064__Global__CMSSW_X_Y_Z__RECO.root

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

dildick · 2021-10-14T01:53:28Z

The same plots are added below:

cmsbuild · 2021-10-14T01:58:03Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35666/25946

This PR adds an extra 24KB to repository

cmsbuild · 2021-10-14T01:58:26Z

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

DQM/L1TMonitor (dqm)
L1Trigger/CSCTriggerPrimitives (l1)
L1Trigger/L1TGEM (l1)

@emanueleusai, @ahmad3213, @cmsbuild, @rekovic, @jfernan2, @pmandrik, @cecilecaillol, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@valuev, @missirol, @ptcox, @Martin-Grunewald this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

jfernan2 · 2021-10-14T06:51:55Z

please test

cmsbuild · 2021-10-14T11:48:34Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c7f842/19619/summary.html
COMMIT: c4f94ae
CMSSW: CMSSW_12_1_X_2021-10-13-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35666/19619/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 8 differences found in the comparisons
DQMHistoTests: Total files compared: 40
DQMHistoTests: Total histograms compared: 2796107
DQMHistoTests: Total failures: 35
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2796049
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.004 KiB( 39 files compared)
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
Checked 169 log files, 37 edm output root files, 40 DQM output files
TriggerResults: no differences found

dildick · 2021-10-14T11:51:20Z

@jfernan2 If we want this to be available at P5 for the upcoming test-beam, does it have to be backported to CMSSW_12_0_X?

jfernan2 · 2021-10-14T11:52:58Z

@jfernan2 If we want this to be available at P5 for the upcoming test-beam, does it have to be backported to CMSSW_12_0_X?

Yes, we need backport to 12_0_X

On the other hand, some GEM plots lose stats while others gain, is this expected?
https://tinyurl.com/ygddjerc
https://tinyurl.com/ydsko9wk

dildick · 2021-10-14T11:54:39Z

Before this change, only the "emulated" GEM trigger clusters made any sense. "data" was a copy of "emulated" and "diff" was empty by definition.

dildick · 2021-10-14T11:57:18Z

Snapshot of one of the links:

"Emulated" does not change. Only "data" and "diff"

dildick · 2021-10-14T12:15:34Z

It looks like I shifted the histograms 1 bin to the right... I need to fix that.

jfernan2 · 2021-10-14T14:47:10Z

please test

jfernan2 · 2021-10-14T15:55:42Z

please test

cmsbuild · 2021-10-14T19:17:04Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c7f842/19638/summary.html
COMMIT: 828127e
CMSSW: CMSSW_12_1_X_2021-10-14-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35666/19638/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 6 differences found in the comparisons
DQMHistoTests: Total files compared: 40
DQMHistoTests: Total histograms compared: 2796107
DQMHistoTests: Total failures: 34
DQMHistoTests: Total nulls: 13
DQMHistoTests: Total successes: 2796038
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.004 KiB( 39 files compared)
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
Checked 169 log files, 37 edm output root files, 40 DQM output files
TriggerResults: no differences found

jfernan2 · 2021-10-14T19:19:17Z

@dildick please check that everything looks as expected:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_12_1_X_2021-10-14-1100+c7f842/46177/dqm-histo-comparison-summary.html

dildick · 2021-10-14T19:29:44Z

Looks good. Thanks @jfernan2.

jfernan2 · 2021-10-14T19:40:42Z

+1

dildick · 2021-10-15T19:17:28Z

@rekovic Can you sign off, please? There is no update in the emulation, just a test L1T configuration.

qliphy · 2021-10-22T00:32:17Z

ping @cms-sw/l1-l2

rekovic · 2021-10-26T09:30:15Z

@dildick #35666 (comment).
Ok, since the in emulator configuration changes are in /test.

rekovic · 2021-10-26T09:30:27Z

+1

cmsbuild · 2021-10-26T09:30:34Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

dildick · 2021-10-26T14:41:33Z

@qliphy

perrotta · 2021-10-26T19:21:28Z

+1

dildick · 2021-10-28T12:54:12Z

@jfernan2 Does it make sense to do a backport of the changes in DQM/L1TMonitor to update the DQM for ongoing tests at P5?

dildick · 2021-10-28T13:27:28Z

@jfernan2 Actually, it turns out that this PR is incomplete. In a GEM-CSC trigger meeting I found out that the GEM DAQ works very different: rather than only reading out BX0, it integrates over 7BX [BX-3, BX-2, BX-1, BX0, BX+1, BX+2, BX+3] and then assigns the DAQ data to BX0... To do data-vs-emulation comparisons, I'll need to add a feature in the L1T DQM that first gets all the GEM clusters, then sets their BX to BX0, and then does the comparison. So I need to fix this PR before doing any backports! Sorry!

jfernan2 · 2021-10-28T14:25:28Z

OK, just let us know.
Thanks

cmsbuild added this to the CMSSW_12_1_X milestone Oct 14, 2021

cmsbuild added code-checks-pending dqm-pending l1-pending orp-pending pending-signatures tests-pending labels Oct 14, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 14, 2021

cmsbuild added tests-started and removed tests-pending labels Oct 14, 2021

cmsbuild added tests-approved and removed tests-started labels Oct 14, 2021

Data vs emulation for GEM TPs in DQM

e35ff00

cmsbuild added code-checks-pending tests-pending and removed tests-approved code-checks-approved labels Oct 14, 2021

Fix BX window

17f58e2

cmsbuild added tests-started and removed tests-pending labels Oct 14, 2021

cmsbuild added tests-approved and removed tests-started labels Oct 14, 2021

cmsbuild added dqm-approved and removed dqm-pending labels Oct 14, 2021

cmsbuild added fully-signed l1-approved and removed l1-pending pending-signatures labels Oct 26, 2021

cmsbuild added orp-approved and removed orp-pending labels Oct 26, 2021

cmsbuild merged commit bb40965 into cms-sw:master Oct 26, 2021

dildick deleted the from-CMSSW_12_1_X_2021-10-13-1100-data-vs-emulation-gem-tp-dqm branch October 26, 2021 19:25

cmsbuild mentioned this pull request Oct 27, 2021

default initialize HiPuRhoProducer::postOrphan_ #35857

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable GEM trigger clusters from EMTF in GEM L1T DQM #35666

Enable GEM trigger clusters from EMTF in GEM L1T DQM #35666

dildick commented Oct 14, 2021 •

edited

Loading

dildick commented Oct 14, 2021

cmsbuild commented Oct 14, 2021

cmsbuild commented Oct 14, 2021

jfernan2 commented Oct 14, 2021

cmsbuild commented Oct 14, 2021

dildick commented Oct 14, 2021 •

edited

Loading

jfernan2 commented Oct 14, 2021

dildick commented Oct 14, 2021

dildick commented Oct 14, 2021

dildick commented Oct 14, 2021

jfernan2 commented Oct 14, 2021

jfernan2 commented Oct 14, 2021

cmsbuild commented Oct 14, 2021

jfernan2 commented Oct 14, 2021

dildick commented Oct 14, 2021

jfernan2 commented Oct 14, 2021

dildick commented Oct 15, 2021 •

edited

Loading

qliphy commented Oct 22, 2021

rekovic commented Oct 26, 2021

rekovic commented Oct 26, 2021

cmsbuild commented Oct 26, 2021

dildick commented Oct 26, 2021

perrotta commented Oct 26, 2021

dildick commented Oct 28, 2021

dildick commented Oct 28, 2021

jfernan2 commented Oct 28, 2021

Enable GEM trigger clusters from EMTF in GEM L1T DQM #35666

Enable GEM trigger clusters from EMTF in GEM L1T DQM #35666

Conversation

dildick commented Oct 14, 2021 • edited Loading

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

dildick commented Oct 14, 2021

cmsbuild commented Oct 14, 2021

cmsbuild commented Oct 14, 2021

jfernan2 commented Oct 14, 2021

cmsbuild commented Oct 14, 2021

Comparison Summary

dildick commented Oct 14, 2021 • edited Loading

jfernan2 commented Oct 14, 2021

dildick commented Oct 14, 2021

dildick commented Oct 14, 2021

dildick commented Oct 14, 2021

jfernan2 commented Oct 14, 2021

jfernan2 commented Oct 14, 2021

cmsbuild commented Oct 14, 2021

Comparison Summary

jfernan2 commented Oct 14, 2021

dildick commented Oct 14, 2021

jfernan2 commented Oct 14, 2021

dildick commented Oct 15, 2021 • edited Loading

qliphy commented Oct 22, 2021

rekovic commented Oct 26, 2021

rekovic commented Oct 26, 2021

cmsbuild commented Oct 26, 2021

dildick commented Oct 26, 2021

perrotta commented Oct 26, 2021

dildick commented Oct 28, 2021

dildick commented Oct 28, 2021

jfernan2 commented Oct 28, 2021

dildick commented Oct 14, 2021 •

edited

Loading

dildick commented Oct 14, 2021 •

edited

Loading

dildick commented Oct 15, 2021 •

edited

Loading