-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PPS: use Run3 era in online DQM #35550
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35550/25784
|
A new Pull Request was created by @jan-kaspar for master. It involves the following packages:
@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
type bug-fix |
please test |
-1 Failed Tests: UnitTests Unit TestsI found errors in the following unit tests: ---> test TestDQMOnlineClient-ctpps_dqm_sourceclient had ERRORS Comparison SummarySummary:
|
I believe the crash is due to the GT, which is not using the last one compatible with CT-PPS in DQM/Integration/python/config/FrontierCondition_GT_cfi.py DQM/Integration/python/config/FrontierCondition_GT_autoExpress_cfi.py With these GTs above we see no crash in Online DQM at P5 using this PR. However since the unitTest done here by the bot is taking run 334393 from 2019, I am not sure if the test will succeed. |
I'll comment on the backport PR, but I do think the issue is with the GT not compatible with the Run-3 era, and so we need to use the candidate GT, but the file would be in conflict for 12_1_X... |
OK, sorry, yes I should have commented in the backport, my apologies. The thing is to get a working version for master and 12_0_X I assume |
This PR has been tested with #35593 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
test parameters: |
@cmsbuild , please test
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e8f0e0/19569/summary.html Comparison SummarySummary:
|
+1 |
PR description:
The era modifier used in online DQM config of PPS is updated to
Run3
. This is a bug fix - currentlyRun2_2018
is used.PR validation:
The following command
cmsRun DQM/Integration/python/clients/ctpps_dqm_sourceclient-live_cfg.py
was executed on LXPLUS. The process runs without errors (but obviously it cannot find input data).