Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PPS: use Run3 era in online DQM #35550

Merged
merged 1 commit into from
Oct 13, 2021
Merged

Conversation

jan-kaspar
Copy link
Contributor

PR description:

The era modifier used in online DQM config of PPS is updated to Run3. This is a bug fix - currently Run2_2018 is used.

PR validation:

The following command
cmsRun DQM/Integration/python/clients/ctpps_dqm_sourceclient-live_cfg.py
was executed on LXPLUS. The process runs without errors (but obviously it cannot find input data).

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35550/25784

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2021

A new Pull Request was created by @jan-kaspar for master.

It involves the following packages:

  • DQM/Integration (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@battibass, @threus, @batinkov, @francescobrivio this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@francescobrivio
Copy link
Contributor

type bug-fix

@jfernan2
Copy link
Contributor

jfernan2 commented Oct 6, 2021

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2021

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e8f0e0/19436/summary.html
COMMIT: 643dae0
CMSSW: CMSSW_12_1_X_2021-10-06-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35550/19436/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test TestDQMOnlineClient-ctpps_dqm_sourceclient had ERRORS

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 40
  • DQMHistoTests: Total histograms compared: 3219394
  • DQMHistoTests: Total failures: 5
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3219367
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 39 files compared)
  • Checked 169 log files, 37 edm output root files, 40 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

jfernan2 commented Oct 6, 2021

I believe the crash is due to the GT, which is not using the last one compatible with CT-PPS in

DQM/Integration/python/config/FrontierCondition_GT_cfi.py
->"120X_dataRun3_HLT_Candidate_2021_09_30_19_21_44"

DQM/Integration/python/config/FrontierCondition_GT_autoExpress_cfi.py
-> '120X_dataRun3_Express_Candidate_2021_09_30_18_36_13'

With these GTs above we see no crash in Online DQM at P5 using this PR.

However since the unitTest done here by the bot is taking run 334393 from 2019, I am not sure if the test will succeed.
Any idea @francescobrivio @tvami ?

@tvami
Copy link
Contributor

tvami commented Oct 6, 2021

I'll comment on the backport PR, but I do think the issue is with the GT not compatible with the Run-3 era, and so we need to use the candidate GT, but the file would be in conflict for 12_1_X...

@jfernan2
Copy link
Contributor

jfernan2 commented Oct 6, 2021

OK, sorry, yes I should have commented in the backport, my apologies.
Anyway, since I am assuming this is a temporary situation, for running in Online DQM at P5, we can tune GT manually until the situation gets stable. Until now we were using autoCond['run3_hlt'] and autoCond['run3_data_express´] resp.

The thing is to get a working version for master and 12_0_X I assume

@qliphy
Copy link
Contributor

qliphy commented Oct 12, 2021

This PR has been tested with #35593
#35593 (comment)

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@tvami
Copy link
Contributor

tvami commented Oct 12, 2021

test parameters:

@tvami
Copy link
Contributor

tvami commented Oct 12, 2021

@cmsbuild , please test

  • just to get rid of tests-rejected

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e8f0e0/19569/summary.html
COMMIT: 643dae0
CMSSW: CMSSW_12_1_X_2021-10-12-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35550/19569/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 40
  • DQMHistoTests: Total histograms compared: 2798082
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2798054
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 39 files compared)
  • Checked 169 log files, 37 edm output root files, 40 DQM output files
  • TriggerResults: no differences found

@qliphy
Copy link
Contributor

qliphy commented Oct 13, 2021

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants