Added DQM module for PPS dedicated random stream

[AndreaBellora]

PR description:

This PR adds a DQM module meant to be run at T0-express with a new stream as input.
The new express stream has been requested in https://its.cern.ch/jira/browse/CMSHLT-2606
The plots contain the number of digis per BX and plane in the PPS pixel detectors, which are necessary for monitoring the latency.
A backport to 13_0_0 will be submitted once the code is finalized.

PR validation:

Testing/validation of the module has been done running
cmsRun DQM/CTPPS/test/pps_random_dqm_test_from_alcaraw_cfg.py
and using a test file produced following the instructions given in the HLT Jira ticket.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40895/34378

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @AndreaBellora for master.

It involves the following packages:

• DQM/CTPPS (dqm)

@emanueleusai, @cmsbuild, @syuvivida, @rvenditti, @micsucmed, @pmandrik can you please review it and eventually sign? Thanks.
@fabferro, @grzanka this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from DQM module for PPS random stream - backport #41049

[AndreaBellora]

There's actually still one pending point. This DQM module requires the PPS pixel raw2digi step to be performed before running the DQM source and harvester.
This is done by cloning the equivalent alcareco step and adding it to the sequence in the test config:

from EventFilter.CTPPSRawToDigi.ctppsRawToDigi_cff import ctppsPixelDigis as _ctppsPixelDigis
process.ctppsPixelDigisAlCaRecoProducer = _ctppsPixelDigis.clone(inputLabel = 'hltPPSCalibrationRaw')

Something similar will be needed in the sequence that runs at T0-express. Where should I define such a sequence or what is the best practice for this?

[emanueleusai]

type ctpps

[emanueleusai]

please test

[cmsbuild]

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-db5c7a/30961/summary.html
COMMIT: 432c76c
CMSSW: CMSSW_13_1_X_2023-02-28-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40895/30961/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-02-28-2300/src/DQM/CTPPS/plugins/TotemT2DQMSource.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-02-28-2300/src/DQM/CTPPS/plugins/TotemTimingDQMSource.cc
>> Building edm plugin tmp/el8_amd64_gcc11/src/DQM/CTPPS/plugins/DQMCTPPSPlugins/libDQMCTPPSPlugins.so
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02774/el8_amd64_gcc11/external/gcc/11.2.1-f9b9dfdd886f71cd63f5538223d8f161/bin/../lib/gcc/x86_64-redhat-linux-gnu/11.2.1/../../../../x86_64-redhat-linux-gnu/bin/ld: tmp/el8_amd64_gcc11/src/DQM/CTPPS/plugins/DQMCTPPSPlugins/ccGZQfoY.ltrans3.ltrans.o: in function `CTPPSRandomDQMSource::CTPPSRandomDQMSource(edm::ParameterSet const&)':
:(.text+0x16ec): undefined reference to `vtable for CTPPSRandomDQMSource'
collect2: error: ld returned 1 exit status
gmake: *** [tmp/el8_amd64_gcc11/src/DQM/CTPPS/plugins/DQMCTPPSPlugins/libDQMCTPPSPlugins.so] Error 1
Leaving library rule at src/DQM/CTPPS/plugins
Entering library rule at DQM/CTPPS
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-02-28-2300/src/DQM/CTPPS/src/TotemT2Segmentation.cc
>> Building shared library tmp/el8_amd64_gcc11/src/DQM/CTPPS/src/DQMCTPPS/libDQMCTPPS.so


[emanueleusai]

@AndreaBellora the code isn't compiling according to unit tests.
In the meantime we'll investigate how to add the sequence you need at T0-express

[missirol]

I'm not a DQM reviewer, but this PR caught my eye as it ignores many of the CMSSW coding rules. Up to DQM to enforce these suggestions if they find them useful.

[AndreaBellora]

@AndreaBellora the code isn't compiling according to unit tests. In the meantime we'll investigate how to add the sequence you need at T0-express

This is a bit weird, when I ran locally it passed the usual compilation/code checks. I'm checking again...

[AndreaBellora]

@missirol Thank you very much! Actually, most of the code was inherited from DQM/CTPPS/plugins/CTPPSPixelDQMSource.cc, which I assumed was satisfying all coding rules. I'm implementing all the comments and pushing a fix

[missirol]

I'm implementing all the comments and pushing a fix

@AndreaBellora , sounds good, thanks for addressing the comments.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40895/34806

• This PR adds an extra 24KB to repository

[cmsbuild]

Pull request #40895 was updated. @emanueleusai, @cmsbuild, @syuvivida, @rvenditti, @micsucmed, @pmandrik can you please check and sign again.

[emanueleusai]

@francescobrivio @AndreaBellora yes let's keep the other two improvements for a separate PR

[emanueleusai]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-db5c7a/31572/summary.html
COMMIT: a55d2c1
CMSSW: CMSSW_13_1_X_2023-03-23-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40895/31572/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3552750
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3552725
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[emanueleusai]

+1

[emanueleusai]

unhold

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1