-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PPS: Run3 alignment fix for direct simulation #35424
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35424/25549
|
A new Pull Request was created by @jan-kaspar for master. It involves the following packages:
@civanch, @Dr15Jones, @makortel, @cvuosalo, @emanueleusai, @ianna, @mdhildreth, @cmsbuild, @jfernan2, @ahmad3213, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f40c08/18942/summary.html Comparison SummaryThe workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons Summary:
|
+1 |
Regression difference in 140.53 is not connected with this PR. |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
About 2022 geometry, do you prefer to remove it for now or keep as it is in this PR ? @civanch |
+1 |
PR description:
This PR intends mostly to correct for an undesired effect of #35380 (and erratum #35399) on the "direct" simulation of forward protons in PPS, in the Run3 profiles.
Technically, this PR includes the following changes.
Geometry/VeryForwardGeometry/python/geometryRPFromDD_2021_cfi.py
now loads the latest versioned config (introduced in Fixes for PPS geometry on Pixel sensors and materials #35380). This makes the changes from Fixes for PPS geometry on Pixel sensors and materials #35380 effective to PPS direct simulation and other PPS applications: in particularly moving the pixel sensors closer to the beam by ~750 um in Run3 scenarios.For Run2, no changes in results are expected.
No backport is foreseen.
PR validation:
Below a summary plot from Run3 scenarios of the direct simulation. Blue = before this PR. Green = with this PR, but only after "activation" of the changes from #35380. Red dashed = at the end of this PR, i.e. including the compensation shift. Especially the x histograms show the shifts of the RP acceptance closer to and further from the LHC beam (x = 0). The compensation shift (blue - red comparison) is not perfect, but good enough (the RP approach to the beam is just a forecast anyway).
dirsim_cmp_Run3.pdf
For Run2, the plots below compare the results before this PR (blue, covered with green) and after this PR (red dashed)
@fabferro @diemort @grzanka FYI