Enable services in concurrent endJob processing

[Dr15Jones]

PR description:

The service system was not being enabled in the new concurrent tasks.

PR validation:

Code compiles.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35120/25014

• This PR adds an extra 32KB to repository

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

• FWCore/Framework (core)

@makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @wddgit this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

Please test

[qliphy]

Thanks @Dr15Jones
I have tested with CMSSW_12_1_X_2021-09-01-2300 + this PR
and it works well with "runTheMatrix.py -l 200 --job-reports -t 4 --ibeos"

[qliphy]

type bugfix

[qliphy]

urgent

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b6af40/18239/summary.html
COMMIT: 3bfd796
CMSSW: CMSSW_12_1_X_2021-09-01-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35120/18239/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @swagata87 [EGM HLT] Phase out calotower & use HCAL recHits directly #35049
• @makortel Migrate BMixingModule and EcalShapeBase-derived classes to esConsumes #34902
• @ggovi Delete unused headers/test files (DB packages) #34933
• @guitargeek Merge .h and .cc files of plugins in several PhysicsTools packages #34615
• @TaeunKwon HCAL: fixing pulse containment correction algorithm for Run3 trigger primitives #34805
• @jeongeun Migrate module configuration in PhysicsTools{PatUtils} to use default cfipython #35101
• @perrotta Get rid of the unneeded conf_ class member in SiPixelPhase1EfficiencyExtras #35102
• @smuzaffar [L1Trigger] Move public headers in to interface directory #34895

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b6af40/18239/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b6af40/18239/git-merge-result

RelVals-INPUT

• 136.72413136.72413_RunJetHT2016B_reminiaodUL+RunJetHT2016B_reminiaodUL+REMININANO_data2016UL_HIPM_met+HARVESTDR2_REMININANO_data2016UL_HIPM_met/step2_RunJetHT2016B_reminiaodUL+RunJetHT2016B_reminiaodUL+REMININANO_data2016UL_HIPM_met+HARVESTDR2_REMININANO_data2016UL_HIPM_met.log

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 3000404
• DQMHistoTests: Total failures: 1334
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2999048
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: found differences in 4 / 38 workflows

[srimanob]

Please test with #35121

[smuzaffar]

@qliphy if this fixes the massive relvals errors then I would suggest to ignore the INPUT error and merge it before 11AM

[smuzaffar]

ah there are "DQMHistoTests: Total failures: 1334" comparison failure,

[qliphy]

ah there are "DQMHistoTests: Total failures: 1334" comparison failure,

It seems to be from #34805
and are as expected.

[makortel]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b6af40/18249/summary.html
COMMIT: 3bfd796
CMSSW: CMSSW_12_1_X_2021-09-01-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35120/18249/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 3000404
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3000376
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[qliphy]

+1