[EGM HLT] Phase out calotower & use HCAL recHits directly #35049

swagata87 · 2021-08-27T16:37:44Z

PR description:

This PR adds a new HLT producer which uses HBHE recHits directly to produce H for H/E and HCAL isolation of e/gamma objects. The old producer, which used calotowers to produce those variables, will still be available. This change in HLT is a follow up of what has already been done in offline e/gamma by @afiqaize in
PR: #33666
relevant HN post: https://hypernews.cern.ch/HyperNews/CMS/get/egamma/2475.html

PR validation:

Ran e/gamma HLT including the new producer.
Relevant config (to produce single HCAL tower based H for H/E):

process.hltEgammaHoverESingleTowernew = cms.EDProducer( "EgammaHLTHcalVarProducerFromRecHit",
    recoEcalCandidateProducer = cms.InputTag( "hltEgammaCandidates" ),
    rhoProducer = cms.InputTag( "hltFixedGridRhoFastjetAllCaloForMuons" ),
    doRhoCorrection = cms.bool( False ),
    rhoMax = cms.double( 9.9999999E7 ),
    rhoScale = cms.double( 1.0 ),
    innerCone = cms.double( 0.0 ),
    outerCone = cms.double( 0.0 ),
    doEtSum = cms.bool( False ),
    useSingleTower = cms.bool( True ),
    hbheRecHitsTag = cms.InputTag( "hltHbhereco" ),
    effectiveAreas = cms.vdouble( 0.105, 0.17 ),
    absEtaLowEdges = cms.vdouble( 0.0, 1.479 )
)

Then compared it with results obtained from old producer; by running on

1)DY events

2)QCD(Pt>600 GeV) events

Note that an exact match is not expected, as the calotower creation logic is slightly different than what we are doing here with recHits directly.

This PR is not a backport.
Backport is not needed.

cmsbuild · 2021-08-27T16:45:50Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35049/24921

This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35049/24921/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35049/24921/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2021-08-27T16:57:41Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35049/24922

This PR adds an extra 20KB to repository

cmsbuild · 2021-08-27T16:58:06Z

A new Pull Request was created by @swagata87 (Swagata Mukherjee) for master.

It involves the following packages:

RecoEgamma/EgammaHLTProducers (hlt)

@Martin-Grunewald, @cmsbuild can you please review it and eventually sign? Thanks.
@Sam-Harper, @HuguesBrun, @jainshilpi, @Fedespring, @lgray, @calderona, @sscruz, @afiqaize, @ram1123, @varuns23, @cericeci, @sobhatta this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

Martin-Grunewald · 2021-08-30T06:30:33Z

please test

cmsbuild · 2021-08-30T09:30:25Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a150a0/18126/summary.html
COMMIT: 1942ef7
CMSSW: CMSSW_12_1_X_2021-08-29-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35049/18126/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 39
DQMHistoTests: Total histograms compared: 3000352
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3000324
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
Checked 165 log files, 37 edm output root files, 39 DQM output files
TriggerResults: no differences found

Martin-Grunewald · 2021-08-30T09:35:24Z

RecoEgamma/EgammaHLTProducers/plugins/EgammaHLTHcalVarProducerFromRecHit.cc

+  desc.add<bool>(("useSingleTower"), false);
+  desc.add<std::vector<double> >("effectiveAreas", {0.079, 0.25});  // 2016 post-ichep sinEle default
+  desc.add<std::vector<double> >("absEtaLowEdges", {0.0, 1.479});   // Barrel, Endcap
+  descriptions.add(("hltEgammaHLTHcalVarProducerFromRecHit"), desc);


Why is there an extra bracket-pair around the first argument?

Ah I just copied from other .cc files in that folder.. but you are right that these extra braces are not needed.
Let me remove them and update the PR. Thanks!

cmsbuild · 2021-08-31T17:47:05Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35049/24981

This PR adds an extra 16KB to repository

cmsbuild · 2021-08-31T17:47:42Z

Pull request #35049 was updated. @Martin-Grunewald, @cmsbuild can you please check and sign again.

perrotta · 2021-09-01T05:36:18Z

please test

cmsbuild · 2021-09-01T08:48:26Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a150a0/18184/summary.html
COMMIT: f798250
CMSSW: CMSSW_12_1_X_2021-08-31-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35049/18184/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 39
DQMHistoTests: Total histograms compared: 3000404
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3000376
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
Checked 165 log files, 37 edm output root files, 39 DQM output files
TriggerResults: no differences found

Martin-Grunewald · 2021-09-01T08:51:49Z

+1

cmsbuild · 2021-09-01T08:52:12Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2021-09-01T09:36:52Z

+1

swagata87 added 4 commits August 26, 2021 09:45

new producer for hcal vars

85e2fac

using hcal topology properly

3939a2f

code cleanup

d590a8e

small changes

b3b60bf

cmsbuild added this to the CMSSW_12_1_X milestone Aug 27, 2021

cmsbuild added code-checks-pending hlt-pending orp-pending pending-signatures tests-pending labels Aug 27, 2021

cmsbuild added code-checks-rejected and removed code-checks-pending labels Aug 27, 2021

code checks

1942ef7

cmsbuild added code-checks-pending and removed code-checks-rejected labels Aug 27, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 27, 2021

cmsbuild added tests-started and removed tests-pending labels Aug 30, 2021

cmsbuild added tests-approved and removed tests-started labels Aug 30, 2021

Martin-Grunewald reviewed Aug 30, 2021

View reviewed changes

remove redundant brackets

74d4378

cmsbuild removed tests-approved code-checks-approved labels Aug 30, 2021

code checks

f798250

cmsbuild added code-checks-pending and removed code-checks-rejected labels Aug 31, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 31, 2021

cmsbuild added tests-started and removed tests-pending labels Sep 1, 2021

cmsbuild added tests-approved and removed tests-started labels Sep 1, 2021

cmsbuild added fully-signed hlt-approved and removed hlt-pending pending-signatures labels Sep 1, 2021

cmsbuild added orp-approved and removed orp-pending labels Sep 1, 2021

cmsbuild merged commit bf1449b into cms-sw:master Sep 1, 2021

swagata87 mentioned this pull request Jan 14, 2023

[EGM HLT@Phase2] Phase out caloTowers #40525

Merged

swagata87 mentioned this pull request Jan 3, 2024

Calotower phase-out from PF code #43612

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[EGM HLT] Phase out calotower & use HCAL recHits directly #35049

[EGM HLT] Phase out calotower & use HCAL recHits directly #35049

swagata87 commented Aug 27, 2021

cmsbuild commented Aug 27, 2021

cmsbuild commented Aug 27, 2021

cmsbuild commented Aug 27, 2021

Martin-Grunewald commented Aug 30, 2021

cmsbuild commented Aug 30, 2021

Martin-Grunewald Aug 30, 2021

swagata87 Aug 30, 2021

cmsbuild commented Aug 31, 2021

cmsbuild commented Aug 31, 2021

perrotta commented Sep 1, 2021

cmsbuild commented Sep 1, 2021

Martin-Grunewald commented Sep 1, 2021

cmsbuild commented Sep 1, 2021

perrotta commented Sep 1, 2021

[EGM HLT] Phase out calotower & use HCAL recHits directly #35049

[EGM HLT] Phase out calotower & use HCAL recHits directly #35049

Conversation

swagata87 commented Aug 27, 2021

PR description:

PR validation:

cmsbuild commented Aug 27, 2021

cmsbuild commented Aug 27, 2021

cmsbuild commented Aug 27, 2021

Martin-Grunewald commented Aug 30, 2021

cmsbuild commented Aug 30, 2021

Comparison Summary

Martin-Grunewald Aug 30, 2021

Choose a reason for hiding this comment

swagata87 Aug 30, 2021

Choose a reason for hiding this comment

cmsbuild commented Aug 31, 2021

cmsbuild commented Aug 31, 2021

perrotta commented Sep 1, 2021

cmsbuild commented Sep 1, 2021

Comparison Summary

Martin-Grunewald commented Sep 1, 2021

cmsbuild commented Sep 1, 2021

perrotta commented Sep 1, 2021