Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding fake alignment to make tracker geometry test work #35119

Merged

Conversation

srimanob
Copy link
Contributor

@srimanob srimanob commented Sep 2, 2021

PR description:

To solve the issue reported in #35118
When #35092 was introduced, it will take alignment from the GT. However, for the unit test, we can pick the fake alignment instead.

PR validation:

Test with testTrackerHierarchy_cfg.py and testTracker_cfg.py, they now run fine.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not a backport. Will backport together with #35092 to 12_0 if needs.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35119/25013

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2021

A new Pull Request was created by @srimanob (Phat Srimanobhas) for master.

It involves the following packages:

  • Geometry/TrackerGeometryBuilder (geometry)

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@JanFSchulte, @VinInn, @bsunanda, @mmusich, @mtosi, @fabiocos, @venturia this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@srimanob
Copy link
Contributor Author

srimanob commented Sep 2, 2021

@cmsbuild please test

@mmusich
Copy link
Contributor

mmusich commented Sep 2, 2021

@srimanob you have the same problem

also in

process.load("Configuration.Geometry.GeometryExtended2021Reco_cff")

Please update that one as well.

@srimanob
Copy link
Contributor Author

srimanob commented Sep 2, 2021

Thanks @mmusich
Done.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35119/25015

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2021

Pull request #35119 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please check and sign again.

@srimanob
Copy link
Contributor Author

srimanob commented Sep 2, 2021

@cmsbuild please test

@qliphy
Copy link
Contributor

qliphy commented Sep 2, 2021

type bugfix

@mmusich
Copy link
Contributor

mmusich commented Sep 2, 2021

@srimanob @qliphy
I guess the relval input errors seen here in tests (log):

136.72413_RunJetHT2016B_reminiaodUL+RunJetHT2016B_reminiaodUL+REMININANO_data2016UL_HIPM_met+HARVESTDR2_REMININANO_data2016UL_HIPM_met Step0-PASSED Step1-FAILED Step2-NOTRUN  - time date Thu Sep  2 08:42:21 2021-date Thu Sep  2 08:41:32 2021; exit: 0 256 0

are spurious and in fact due to the issues discussed at #34714 (comment).
Shall this be retested with #35121 ?

@srimanob
Copy link
Contributor Author

srimanob commented Sep 2, 2021

Please test with #35121

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-38413e/18245/summary.html
COMMIT: 905a86b
CMSSW: CMSSW_12_1_X_2021-09-01-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35119/18245/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 3000404
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3000376
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@srimanob
Copy link
Contributor Author

srimanob commented Sep 2, 2021

urgent

@cmsbuild cmsbuild added the urgent label Sep 2, 2021
@cvuosalo
Copy link
Contributor

cvuosalo commented Sep 2, 2021

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Sep 2, 2021

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants