-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding fake alignment to make tracker geometry test work #35119
Adding fake alignment to make tracker geometry test work #35119
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35119/25013
|
A new Pull Request was created by @srimanob (Phat Srimanobhas) for master. It involves the following packages:
@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
Thanks @mmusich |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35119/25015
|
Pull request #35119 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please check and sign again. |
@cmsbuild please test |
type bugfix |
@srimanob @qliphy 136.72413_RunJetHT2016B_reminiaodUL+RunJetHT2016B_reminiaodUL+REMININANO_data2016UL_HIPM_met+HARVESTDR2_REMININANO_data2016UL_HIPM_met Step0-PASSED Step1-FAILED Step2-NOTRUN - time date Thu Sep 2 08:42:21 2021-date Thu Sep 2 08:41:32 2021; exit: 0 256 0 are spurious and in fact due to the issues discussed at #34714 (comment). |
Please test with #35121 |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-38413e/18245/summary.html Comparison SummarySummary:
|
urgent |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
To solve the issue reported in #35118
When #35092 was introduced, it will take alignment from the GT. However, for the unit test, we can pick the fake alignment instead.
PR validation:
Test with
testTrackerHierarchy_cfg.py
andtestTracker_cfg.py
, they now run fine.if this PR is a backport please specify the original PR and why you need to backport that PR:
Not a backport. Will backport together with #35092 to 12_0 if needs.