-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 2021 Reco Geometry Config files #35092
Conversation
assign trk-dpg |
FYI @civanch |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35092/24975
|
A new Pull Request was created by @srimanob (Phat Srimanobhas) for master. It involves the following packages:
@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @kpedro88, @cmsbuild, @AdrianoDee, @srimanob, @mdhildreth, @tsusa, @mmusich can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
FYI @fabiocos |
+1 for the record the problem was already raised here: #28847 (comment) |
+1 |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bf24b9/18172/summary.html Comparison SummarySummary:
|
+Upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1
|
PR description:
Summarise: https://indico.cern.ch/event/992973/#6-validation-results
As discrepancy shown in DD4hep validation in CMSSW_12_0_0_pre4, we see that there is a configuration that disables the tracker alignment for Run-3, implemented in #28847. The following line is removed from this PR,
trackerGeometry.applyAlignment = cms.bool(False)
PR validation:
The private sample has been done. The result shows in slide 6 and 7 of
https://indico.cern.ch/event/992973/#6-validation-results
The agreement between DDD-DB / DD4hep-XML is seen.
if this PR is a backport please specify the original PR and why you need to backport that PR:
This is not a backport. It is unclear if we should backport for 12_0. To be discussed.