Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 2021 Reco Geometry Config files #35092

Merged
merged 1 commit into from
Sep 1, 2021

Conversation

srimanob
Copy link
Contributor

@srimanob srimanob commented Aug 31, 2021

PR description:

Summarise: https://indico.cern.ch/event/992973/#6-validation-results
As discrepancy shown in DD4hep validation in CMSSW_12_0_0_pre4, we see that there is a configuration that disables the tracker alignment for Run-3, implemented in #28847. The following line is removed from this PR,
trackerGeometry.applyAlignment = cms.bool(False)

PR validation:

The private sample has been done. The result shows in slide 6 and 7 of
https://indico.cern.ch/event/992973/#6-validation-results
The agreement between DDD-DB / DD4hep-XML is seen.

if this PR is a backport please specify the original PR and why you need to backport that PR:

This is not a backport. It is unclear if we should backport for 12_0. To be discussed.

@srimanob
Copy link
Contributor Author

assign trk-dpg

@srimanob
Copy link
Contributor Author

FYI @civanch

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35092/24975

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

New categories assigned: trk-dpg

@mmusich,@tsusa you have been requested to review this Pull request/Issue and eventually sign? Thanks

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @srimanob (Phat Srimanobhas) for master.

It involves the following packages:

  • Configuration/Geometry (geometry, upgrade)

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @kpedro88, @cmsbuild, @AdrianoDee, @srimanob, @mdhildreth, @tsusa, @mmusich can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @slomeo, @vargasa this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@srimanob
Copy link
Contributor Author

@cmsbuild please test

@srimanob
Copy link
Contributor Author

FYI @fabiocos

@mmusich
Copy link
Contributor

mmusich commented Aug 31, 2021

+1

for the record the problem was already raised here: #28847 (comment)

@civanch
Copy link
Contributor

civanch commented Aug 31, 2021

+1

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bf24b9/18172/summary.html
COMMIT: 7834317
CMSSW: CMSSW_12_1_X_2021-08-31-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35092/18172/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1465 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 3000404
  • DQMHistoTests: Total failures: 739
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2999643
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: found differences in 1 / 38 workflows

@srimanob
Copy link
Contributor Author

srimanob commented Sep 1, 2021

For reference, I attached the result from private test.
Blue: DD4hepXML v2
Orange: DD4hepXML v2 with tracker alignment (this PR)

TrackerRechits
TrackingEfficiency

@srimanob
Copy link
Contributor Author

srimanob commented Sep 1, 2021

+Upgrade

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Sep 1, 2021

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants