Migrate some modules in SimPPS to esConsumes

[makortel]

PR description:

Part of #31061.

PR validation:

Code compiles.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34989/24834

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

• SimPPS/PPSSimTrackProducer (simulation)
• SimPPS/RPDigiProducer (simulation)
• SimTransport/PPSProtonTransport (simulation)

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[makortel]

@cmsbuild, please test

[makortel]

This module needs to be migrated to some thread-efficient base class.

Is this module run in runTheMatrix? It is included in a list of modules being run that I extracted in last spring, but I don't see it being flagged as one preventing efficient use of concurrent lumis (that legacy EDModules imply) in #25090.

[makortel]

And now I noticed the migration of RPDigiProducer is incomplete (the report in IBs missed this call). It uses RPDetDigitizer in

cmssw/SimPPS/RPDigiProducer/plugins/RPDigiProducer.cc

Lines 174 to 176 in 9b19580

	if (theAlgoMap.find(it->first) == theAlgoMap.end()) {
	theAlgoMap[it->first] = std::make_unique<RPDetDigitizer>(conf_, *rndEngine_, it->first, iSetup);
	}

that uses RPDisplacementGenerator in

cmssw/SimPPS/RPDigiProducer/plugins/RPDetDigitizer.cc

Line 27 in 9b19580

theRPDisplacementGenerator = std::make_unique<RPDisplacementGenerator>(params, det_id_, iSetup);

that gets data from EventSetup, .e.g

cmssw/SimPPS/RPDigiProducer/plugins/RPDisplacementGenerator.cc

Lines 26 to 29 in 9b19580

	ESHandle<CTPPSRPAlignmentCorrectionsData> alignments;
	if (auto rec = iSetup.tryToGet<VeryForwardMisalignedGeometryRecord>()) {
	iSetup.get<VeryForwardMisalignedGeometryRecord>().get(alignments);
	}

)

This needs to be changed to something that allows declaring the consumed EventSetup products to be declared in the RPDetDigitizer constructor. It is far from clear to me what would be the best way to do that (e.g. is the map from RPDetId to RPDetDigitizer really necessary).

[makortel]

FYI @cms-sw/ctpps-dpg-l2 (since these packages do not appear to have any watchers), see my comments above.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b1da21/17983/summary.html
COMMIT: 9b19580
CMSSW: CMSSW_12_1_X_2021-08-23-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34989/17983/install.sh to create a dev area with all the needed externals and cmssw changes.

CMS StaticAnalyzer warnings: There are 1 inherits from legacy modules warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b1da21/17983/llvm-analysis/legacy-mod-sa.txt for details.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 3000352
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3000324
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[fabferro]

@mundim : can you check? Help in the RP digitizers is needed too. Thanks!

[clemencia]

Hello, @mundim asked me to take care of this so he can focus on the fullsim

[makortel]

@cms-sw/simulation-l2 Could you review and sign this PR even if it not complete for esConsumes in RPDigiProducer? The necessary work could come in later PR(s) (that I suppose would be easier to deal with given that @clemencia would work on that)

[civanch]

@makortel , @fabferro , @clemencia , I would propose that tomorrow morning I will sign this PR and make issue for PPS development. If you disagree, please, let me know.

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1