Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Validation] Move EcalDigis sources in to plugins dir #34904

Merged
merged 3 commits into from
Aug 19, 2021
Merged

[Validation] Move EcalDigis sources in to plugins dir #34904

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f663843
[Validation] Move EcalDigis sources in to plugins dir
smuzaffar Aug 17, 2021
21e8ba0
cleanup self include
smuzaffar Aug 18, 2021
ec693cf
remove self include
smuzaffar Aug 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 Validation/EcalDigis/BuildFile.xml → Validation/EcalDigis/plugins/BuildFile.xml
View file
Open in desktop
File renamed without changes.
1 change: 1 addition & 0 deletions Validation/EcalDigis/plugins/CollHandle.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
#include "CollHandle.h"
0 Validation/EcalDigis/src/CollHandle.h → Validation/EcalDigis/plugins/CollHandle.h
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion ...calDigis/src/EcalBarrelDigisValidation.cc → ...igis/plugins/EcalBarrelDigisValidation.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
*
*/

#include <Validation/EcalDigis/interface/EcalBarrelDigisValidation.h>
#include "EcalBarrelDigisValidation.h"
#include "CalibCalorimetry/EcalTrivialCondModules/interface/EcalTrivialConditionRetriever.h"
#include "DQMServices/Core/interface/DQMStore.h"

Expand Down
1 change: 0 additions & 1 deletion ...gis/interface/EcalBarrelDigisValidation.h → ...Digis/plugins/EcalBarrelDigisValidation.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
#include <map>
#include "DQMServices/Core/interface/DQMEDAnalyzer.h"

#include <Validation/EcalDigis/interface/EcalBarrelDigisValidation.h>
#include "CalibCalorimetry/EcalTrivialCondModules/interface/EcalTrivialConditionRetriever.h"

class EcalBarrelDigisValidation : public DQMEDAnalyzer {
Expand Down
2 changes: 1 addition & 1 deletion ...tion/EcalDigis/src/EcalDigisValidation.cc → .../EcalDigis/plugins/EcalDigisValidation.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
*
*/

#include <Validation/EcalDigis/interface/EcalDigisValidation.h>
#include "EcalDigisValidation.h"
#include <DataFormats/EcalDetId/interface/EBDetId.h>
#include <DataFormats/EcalDetId/interface/EEDetId.h>
#include <DataFormats/EcalDetId/interface/ESDetId.h>
Expand Down
1 change: 0 additions & 1 deletion ...EcalDigis/interface/EcalDigisValidation.h → ...n/EcalDigis/plugins/EcalDigisValidation.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@
#include "DataFormats/EcalDigi/interface/EcalDigiCollections.h"
#include "SimDataFormats/CrossingFrame/interface/CrossingFrame.h"
#include "SimDataFormats/CrossingFrame/interface/MixCollection.h"
#include <Validation/EcalDigis/interface/EcalDigisValidation.h>
#include "CalibCalorimetry/EcalTrivialCondModules/interface/EcalTrivialConditionRetriever.h"

#include <iostream>
Expand Down
2 changes: 1 addition & 1 deletion ...calDigis/src/EcalEndcapDigisValidation.cc → ...igis/plugins/EcalEndcapDigisValidation.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
*
*/

#include <Validation/EcalDigis/interface/EcalEndcapDigisValidation.h>
#include "EcalEndcapDigisValidation.h"
#include "CalibCalorimetry/EcalTrivialCondModules/interface/EcalTrivialConditionRetriever.h"

using namespace cms;
Expand Down
1 change: 0 additions & 1 deletion ...gis/interface/EcalEndcapDigisValidation.h → ...Digis/plugins/EcalEndcapDigisValidation.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
#include "DataFormats/EcalDigi/interface/EEDataFrame.h"
#include "DataFormats/EcalDigi/interface/EcalDigiCollections.h"

#include <Validation/EcalDigis/interface/EcalEndcapDigisValidation.h>
#include "CalibCalorimetry/EcalTrivialCondModules/interface/EcalTrivialConditionRetriever.h"

#include <iostream>
Expand Down
2 changes: 1 addition & 1 deletion ...alDigis/src/EcalMixingModuleValidation.cc → ...gis/plugins/EcalMixingModuleValidation.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
*
*/

#include <Validation/EcalDigis/interface/EcalMixingModuleValidation.h>
#include "EcalMixingModuleValidation.h"
#include <DataFormats/EcalDetId/interface/EBDetId.h>
#include <DataFormats/EcalDetId/interface/EEDetId.h>
#include <DataFormats/EcalDetId/interface/ESDetId.h>
Expand Down
2 changes: 1 addition & 1 deletion ...is/interface/EcalMixingModuleValidation.h → ...igis/plugins/EcalMixingModuleValidation.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
#include "CondFormats/ESObjects/interface/ESPedestals.h"
#include "CondFormats/DataRecord/interface/ESPedestalsRcd.h"
#include "CondFormats/ESObjects/interface/ESIntercalibConstants.h"
#include <Validation/EcalDigis/interface/EcalBarrelDigisValidation.h>
#include "EcalBarrelDigisValidation.h"
#include "CalibCalorimetry/EcalTrivialCondModules/interface/EcalTrivialConditionRetriever.h"
#include "Geometry/Records/interface/CaloGeometryRecord.h"

Expand Down
2 changes: 1 addition & 1 deletion ...Digis/src/EcalPreshowerDigisValidation.cc → ...s/plugins/EcalPreshowerDigisValidation.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
*
*/

#include <Validation/EcalDigis/interface/EcalPreshowerDigisValidation.h>
#include "EcalPreshowerDigisValidation.h"

EcalPreshowerDigisValidation::EcalPreshowerDigisValidation(const edm::ParameterSet& ps)
: ESdigiCollectionToken_(consumes<ESDigiCollection>(ps.getParameter<edm::InputTag>("ESdigiCollection"))) {
Expand Down
0 .../interface/EcalPreshowerDigisValidation.h → ...is/plugins/EcalPreshowerDigisValidation.h
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion ...calDigis/src/EcalPreshowerNoiseDistrib.cc → ...igis/plugins/EcalPreshowerNoiseDistrib.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
*
*/

#include <Validation/EcalDigis/interface/EcalPreshowerNoiseDistrib.h>
#include "EcalPreshowerNoiseDistrib.h"

EcalPreshowerNoiseDistrib::EcalPreshowerNoiseDistrib(const edm::ParameterSet& ps)
: ESdigiCollectionToken_(consumes<ESDigiCollection>(ps.getParameter<edm::InputTag>("ESdigiCollection"))) {
Expand Down
0 ...gis/interface/EcalPreshowerNoiseDistrib.h → ...Digis/plugins/EcalPreshowerNoiseDistrib.h
View file
Open in desktop
File renamed without changes.
0 Validation/EcalDigis/src/EcalSRPCompat.h → Validation/EcalDigis/plugins/EcalSRPCompat.h
View file
Open in desktop
File renamed without changes.
4 changes: 2 additions & 2 deletions ...gis/src/EcalSelectiveReadoutValidation.cc → ...plugins/EcalSelectiveReadoutValidation.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@
*
*/

#include "Validation/EcalDigis/interface/EcalSelectiveReadoutValidation.h"
#include "EcalSelectiveReadoutValidation.h"

#include "Validation/EcalDigis/src/ecalDccMap.h"
#include "ecalDccMap.h"

#include "FWCore/MessageLogger/interface/MessageLogger.h"
#include "FWCore/Framework/interface/ESHandle.h"
Expand Down
2 changes: 1 addition & 1 deletion ...nterface/EcalSelectiveReadoutValidation.h → .../plugins/EcalSelectiveReadoutValidation.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
#include "CondFormats/DataRecord/interface/EcalTPGLutGroupRcd.h"
#include "CondFormats/DataRecord/interface/EcalTPGPhysicsConstRcd.h"

#include "Validation/EcalDigis/src/CollHandle.h"
#include "CollHandle.h"

#include <string>
#include <set>
Expand Down
24 changes: 24 additions & 0 deletions Validation/EcalDigis/plugins/SealModule.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
#include "FWCore/PluginManager/interface/ModuleDef.h"

#include "FWCore/Framework/interface/MakerMacros.h"

#include "EcalDigisValidation.h"
DEFINE_FWK_MODULE(EcalDigisValidation);

#include "EcalBarrelDigisValidation.h"
DEFINE_FWK_MODULE(EcalBarrelDigisValidation);

#include "EcalEndcapDigisValidation.h"
DEFINE_FWK_MODULE(EcalEndcapDigisValidation);

#include "EcalPreshowerDigisValidation.h"
DEFINE_FWK_MODULE(EcalPreshowerDigisValidation);

#include "EcalPreshowerNoiseDistrib.h"
DEFINE_FWK_MODULE(EcalPreshowerNoiseDistrib);

#include "EcalMixingModuleValidation.h"
DEFINE_FWK_MODULE(EcalMixingModuleValidation);

#include "EcalSelectiveReadoutValidation.h"
DEFINE_FWK_MODULE(EcalSelectiveReadoutValidation);
0 Validation/EcalDigis/src/ecalDccMap.h → Validation/EcalDigis/plugins/ecalDccMap.h
View file
Open in desktop
File renamed without changes.
1 change: 0 additions & 1 deletion Validation/EcalDigis/src/CollHandle.cpp
View file
Open in desktop

This file was deleted.

24 changes: 0 additions & 24 deletions Validation/EcalDigis/src/SealModule.cc
View file
Open in desktop

This file was deleted.