[Validation] Move EcalDigis sources in to plugins dir #34904

smuzaffar · 2021-08-17T12:08:45Z

Validation/EcalDigis generates a plugin so this PR proposes to move all src/headers files in to plugins directory.

cmsbuild · 2021-08-17T12:16:31Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34904/24711

This PR adds an extra 56KB to repository

cmsbuild · 2021-08-17T12:16:49Z

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

Validation/EcalDigis (dqm)

@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks.
@rchatter, @simonepigazzini, @thomreis, @argiro this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

smuzaffar · 2021-08-17T12:21:43Z

please test

cmsbuild · 2021-08-17T15:40:47Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-334747/17818/summary.html
COMMIT: f663843
CMSSW: CMSSW_12_1_X_2021-08-17-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34904/17818/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 7 differences found in the comparisons
DQMHistoTests: Total files compared: 39
DQMHistoTests: Total histograms compared: 3000352
DQMHistoTests: Total failures: 5
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 3000324
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.004 KiB( 38 files compared)
DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
Checked 165 log files, 37 edm output root files, 39 DQM output files
TriggerResults: no differences found

jfernan2 · 2021-08-17T19:02:20Z

+1

cmsbuild · 2021-08-17T19:02:41Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2021-08-17T21:06:45Z

Validation/EcalDigis/plugins/EcalDigisValidation.h

@@ -37,7 +37,7 @@
 #include "DataFormats/EcalDigi/interface/EcalDigiCollections.h"
 #include "SimDataFormats/CrossingFrame/interface/CrossingFrame.h"
 #include "SimDataFormats/CrossingFrame/interface/MixCollection.h"
-#include <Validation/EcalDigis/interface/EcalDigisValidation.h>
+#include "EcalDigisValidation.h"


Is this including itself?

yes it was, I have removed it now.

perrotta · 2021-08-17T21:07:26Z

Validation/EcalDigis/plugins/EcalEndcapDigisValidation.h

@@ -25,7 +25,7 @@
 #include "DataFormats/EcalDigi/interface/EEDataFrame.h"
 #include "DataFormats/EcalDigi/interface/EcalDigiCollections.h"

-#include <Validation/EcalDigis/interface/EcalEndcapDigisValidation.h>
+#include "EcalEndcapDigisValidation.h"


Is this including itself?

yes it was, I have removed it now.

perrotta · 2021-08-17T21:07:42Z

Validation/EcalDigis/plugins/EcalBarrelDigisValidation.h

@@ -31,7 +31,7 @@
 #include <map>
 #include "DQMServices/Core/interface/DQMEDAnalyzer.h"

-#include <Validation/EcalDigis/interface/EcalBarrelDigisValidation.h>
+#include "EcalBarrelDigisValidation.h"


Is this including itself?

yes looks like it is including itself ( https://github.com/cms-sw/cmssw/blob/master/Validation/EcalDigis/interface/EcalBarrelDigisValidation.h#L34 ). I can clean this up

perrotta · 2021-08-18T15:31:15Z

@smuzaffar , just in case you did not notice my comments above

cmsbuild · 2021-08-18T16:43:38Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34904/24752

This PR adds an extra 12KB to repository

cmsbuild · 2021-08-18T16:43:56Z

Pull request #34904 was updated. @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please check and sign again.

perrotta · 2021-08-18T16:50:31Z

Thank you @smuzaffar
However, there are still two more self-inclusions to clean up (see above)

cmsbuild · 2021-08-18T17:21:42Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34904/24754

This PR adds an extra 56KB to repository

cmsbuild · 2021-08-18T17:22:02Z

Pull request #34904 was updated. @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please check and sign again.

smuzaffar · 2021-08-18T17:40:38Z

please test

cmsbuild · 2021-08-18T20:49:48Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-334747/17867/summary.html
COMMIT: ec693cf
CMSSW: CMSSW_12_1_X_2021-08-18-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34904/17867/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 39
DQMHistoTests: Total histograms compared: 3000352
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3000330
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
Checked 165 log files, 37 edm output root files, 39 DQM output files
TriggerResults: no differences found

perrotta · 2021-08-19T05:59:27Z

+1

@jfernan2 changes since last dqm signature are only the removal of a few duplicate include: I assume that signature can be confirmed

perrotta · 2021-08-19T06:00:14Z

merge

jfernan2 · 2021-08-19T11:15:32Z

+1
For the records

cmsbuild · 2021-08-19T11:15:57Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

[Validation] Move EcalDigis sources in to plugins dir

f663843

cmsbuild added this to the CMSSW_12_1_X milestone Aug 17, 2021

cmsbuild added code-checks-pending dqm-pending orp-pending pending-signatures tests-pending labels Aug 17, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 17, 2021

cmsbuild added tests-started and removed tests-pending labels Aug 17, 2021

cmsbuild added tests-approved and removed tests-started labels Aug 17, 2021

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Aug 17, 2021

perrotta reviewed Aug 17, 2021

View reviewed changes

cleanup self include

21e8ba0

cmsbuild removed dqm-approved fully-signed tests-approved code-checks-approved labels Aug 18, 2021

cmsbuild added the tests-pending label Aug 18, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 18, 2021

remove self include

ec693cf

cmsbuild added code-checks-pending and removed code-checks-approved labels Aug 18, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 18, 2021

cmsbuild added tests-started and removed tests-pending labels Aug 18, 2021

cmsbuild added tests-approved and removed tests-started labels Aug 18, 2021

cmsbuild added orp-approved and removed orp-pending labels Aug 19, 2021

cmsbuild merged commit 0c1fafc into cms-sw:master Aug 19, 2021

cmsbuild removed the dqm-pending label Aug 19, 2021

cmsbuild added dqm-approved fully-signed and removed pending-signatures labels Aug 19, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Validation] Move EcalDigis sources in to plugins dir #34904

[Validation] Move EcalDigis sources in to plugins dir #34904

smuzaffar commented Aug 17, 2021

cmsbuild commented Aug 17, 2021

cmsbuild commented Aug 17, 2021

smuzaffar commented Aug 17, 2021

cmsbuild commented Aug 17, 2021

jfernan2 commented Aug 17, 2021

cmsbuild commented Aug 17, 2021

perrotta Aug 17, 2021

smuzaffar Aug 18, 2021

perrotta Aug 17, 2021

smuzaffar Aug 18, 2021

perrotta Aug 17, 2021

smuzaffar Aug 18, 2021

perrotta commented Aug 18, 2021

cmsbuild commented Aug 18, 2021

cmsbuild commented Aug 18, 2021

perrotta commented Aug 18, 2021

cmsbuild commented Aug 18, 2021

cmsbuild commented Aug 18, 2021

smuzaffar commented Aug 18, 2021

cmsbuild commented Aug 18, 2021

perrotta commented Aug 19, 2021

perrotta commented Aug 19, 2021

jfernan2 commented Aug 19, 2021

cmsbuild commented Aug 19, 2021

[Validation] Move EcalDigis sources in to plugins dir #34904

[Validation] Move EcalDigis sources in to plugins dir #34904

Conversation

smuzaffar commented Aug 17, 2021

cmsbuild commented Aug 17, 2021

cmsbuild commented Aug 17, 2021

smuzaffar commented Aug 17, 2021

cmsbuild commented Aug 17, 2021

Comparison Summary

jfernan2 commented Aug 17, 2021

cmsbuild commented Aug 17, 2021

perrotta Aug 17, 2021

Choose a reason for hiding this comment

smuzaffar Aug 18, 2021

Choose a reason for hiding this comment

perrotta Aug 17, 2021

Choose a reason for hiding this comment

smuzaffar Aug 18, 2021

Choose a reason for hiding this comment

perrotta Aug 17, 2021

Choose a reason for hiding this comment

smuzaffar Aug 18, 2021

Choose a reason for hiding this comment

perrotta commented Aug 18, 2021

cmsbuild commented Aug 18, 2021

cmsbuild commented Aug 18, 2021

perrotta commented Aug 18, 2021

cmsbuild commented Aug 18, 2021

cmsbuild commented Aug 18, 2021

smuzaffar commented Aug 18, 2021

cmsbuild commented Aug 18, 2021

Comparison Summary

perrotta commented Aug 19, 2021

perrotta commented Aug 19, 2021

jfernan2 commented Aug 19, 2021

cmsbuild commented Aug 19, 2021