-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initialize Trackster::iterationIndex_ #34858
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34858/24656
|
A new Pull Request was created by @slava77 (Slava Krutelyov) for master. It involves the following packages:
@perrotta, @kpedro88, @cmsbuild, @AdrianoDee, @srimanob, @slava77, @jpata can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24f1a4/17747/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison SummarySummary:
|
+reconstruction
|
+1
|
merge |
+Upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
in an unrelated PR tests I noticed that the iterationIndex is changing randomly
e.g. #34852 (comment)
The proposal is to initialize to 0, but since it's a valid iteration value, I'm not so sure.
@cms-sw/hgcal-dpg-l2 please confirm if this is OK.
Thank you.