-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make new HF Shower Library the default for Run3 #34626
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34626/24212
|
A new Pull Request was created by @abdoulline (Salavat Abdullin) for master. It involves the following packages:
@civanch, @silviodonato, @mdhildreth, @cmsbuild, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
@abdoulline , I have started tests having in mind that something more will be required probably for this PR. |
@civanch thank you. |
Looking at the console |
looks like there is issue with network or EOS, many relval-INPUT tests are failing for other PRs too |
issue is related to #34633 . For Relval-INPUT tests we timeout the job after 15mins and looks like these failed wf are taking more than 15 mins to start and then killed by timeout |
-1 Failed Tests: RelVals-INPUT RelVals-INPUT
Expand to see more relval errors ...
Comparison SummarySummary:
|
+1 test problem is not connected with this PR. |
yes errors are not due to this PR. No need to start the full tests, I have restart only the relval-INPUT with higher timeout. Hopefully this will allow to let the test finish properly |
urgent |
Please, note, that this PR change simulation histories. |
@qliphy, this PR is good for pre5 from our point of view. |
+operations |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2) |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8f933d/17279/summary.html Comparison SummaryThe workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons Summary:
|
Except for wf 140.53 (different files in step1_dasquery.log) changes are observed in 2021/2023/2026 wfs as expected. And (given limited statistics) they all look reasonable. |
+1 |
PR description:
Presentation at Simulation meeting on July 16 (updated on July 26)
https://indico.cern.ch/event/1060045/contributions/4455234/attachments/2282906/3888021/Status_newHF_SL_S.A.July16_2021.pdf
Uses earlier implemented (in preparatory PR #34432) modifier "run3_HFSL".
The library file itself has been added to cmsdist several days ago cms-sw/cmsdist#7162
In addtion, standalone HF Shower Library assembly code/config is updated in this PR.
PR validation:
Some results available in the aforementioned presentation.
Technical test:
runTheMatrix.py -l limited
OK