-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding Herwig7 workflows to release validation #34463
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34463/23913
|
A new Pull Request was created by @theofil (Konstantinos Theofilatos) for master. It involves the following packages:
@jordan-martins, @chayanit, @bbilin, @wajidalikhan, @kpedro88, @cmsbuild, @srimanob, @kskovpen can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
test parameters:
|
Please test |
sorry for the double commit, I had to update the PR, to move the Herwig workflows in the appropriate place under the LHE Generation + Hadronization block, |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34463/23914
|
Pull request #34463 was updated. @jordan-martins, @chayanit, @bbilin, @wajidalikhan, @kpedro88, @cmsbuild, @srimanob, @kskovpen can you please check and sign again. |
Please test |
-1 Failed Tests: RelVals RelVals
|
@qliphy thanks for the resolution, I updated the files accordingly. I also updated the NLO version with FxFx, of the Herwig hadronizer to be informed of the concurrent mode and the need for merging the output in the end of the processing |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34463/23976
|
Pull request #34463 was updated. @SiewYan, @mkirsano, @jordan-martins, @chayanit, @bbilin, @wajidalikhan, @kpedro88, @cmsbuild, @GurpreetSinghChahal, @srimanob, @agrohsje, @kskovpen, @alberto-sanchez can you please check and sign again. |
Please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-46213e/16845/summary.html Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
+Upgrade Adding new Herwig7 workflows. Short matrix with new additional workflows run fine. |
+1 |
+1 |
(GEN(Alexander) has informed us that he is on vacation for 2 weeks) |
merge |
…hon` to enable concurrent GEN Big backport from cms-sw#34710 following the same four-step rule. It also includes the backport of cms-sw#29305, cms-sw#33516, cms-sw#34463 with the same goal (these are never backported to 10_6_X)
…hon` to enable concurrent GEN Big backport from cms-sw#34710 following the same four-step rule. It also includes the backport of cms-sw#29305, cms-sw#33516, cms-sw#34463 with the same goal (these are never backported to 10_6_X)
PR description:
Adding Herwig 7 workflows in release validation. Provided this PR is approved, it needs to be back ported also to 106X