Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding Herwig7 workflows to release validation #34463

Merged
merged 4 commits into from
Jul 16, 2021
Merged

Conversation

theofil
Copy link
Contributor

@theofil theofil commented Jul 13, 2021

PR description:

Adding Herwig 7 workflows in release validation. Provided this PR is approved, it needs to be back ported also to 106X

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34463/23913

  • This PR adds an extra 48KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @theofil (Konstantinos Theofilatos) for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)

@jordan-martins, @chayanit, @bbilin, @wajidalikhan, @kpedro88, @cmsbuild, @srimanob, @kskovpen can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

@srimanob
Copy link
Contributor

test parameters:

  • workflows = 537, 538

@srimanob
Copy link
Contributor

Please test

@theofil
Copy link
Contributor Author

theofil commented Jul 13, 2021

sorry for the double commit, I had to update the PR, to move the Herwig workflows in the appropriate place under the LHE Generation + Hadronization block,

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34463/23914

  • This PR adds an extra 48KB to repository

@cmsbuild
Copy link
Contributor

Pull request #34463 was updated. @jordan-martins, @chayanit, @bbilin, @wajidalikhan, @kpedro88, @cmsbuild, @srimanob, @kskovpen can you please check and sign again.

@srimanob
Copy link
Contributor

Please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-46213e/16766/summary.html
COMMIT: e36bcc2
CMSSW: CMSSW_12_0_X_2021-07-12-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34463/16766/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

  • 538.0538.0_DYToLL01234Jets_5FS_TuneCH3_13TeV_madgraphMLM_herwig7+DYToLL01234Jets_5FS_TuneCH3_13TeV_madgraphMLM_herwig7+HARVESTGEN/step1_DYToLL01234Jets_5FS_TuneCH3_13TeV_madgraphMLM_herwig7+DYToLL01234Jets_5FS_TuneCH3_13TeV_madgraphMLM_herwig7+HARVESTGEN.log

@theofil
Copy link
Contributor Author

theofil commented Jul 15, 2021

@qliphy thanks for the resolution, I updated the files accordingly. I also updated the NLO version with FxFx, of the Herwig hadronizer to be informed of the concurrent mode and the need for merging the output in the end of the processing

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34463/23976

  • This PR adds an extra 68KB to repository

@cmsbuild
Copy link
Contributor

Pull request #34463 was updated. @SiewYan, @mkirsano, @jordan-martins, @chayanit, @bbilin, @wajidalikhan, @kpedro88, @cmsbuild, @GurpreetSinghChahal, @srimanob, @agrohsje, @kskovpen, @alberto-sanchez can you please check and sign again.

@srimanob
Copy link
Contributor

Please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-46213e/16845/summary.html
COMMIT: fc74ffd
CMSSW: CMSSW_12_0_X_2021-07-14-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34463/16845/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-46213e/537.0_DYToLL012Jets_5FS_TuneCH3_13TeV_amcatnloFxFx_herwig7+DYToLL012Jets_5FS_TuneCH3_13TeV_amcatnloFxFx_herwig7+HARVESTGEN
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-46213e/538.0_DYToLL01234Jets_5FS_TuneCH3_13TeV_madgraphMLM_herwig7+DYToLL01234Jets_5FS_TuneCH3_13TeV_madgraphMLM_herwig7+HARVESTGEN

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2786302
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2786279
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@srimanob
Copy link
Contributor

+Upgrade

Adding new Herwig7 workflows. Short matrix with new additional workflows run fine.

@chayanit
Copy link

+1

@qliphy
Copy link
Contributor

qliphy commented Jul 16, 2021

+1

@qliphy
Copy link
Contributor

qliphy commented Jul 16, 2021

(GEN(Alexander) has informed us that he is on vacation for 2 weeks)

@qliphy
Copy link
Contributor

qliphy commented Jul 16, 2021

merge

@cmsbuild cmsbuild merged commit 542304b into cms-sw:master Jul 16, 2021
colizz added a commit to colizz/cmssw that referenced this pull request Aug 5, 2021
…hon` to enable concurrent GEN

 Big backport from cms-sw#34710 following the same four-step rule. It also includes the backport of cms-sw#29305, cms-sw#33516, cms-sw#34463 with the same goal (these are never backported to 10_6_X)
colizz added a commit to colizz/cmssw that referenced this pull request Aug 5, 2021
…hon` to enable concurrent GEN

 Big backport from cms-sw#34710 following the same four-step rule. It also includes the backport of cms-sw#29305, cms-sw#33516, cms-sw#34463 with the same goal (these are never backported to 10_6_X)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants