-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement concurrent ExternalLHEProducer technique #33516
Conversation
please test workflow 512,547,548,555,513,551,556,514,552,554,515,516,517,518,519,520 |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33516/22266
|
A new Pull Request was created by @SiewYan (Siewyan Hoh 何守仁) for master. It involves the following packages: Configuration/Generator @SiewYan, @alberto-sanchez, @agrohsje, @mkirsano, @GurpreetSinghChahal can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
-1 Failed Tests: Build Python3 BuildI found compilation warning when building: See details on the summary page. #Python3 I found errors: *** Error compiling 'src/Configuration/Generator/python/WTolNu012Jets_5f_LO_MLM_Madgraph_LHE_13TeV_cff.py'... |
please test workflow 512,547,548,555,513,551,556,514,552,554,515,516,517,518,519,520 |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33516/22268
|
Pull request #33516 was updated. @SiewYan, @alberto-sanchez, @agrohsje, @mkirsano, @GurpreetSinghChahal can you please check and sign again. |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-106d73/14552/summary.html Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
adding @colizz @Dr15Jones who may want to have a look. |
@qliphy , does |
The test runs for those workflows have been done without problem, but no comparisons done due to missing map (as those are for only limited worklows https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_12_0_X_2021-04-23-1100+106d73/42385/) |
Thanks for clarification! |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
This PR creates an error with Herwig7 (see #33544) |
…hon` to enable concurrent GEN Big backport from cms-sw#34710 following the same four-step rule. It also includes the backport of cms-sw#29305, cms-sw#33516, cms-sw#34463 with the same goal (these are never backported to 10_6_X)
…hon` to enable concurrent GEN Big backport from cms-sw#34710 following the same four-step rule. It also includes the backport of cms-sw#29305, cms-sw#33516, cms-sw#34463 with the same goal (these are never backported to 10_6_X)
PR description:
The concurrent version of ExternalLHEProducer is implemented for GEN workflows, LHE production + Hadronization mode.
PR validation:
Ran on several workflow from relval_generator, relval_extendedgen with
--nThreads 4
, and it is a success.