Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DD4hep] Add DD4hep Run 3 workflow that reads geometry from DB #34343

Merged
merged 4 commits into from
Jul 8, 2021

Conversation

cvuosalo
Copy link
Contributor

@cvuosalo cvuosalo commented Jul 6, 2021

Up to now, DD4hep workflows have read geometry from XML files. There is now a DD4hep ideal geometry description in the Conditions DB, so a DD4hep workflow that reads geometry from the DB can be created.

Addition to the PR/IB tests for this workflow is commented out for now until the Cond DB issue with creating payloads is resolved.

This PR depends on PR #34344 to run.

PR validation:

runTheMatrix.py correctly creates the configuration for running this workflow. The workflow can run after the Cond DB issue with creating DB payloads is resolved.

No backport will be done.

@cvuosalo
Copy link
Contributor Author

cvuosalo commented Jul 6, 2021

When I try to run the new 11634.912 workflow, the following error occurs. I don't know what it means.

n exception of category 'ConditionDatabase' occurred while
   [0] Processing global begin Run 
Exception Message:
Payload of type FileBlob with id 2fdfa84a08623caa48cec3d71726922f938d2cd5 could not be loaded. An exception of category 'ConditionDatabase' occurred.
Exception Message:
De-serialization failed: invalid signature Payload serialization info:  {
"CMSSW_version": "CMSSW_12_0_X_2021-07-03-1100",
"architecture": "slc7_amd64_gcc900",
"technology": "boost/serialization",
"tech_version": "1_75"
 }
 from default_deserialize 
 from Session::fetchPayload 

@cvuosalo
Copy link
Contributor Author

cvuosalo commented Jul 6, 2021

@civanch FYI: Here's the DD4hep DB workflow PR.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34343/23715

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2021

A new Pull Request was created by @cvuosalo (Carl Vuosalo) for master.

It involves the following packages:

Configuration/PyReleaseValidation

@jordan-martins, @chayanit, @wajidalikhan, @kpedro88, @cmsbuild, @srimanob can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@srimanob
Copy link
Contributor

srimanob commented Jul 6, 2021

When I try to run the new 11634.912 workflow, the following error occurs. I don't know what it means.

n exception of category 'ConditionDatabase' occurred while
   [0] Processing global begin Run 
Exception Message:
Payload of type FileBlob with id 2fdfa84a08623caa48cec3d71726922f938d2cd5 could not be loaded. An exception of category 'ConditionDatabase' occurred.
Exception Message:
De-serialization failed: invalid signature Payload serialization info:  {
"CMSSW_version": "CMSSW_12_0_X_2021-07-03-1100",
"architecture": "slc7_amd64_gcc900",
"technology": "boost/serialization",
"tech_version": "1_75"
 }
 from default_deserialize 
 from Session::fetchPayload 

@cms-sw/alca-l2 Could you please advise? Thanks.

@cvuosalo
Copy link
Contributor Author

cvuosalo commented Jul 6, 2021

It would be good to get this PR into 12_0_0_pre4.

@srimanob
Copy link
Contributor

srimanob commented Jul 6, 2021

Please test

@srimanob
Copy link
Contributor

srimanob commented Jul 6, 2021

Hi @civanch
The workflow defined here is to make short matrix runs. All run-3 workflows with DB DD4hep can be done with upgrades option of runTheMatrix, or with relvals machine of PdmV. No need to define them here.

@srimanob
Copy link
Contributor

srimanob commented Jul 6, 2021

Urgent

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2021

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1112a1/16497/summary.html
COMMIT: 545522e
CMSSW: CMSSW_12_0_X_2021-07-06-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34343/16497/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

----- Begin Fatal Exception 06-Jul-2021 22:07:16 CEST-----------------------
An exception of category 'ConditionDatabase' occurred while
   [0] Processing global begin Run 
Exception Message:
Payload of type FileBlob with id 2fdfa84a08623caa48cec3d71726922f938d2cd5 could not be loaded. An exception of category 'ConditionDatabase' occurred.
Exception Message:
De-serialization failed: invalid signature Payload serialization info:  {
"CMSSW_version": "CMSSW_12_0_X_2021-07-03-1100",
"architecture": "slc7_amd64_gcc900",
"technology": "boost/serialization",
"tech_version": "1_75"
 }
 from default_deserialize 
 from Session::fetchPayload 
----- End Fatal Exception -------------------------------------------------

@srimanob
Copy link
Contributor

srimanob commented Jul 7, 2021

@cvuosalo @civanch @cms-sw/alca-l2
Could you please clarify if the issue is on GT or something else? I assume when @cvuosalo develops this PR, the test is done with the candidate GT, or this is the last thing to solve before we can run until the end?

Since this is the workflow level, if we are not ready (e.g. can't pass the PR test), we do not need to be merge. This is not a showstopper to validate DD4hep DB because PdmV can pick the cmsDriver to submit the relvals anyways.

What do you think? @cms-sw/pdmv-l2 @silviodonato @qliphy @perrotta

@srimanob
Copy link
Contributor

srimanob commented Jul 8, 2021

test parameters:

  • workflow = 11634.911

@srimanob
Copy link
Contributor

srimanob commented Jul 8, 2021

Please test

@srimanob
Copy link
Contributor

srimanob commented Jul 8, 2021

test parameters:

Ah, OK. Thanks @perrotta

@srimanob
Copy link
Contributor

srimanob commented Jul 8, 2021

Please abort

@srimanob
Copy link
Contributor

srimanob commented Jul 8, 2021

test parameters:

@srimanob
Copy link
Contributor

srimanob commented Jul 8, 2021

Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1112a1/16611/summary.html
COMMIT: 05beb78
CMSSW: CMSSW_12_0_X_2021-07-07-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34343/16611/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 5159 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2786260
  • DQMHistoTests: Total failures: 12
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2786225
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 37 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@srimanob
Copy link
Contributor

srimanob commented Jul 8, 2021

+Upgrade

This PR is to add the workflow for DD4hep with DB geometry, however, the workflow is disable for now.

@chayanit
Copy link

chayanit commented Jul 8, 2021

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

Reco comparison results: 5159 differences found in the comparisons

this is not related to this PR, see #34409.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants