Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clang warning in OnlineDB/SiStripO2O #34060

Merged
merged 2 commits into from
Jun 29, 2021
Merged

Fix clang warning in OnlineDB/SiStripO2O #34060

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8f6ae7
Fix clang warning in OnlineDB/SiStripO2O
mrodozov Jun 9, 2021
28235d9
make condObjBuilder local variable where used
mrodozov Jun 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
make condObjBuilder local variable where used
  • Loading branch information
@mrodozov
mrodozov authored Jun 25, 2021
commit 28235d9059e0b6cbd2304dbb00e65f37ad33a2ba
3 changes: 2 additions & 1 deletion OnlineDB/SiStripO2O/plugins/SiStripPayloadHandler.cc
View file
Original file line number Diff line number Diff line change
@@ -51,7 +51,6 @@ class SiStripPayloadHandler : public edm::EDAnalyzer {

std::string p_type;
std::string p_cfgstr;
edm::Service<SiStripCondObjBuilderFromDb> condObjBuilder;
};

template <typename SiStripPayload>
@@ -64,6 +63,7 @@ SiStripPayloadHandler<SiStripPayload>::SiStripPayloadHandler(const edm::Paramete
m_targetTag(iConfig.getParameter<std::string>("targetTag")),
m_since(iConfig.getParameter<uint32_t>("since")),
p_type(cond::demangledName(typeid(SiStripPayload))) {
edm::Service<SiStripCondObjBuilderFromDb> condObjBuilder;
p_cfgstr = condObjBuilder->getConfigString(typeid(SiStripPayload));
if (iConfig.exists("configMapDatabase"))
m_configMapDb = iConfig.getParameter<std::string>("configMapDatabase");
@@ -108,6 +108,7 @@ void SiStripPayloadHandler<SiStripPayload>::analyze(const edm::Event& evt, const
edm::LogInfo("SiStripPayloadHandler") << "[SiStripPayloadHandler::" << __func__ << "] "
<< "NO mapping payload hash found. Will run the long O2O. ";
SiStripPayload* obj = nullptr;
edm::Service<SiStripCondObjBuilderFromDb> condObjBuilder;
if (typeid(SiStripPayload) == typeid(SiStripApvGain)) {
// special treatment for ApvGain : provide last payload in DB
condObjBuilder->setLastIovGain(condDbSession.fetchPayload<SiStripApvGain>(last_hash));