Fix clang warning in OnlineDB/SiStripO2O

[mrodozov]

PR description:

After moving to LLVM 12 new warning surfaced:
OnlineDB/SiStripO2O/plugins/SiStripPayloadHandler.cc:67:16: warning: field 'condObjBuilder' is uninitialized when used here [-Wuninitialized]
in CLANG IBs.
I'm not sure if moving the object initialization in the constructor body is fine but either way I'm bringing this to attention

PR validation:

builds without warning for CLANG IB

[mrodozov]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34060/23207

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @mrodozov (Mircho Rodozov) for master.

It involves the following packages:

OnlineDB/SiStripO2O

@ggovi can you please review it and eventually sign? Thanks.
@erikbutz, @mmusich this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1ae7c8/15820/summary.html
COMMIT: a8f6ae7
CMSSW: CMSSW_12_0_X_2021-06-08-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34060/15820/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2862520
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2862497
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[qliphy]

kindly ping @cms-sw/db-l2

[smuzaffar]

please test for CMSSW_12_0_CLANG_X

[smuzaffar]

looks like this does fix the wraning for CLANG IB ( https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1ae7c8/15940/build-logs/OnlineDB/SiStripO2O/log.html ). @ggovi , if no do you have any objections? If not then can youplease sign it?

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1ae7c8/15940/summary.html
COMMIT: a8f6ae7
CMSSW: CMSSW_12_0_CLANG_X_2021-06-13-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34060/15940/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 103060 lines to the logs
• Reco comparison results: 19279 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2862520
• DQMHistoTests: Total failures: 125568
• DQMHistoTests: Total nulls: 6
• DQMHistoTests: Total successes: 2736924
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.016 KiB( 37 files compared)
• DQMHistoSizes: changed ( 136.793 ): 0.004 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 136.874 ): 0.012 KiB JetMET/SUSYDQM
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: found differences in 1 / 37 workflows

[Dr15Jones]

So the framework discourages holding a edm::Service<> as a member data. It would be better to just make the edm::Service<> a local variable of the function where it is being used.

[mrodozov]

forgot about that :/ sry

[mrodozov]

please test for CMSSW_12_0_CLANG_X

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34060/23521

• This PR adds an extra 16KB to repository

[cmsbuild]

Pull request #34060 was updated. @ggovi can you please check and sign again.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1ae7c8/16236/summary.html
COMMIT: 28235d9
CMSSW: CMSSW_12_0_CLANG_X_2021-06-24-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34060/16236/install.sh to create a dev area with all the needed externals and cmssw changes.

CMS StaticAnalyzer warnings: There are 1 inherits from legacy modules warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1ae7c8/16236/llvm-analysis/legacy-mod-sa.txt for details.

Comparison Summary

Summary:

• You potentially added 102877 lines to the logs
• Reco comparison results: 19255 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2785631
• DQMHistoTests: Total failures: 58226
• DQMHistoTests: Total nulls: 7
• DQMHistoTests: Total successes: 2727376
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.012 KiB( 37 files compared)
• DQMHistoSizes: changed ( 136.793 ): 0.004 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 136.874 ): 0.012 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: found differences in 1 / 37 workflows

[ggovi]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1