Updates to tauID python tool (10_6_X)

[mbluj]

PR description:

This PR updates a tool to run and then embed tauIDs to pat::Tau (RecoTauTag/RecoTau/python/tools/runTauIdMVA.py). The update enables possibility to run the tool for more than one pat::Tau collection in one job through specifying name of input collection and postix added to created modules and sequences. The new functionality does not affect any official workflows.

PR validation:

Unit and (limited) matrix tests successful.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport of #33150 to be used on top on UL miniAOD.

[cmsbuild]

A new Pull Request was created by @mbluj for CMSSW_10_6_X.

It involves the following packages:

RecoTauTag/RecoTau

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@mbluj, @swozniewski this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

• Backported from Updates to tauID python tool #33150

[cmsbuild]

Pull request #33153 was updated. @perrotta, @jpata, @cmsbuild, @slava77 can you please check and sign again.

[cmsbuild]

Pull request #33153 was updated. @perrotta, @jpata, @cmsbuild, @slava77 can you please check and sign again.

[cmsbuild]

Pull request #33153 was updated. @perrotta, @jpata, @cmsbuild, @slava77 can you please check and sign again.

[cmsbuild]

Pull request #33153 was updated. @perrotta, @jpata, @cmsbuild, @slava77 can you please check and sign again.

[slava77]

backport of #33150

[slava77]

Backport of #33150 to be used on top on UL miniAOD.

the number of line differences is substantially different from #33150.
What else is backported?

[slava77]

@cmsbuild please test

[slava77]

Backport of #33150 to be used on top on UL miniAOD.

the number of line differences is substantially different from #33150.
What else is backported?

it looks like a large fraction is driven by the difference introduced in 11_1_X #28417 "New Tau ID data format".

Is there anything else?

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8efb8a/13703/summary.html
COMMIT: ea87067
CMSSW: CMSSW_10_6_X_2021-03-23-1100/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33153/13703/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 3215541
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3215205
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 143 log files, 29 edm output root files, 35 DQM output files
• TriggerResults: no differences found

[slava77]

@mbluj
please clarify on the status of this PR in response to the code review #33153 (review)
Thank you.

[mbluj]

Sorry for not answering comments in this PR - due to some reason I am not receiving notification from git for some time. I will go through the comments soon.

[cmsbuild]

Pull request #33153 was updated. @perrotta, @jpata, @cmsbuild, @slava77 can you please check and sign again.

[cmsbuild]

Pull request #33153 was updated. @perrotta, @jpata, @cmsbuild, @slava77 can you please check and sign again.

[slava77]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8efb8a/13854/summary.html
COMMIT: 3b74bf7
CMSSW: CMSSW_10_6_X_2021-03-30-1100/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33153/13854/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 3215541
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3215205
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 143 log files, 29 edm output root files, 35 DQM output files
• TriggerResults: no differences found

[slava77]

+reconstruction

for #33153 3b74bf7

• code changes are in line with the PR description and the follow up review
  • parts backported are consistent with Updates to tauID python tool #33150 (already merged) Updates to tauID python tool (followup) #33302 (proposed recently)
  • there is a visually large fraction of updates in RecoTauTag/RecoTau/python/tools/runTauIdMVA.py, which remain specific only for 10_6_X (after a large reorganization in the tau configuration made in New Tau ID data format #28417 in CMSSW_11_1_X); this looks like a good improvement
  • overall, the updates fit the no-change requirements
• jenkins tests pass and comparisons with the baseline show no (relevant) differences

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1