Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to tauID python tool #33150

Merged
merged 5 commits into from
Mar 23, 2021
Merged

Updates to tauID python tool #33150

merged 5 commits into from
Mar 23, 2021

Conversation

mbluj
Copy link
Contributor

@mbluj mbluj commented Mar 11, 2021

PR description:

This PR updates a tool to run and then embed tauIDs to pat::Tau (RecoTauTag/RecoTau/python/tools/runTauIdMVA.py). The update enables possibility to run the tool for more than one pat::Tau collection in one job through specifying name of input collection and postix added to created modules and sequences. The new functionality does not affect any official workflows.

It is considered to backport this PR to 106X release series to be used on top on UL miniAOD.

PR validation:

Unit and (limited) matrix tests successful.

@cmsbuild cmsbuild added this to the CMSSW_11_3_X milestone Mar 11, 2021
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33150/21522

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mbluj for master.

It involves the following packages:

RecoTauTag/RecoTau

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@mbluj, @swozniewski this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor

slava77 commented Mar 11, 2021

@cmsbuild please test

@mbluj mbluj mentioned this pull request Mar 11, 2021
Merged
@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d01148/13451/summary.html
COMMIT: 05ea3c6
CMSSW: CMSSW_11_3_X_2021-03-10-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33150/13451/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

  • 23234.023234.0_TTbar_14TeV+2026D49+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal/step3_TTbar_14TeV+2026D49+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal.log
  • 34634.034634.0_TTbar_14TeV+2026D76+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal/step3_TTbar_14TeV+2026D76+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal.log
  • 28234.028234.0_TTbar_14TeV+2026D60+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal/step3_TTbar_14TeV+2026D60+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal.log
Expand to see more relval errors ...

@mbluj
Copy link
Contributor Author

mbluj commented Mar 12, 2021 •
edited
Loading

It was found that phase-2 workflows were affected by a typo - it is fixed now.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33150/21530

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

Pull request #33150 was updated. @perrotta, @jpata, @cmsbuild, @slava77 can you please check and sign again.

@perrotta
Copy link
Contributor

please test

@mbluj
Copy link
Contributor Author

mbluj commented Mar 19, 2021

In recent commit: reduced number of getattr/setattr and a set of other improvements as requested in the review.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33150/21669

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

Pull request #33150 was updated. @perrotta, @jpata, @cmsbuild, @slava77 can you please check and sign again.

@slava77
Copy link
Contributor

slava77 commented Mar 19, 2021

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d01148/13631/summary.html
COMMIT: 9d5f04a
CMSSW: CMSSW_11_3_X_2021-03-19-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33150/13631/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2639935
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2639906
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 36 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 155 log files, 37 edm output root files, 37 DQM output files
  • TriggerResults: no differences found

@slava77
Copy link
Contributor

slava77 commented Mar 23, 2021

+reconstruction

for #33150 9d5f04a

  • code changes are in line with the PR description and the follow up review; the changes are not changing the default processing
  • jenkins tests pass and comparisons with the baseline show no (relevant) differences

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Mar 23, 2021

+1

@cmsbuild cmsbuild merged commit 8ffadd1 into cms-sw:master Mar 23, 2021
@mbluj mbluj mentioned this pull request Mar 30, 2021
Merged
aloeliger pushed a commit to aloeliger/cmssw that referenced this pull request Apr 6, 2021
@cmsbuild
Merge pull request cms-sw#33150 from cms-tau-pog/CMSSW_11_3_X_tau-pog…
8dc3150 
…_tauIDtoolsDev

Updates to tauID python tool
swozniewski pushed a commit to cms-tau-pog/cmssw that referenced this pull request Apr 26, 2021
@cmsbuild @aloeliger
Add boosted taus to NanoAOD (#150)
96962a9 
* Merge pull request cms-sw#33150 from cms-tau-pog/CMSSW_11_3_X_tau-pog_tauIDtoolsDev

Updates to tauID python tool

* Initial working commit of boosted taus in CMSSW_11_3 NanoAOD

* Remove 2015 anti-E for 10_6v2 era compatibility in boosted taus

* Initial working commit of boosted taus in CMSSW_11_3 NanoAOD

* Remove 2015 anti-E for 10_6v2 era compatibility in boosted taus

* Remove commented boosted tau nanoAOD code

* Remove main nanoAOD config comments

* Remove leading charged hadronic candidate dxy and dz

* Update boosted tau configuration to remove excess ID variables

* Fix removal of boosted tau vars base

* Remove boosted tau sequences from previous eras

* Remove redundant decay mode information

* some polishing

* change Gen information for boosted taus

* Update nanoDQM for boosted taus

Co-authored-by: cmsbuild <cmsbuild@cern.ch>
Co-authored-by: Andrew Loeliger <aloelige@cern.ch>
Co-authored-by: Andrew David Loeliger <andrew.loeliger@cern.ch>
swozniewski pushed a commit to cms-tau-pog/cmssw that referenced this pull request Apr 30, 2021
@cmsbuild @aloeliger
Add boosted taus to NanoAOD (#150)
7980381 
* Merge pull request cms-sw#33150 from cms-tau-pog/CMSSW_11_3_X_tau-pog_tauIDtoolsDev

Updates to tauID python tool

* Initial working commit of boosted taus in CMSSW_11_3 NanoAOD

* Remove 2015 anti-E for 10_6v2 era compatibility in boosted taus

* Initial working commit of boosted taus in CMSSW_11_3 NanoAOD

* Remove 2015 anti-E for 10_6v2 era compatibility in boosted taus

* Remove commented boosted tau nanoAOD code

* Remove main nanoAOD config comments

* Remove leading charged hadronic candidate dxy and dz

* Update boosted tau configuration to remove excess ID variables

* Fix removal of boosted tau vars base

* Remove boosted tau sequences from previous eras

* Remove redundant decay mode information

* some polishing

* change Gen information for boosted taus

* Update nanoDQM for boosted taus

Co-authored-by: cmsbuild <cmsbuild@cern.ch>
Co-authored-by: Andrew Loeliger <aloelige@cern.ch>
Co-authored-by: Andrew David Loeliger <andrew.loeliger@cern.ch>
@perrotta perrotta mentioned this pull request May 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slava77 slava77 slava77 left review comments

Assignees
No one assigned
Labels
code-checks-approved fully-signed orp-approved reconstruction-approved tests-approved
Projects
None yet
Milestone
CMSSW_11_3_X
Development

Successfully merging this pull request may close these issues.
5 participants
@mbluj @cmsbuild @slava77 @perrotta @qliphy