adjust cp5 cr fragments to compensate P8.240 changes

[agrohsje]

PR description:

P8.240 required changes in the CPx tune fragment. these were already done in this PR:
51db35e#diff-c1a2292179da27b1385f4602a3b7459a8026b7992b84c77241fe3bb284545ee1
but the CR1 and CR2 fragments were not included. Settings now updated to be in sync with the CP5 default.

PR validation:

validation can be found in the talk by Sercan:
https://indico.cern.ch/event/783789/contributions/3364815/attachments/1822138/2980824/2019_Apr2_Pythia8-240_and_PDF.pdf
no available workflow with this special fragment available

[agrohsje]

assign generators

[agrohsje]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32319/20150

• This PR adds an extra 28KB to repository

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_3_X_2020-11-27-1100/slc7_amd64_gcc900: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/11120/console Started: 2020/11/27 21:30

[cmsbuild]

A new Pull Request was created by @agrohsje for master.

It involves the following packages:

Configuration/Generator

@SiewYan, @mkirsano, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

-1

Tested at: 5bd8219

CMSSW: CMSSW_11_3_X_2020-11-27-1100
SCRAM_ARCH: slc7_amd64_gcc900

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• add RecoLocalTracker_cff to TrackRefitters_cff #32178 @mmusich: add RecoLocalTracker_cff to TrackRefitters_cff
• Implement the fillDescriptions method for RawStreamFileWriterForBU #32284 @fwyzard: Implement the fillDescriptions method for RawStreamFileWriterForBU
• optimize search algorithm for EventFilter/SiStripRawToDigi/plugins/WarningSummary.cc #32280 @mmusich: optimize search algorithm for EventFilter/SiStripRawToDigi/plugins/WarningSummary.cc

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9c40ea/11120/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9c40ea/11120/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9c40ea/11120/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

• RelVals:

When I ran the RelVals I found an error in the following workflows:
11624.911 step1

runTheMatrix-results/11624.911_TTbar_13+2021_DD4hep+TTbar_13TeV_TuneCUETP8M1_GenSim+Digi+Reco+HARVEST+ALCA/step1_TTbar_13+2021_DD4hep+TTbar_13TeV_TuneCUETP8M1_GenSim+Digi+Reco+HARVEST+ALCA.log

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• add RecoLocalTracker_cff to TrackRefitters_cff #32178 @mmusich: add RecoLocalTracker_cff to TrackRefitters_cff
• Implement the fillDescriptions method for RawStreamFileWriterForBU #32284 @fwyzard: Implement the fillDescriptions method for RawStreamFileWriterForBU
• optimize search algorithm for EventFilter/SiStripRawToDigi/plugins/WarningSummary.cc #32280 @mmusich: optimize search algorithm for EventFilter/SiStripRawToDigi/plugins/WarningSummary.cc

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9c40ea/11120/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9c40ea/11120/git-merge-result

[cmsbuild]

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

[agrohsje]

Hi @silviodonato, @qliphy. How should I proceed? The segmentation violation is not related to my PR. I just add some P8 specification to fragments that are not even used here.

[silviodonato]

please test with #32313

[cmsbuild]

The tests are being triggered in jenkins.
Tested with other pull request(s) #32313

• CMSSW_11_3_X_2020-11-27-2300/slc7_amd64_gcc900: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/11128/console Started: 2020/11/28 11:18

[cmsbuild]

+1
Tested at: 5bd8219
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bddad6/11128/summary.html
CMSSW: CMSSW_11_3_X_2020-11-27-2300
SCRAM_ARCH: slc7_amd64_gcc900

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bddad6/11128/summary.html

There are some workflows for which there are errors in the baseline:
11624.911 step 1
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2529593
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2529564
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 148 log files, 34 edm output root files, 35 DQM output files

[agrohsje]

Hi @qliphy. Do you mind double-checking, then I sign off?

[silviodonato]

urgent

[qliphy]

Hi @qliphy. Do you mind double-checking, then I sign off?

@agrohsje They look good to me. Please go ahead. Thanks!

[agrohsje]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1