Implement the fillDescriptions method for RawStreamFileWriterForBU

[fwyzard]

PR description:

Implement the fillDescriptions() method for the RawStreamFileWriterForBU module.
Clean up the module's parameters and directly use an InputTag in the python configuration.

PR validation:

None.

[fwyzard]

please test

[fwyzard]

@smorovic do you think this would be useful ?

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32284/20079

• This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32284/20079/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32284/20079/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[fwyzard]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32284/20080

• This PR adds an extra 20KB to repository

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-11-24-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/11033/console Started: 2020/11/25 15:42

[cmsbuild]

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

EventFilter/Utilities

@perrotta, @emeschi, @cmsbuild, @slava77, @jpata, @smorovic can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[smorovic]

@fwyzard thanks for cleaning up the code. So far it's only used in testing on my side and the Unit test, but it's good to be up to date and more consistent with other modules.

[smorovic]

+1

[smorovic]

@fwyzard I just saw that in this script we still use ProductLabel:
https://github.com/cms-sw/cmssw/blob/master/EventFilter/Utilities/test/startBU.py#L131
ProductLabel = cms.untracked.string("s"),

and that script is part of the Unit Test, so I think the test will fail. I suppose that source is the new parameter name?

[fwyzard]

Yes.

Sorry, I grepped for RawStreamFileWriterForBU but I must have missed that. I'll update it accordingly.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-11-26-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/11079/console Started: 2020/11/26 17:04

[cmsbuild]

+1
Tested at: 2e2b420
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-243de4/11079/summary.html
CMSSW: CMSSW_11_2_X_2020-11-26-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-243de4/11079/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 7 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 2747014
• DQMHistoTests: Total failures: 16
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2746975
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 35 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 153 log files, 34 edm output root files, 36 DQM output files

[slava77]

+1

for #32284 2e2b420

• changed files are in the daq part of the package EventFilter/Utilities/ which has shared signatures, not affecting the code relevant to reco; the changes look good anyways

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1