Change track muon dataformats scouting #31962

jsalfeld · 2020-10-28T11:38:04Z

PR description:

-- For the upcoming Scouting Sample Production Campaign, added covariance matrix elements to scouting tracks and muons. This will allow vertex fitting after data taking. Also made a quick hltPixelVertex to hltPixelTrack association and introduced the vertex index in the corresponding collection.

-- while I introduced an option of reducing relevant bits to store information, the scouting track collection will need significant storage space and we will need to double check in the next iteration what exactly will be needed
--->

cmssw/DataFormats/TrackReco/interface/TrackBase.h

Line 5 in 3c9bd1b

* Common base class to all track types, including Muon fits.

Indicates roughly 20 parameters are needed

observations:
-- about on average 2-3% of the tracks are incorrectly associated to vertices via the method of minimising dz^2 - this is measured on ttbar events with roughly 600 tracks per event. (the vertices are only clustered in Z)
-- all tracks in the associated track collection of vertices, are quadruplets
-- not all quadruplets are in the list of tracks associated to vertices
-- via the matching performed in this producer, all tracks (triplets & quadruplets) will be matched to vertices if dxy^2+dz^2 < 0.015.

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

scram b distclean
git cms-checkdeps -a -A
scram b -j 8
scram b runtests

scram build code-checks
scram build code-format

…ScoutingRAW

cmsbuild · 2020-10-28T11:38:25Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-10-28T11:45:12Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31962/19418

This PR adds an extra 24KB to repository

cmsbuild · 2020-10-28T11:46:15Z

A new Pull Request was created by @jsalfeld (Jakob Salfeld-Nebgen) for master.

It involves the following packages:

DataFormats/Scouting
HLTrigger/Muon

@smuzaffar, @Dr15Jones, @makortel, @cmsbuild, @Martin-Grunewald, @fwyzard can you please review it and eventually sign? Thanks.
@abbiendi, @Fedespring, @Martin-Grunewald, @calderona, @HuguesBrun, @jhgoh, @rovere, @trocino, @cericeci this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

fwyzard · 2020-10-28T12:07:53Z

please test

cmsbuild · 2020-10-28T12:08:14Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-10-27-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10340/console Started: 2020/10/28 13:10

cmsbuild · 2020-10-28T12:13:13Z

-1

Tested at: 641854b

CMSSW: CMSSW_11_2_X_2020-10-27-2300
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-35cd8e/10340/summary.html

I found follow errors while testing this PR

Failed tests: ClangBuild

Clang:

I found compilation warning while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

See details on the summary page.

cmsbuild · 2020-10-28T12:13:15Z

Comparison not run due to Build errors/Fireworks only changes/No short matrix requested (RelVals and Igprof tests were also skipped)

jsalfeld · 2020-10-28T12:16:10Z

https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-35cd8e/10340/clang-new-warnings.log

Important, thanks for finding it! I will update

fwyzard · 2020-10-28T12:17:21Z

HLTrigger/Muon/plugins/HLTScoutingTrackProducer.cc

+  const edm::EDGetTokenT<reco::VertexCollection> vertexCollection_;
+
+  const int mantissaPrecision;
+  const int vtxMinDist;


Suggested change

const int vtxMinDist;

const float vtxMinDist;

ah here I now took "const double vtxMinDist", following same type for "vtxMinDist" in Line 59 and 144. Shall I take float?

I think the difference is negligible.

fwyzard · 2020-10-28T12:17:33Z

HLTrigger/Muon/plugins/HLTScoutingTrackProducer.cc

+    : otherTrackCollection_(consumes<reco::TrackCollection>(iConfig.getParameter<edm::InputTag>("OtherTracks"))),
+      vertexCollection_(consumes<reco::VertexCollection>(iConfig.getParameter<edm::InputTag>("vertexCollection"))),
+      mantissaPrecision(iConfig.getParameter<int>("mantissaPrecision")),
+      vtxMinDist(iConfig.getParameter<int>("vtxMinDist")) {


Suggested change

vtxMinDist(iConfig.getParameter<int>("vtxMinDist")) {

vtxMinDist(iConfig.getParameter<double>("vtxMinDist")) {

fwyzard · 2020-10-28T12:17:54Z

HLTrigger/Muon/plugins/HLTScoutingTrackProducer.cc

+  desc.add<edm::InputTag>("vertexCollection", edm::InputTag("hltPixelVertices"));
+
+  desc.add<int>("mantissaPrecision", 23);
+  desc.add<int>("vtxMinDist", 0.01);


Suggested change

desc.add<int>("vtxMinDist", 0.01);

desc.add<double>("vtxMinDist", 0.01);

cmsbuild · 2020-11-24T18:06:35Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-35cd8e/10991/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2961011
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2960988
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
Checked 158 log files, 34 edm output root files, 37 DQM output files

cmsbuild · 2020-11-24T18:28:25Z

+1
Tested at: 16d8138
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-35cd8e/11001/summary.html
CMSSW: CMSSW_11_2_X_2020-11-23-2300
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-11-24T18:28:27Z

Comparison job queued.

cmsbuild · 2020-11-24T19:50:48Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-35cd8e/11001/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2961011
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2960988
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
Checked 158 log files, 34 edm output root files, 37 DQM output files

makortel · 2020-11-24T20:03:24Z

+1

cmsbuild · 2020-11-24T20:03:50Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

fwyzard · 2020-11-24T20:05:08Z

urgent

fwyzard · 2020-11-24T20:05:18Z

please integrate in 11.2.0-pre10

qliphy · 2020-11-25T00:05:09Z

+1

makortel · 2020-11-25T02:00:44Z

@jsalfeld The #32217 was merged already earlier, could you change the code back to use ESGetToken soon? Thanks.

jsalfeld added 2 commits October 28, 2020 12:23

added additional track parameters for vertex refitting downstream of …

46e3404

…ScoutingRAW

added additional track parameters for vertex refitting downstream of …

641854b

…ScoutingRAW

cmsbuild added this to the CMSSW_11_2_X milestone Oct 28, 2020

cmsbuild added code-checks-pending comparison-pending core-pending hlt-pending orp-pending pending-signatures tests-pending labels Oct 28, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 28, 2020

cmsbuild added tests-started and removed tests-pending labels Oct 28, 2020

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels Oct 28, 2020

fwyzard reviewed Oct 28, 2020

View reviewed changes

fixed bug, int->double

3f9b5d7

cmsbuild added the tests-started label Nov 24, 2020

cmsbuild added comparison-available and removed comparison-pending labels Nov 24, 2020

cmsbuild added comparison-pending tests-approved and removed comparison-available tests-started labels Nov 24, 2020

cmsbuild added comparison-available and removed comparison-pending labels Nov 24, 2020

cmsbuild added core-approved fully-signed and removed core-pending pending-signatures labels Nov 24, 2020

cmsbuild added the urgent label Nov 24, 2020

cmsbuild added orp-approved and removed orp-pending labels Nov 25, 2020

cmsbuild merged commit 987c31a into cms-sw:master Nov 25, 2020

cmsbuild mentioned this pull request Nov 25, 2020

ECAL SC parameters to EventSetup #32066

Merged

jsalfeld mentioned this pull request Nov 27, 2020

changing to esConsumes after fix in #32217 #32311

Merged

swagata87 mentioned this pull request Jul 11, 2022

Add EGamma calo ID variable cut to Run 3 Scouting Electrons #38602

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change track muon dataformats scouting #31962

Change track muon dataformats scouting #31962

jsalfeld commented Oct 28, 2020

cmsbuild commented Oct 28, 2020

cmsbuild commented Oct 28, 2020

cmsbuild commented Oct 28, 2020

fwyzard commented Oct 28, 2020

cmsbuild commented Oct 28, 2020 •

edited

Loading

cmsbuild commented Oct 28, 2020

cmsbuild commented Oct 28, 2020

jsalfeld commented Oct 28, 2020

fwyzard Oct 28, 2020

jsalfeld Oct 28, 2020

fwyzard Oct 28, 2020

fwyzard Oct 28, 2020

fwyzard Oct 28, 2020

cmsbuild commented Nov 24, 2020

cmsbuild commented Nov 24, 2020

cmsbuild commented Nov 24, 2020

cmsbuild commented Nov 24, 2020

makortel commented Nov 24, 2020

cmsbuild commented Nov 24, 2020

fwyzard commented Nov 24, 2020

fwyzard commented Nov 24, 2020

qliphy commented Nov 25, 2020

makortel commented Nov 25, 2020

	vtxMinDist(iConfig.getParameter<int>("vtxMinDist")) {
	vtxMinDist(iConfig.getParameter<double>("vtxMinDist")) {

	desc.add<int>("vtxMinDist", 0.01);
	desc.add<double>("vtxMinDist", 0.01);

Change track muon dataformats scouting #31962

Change track muon dataformats scouting #31962

Conversation

jsalfeld commented Oct 28, 2020

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Oct 28, 2020

cmsbuild commented Oct 28, 2020

cmsbuild commented Oct 28, 2020

fwyzard commented Oct 28, 2020

cmsbuild commented Oct 28, 2020 • edited Loading

cmsbuild commented Oct 28, 2020

cmsbuild commented Oct 28, 2020

jsalfeld commented Oct 28, 2020

fwyzard Oct 28, 2020

Choose a reason for hiding this comment

jsalfeld Oct 28, 2020

Choose a reason for hiding this comment

fwyzard Oct 28, 2020

Choose a reason for hiding this comment

fwyzard Oct 28, 2020

Choose a reason for hiding this comment

fwyzard Oct 28, 2020

Choose a reason for hiding this comment

cmsbuild commented Nov 24, 2020

cmsbuild commented Nov 24, 2020

cmsbuild commented Nov 24, 2020

cmsbuild commented Nov 24, 2020

makortel commented Nov 24, 2020

cmsbuild commented Nov 24, 2020

fwyzard commented Nov 24, 2020

fwyzard commented Nov 24, 2020

qliphy commented Nov 25, 2020

makortel commented Nov 25, 2020

cmsbuild commented Oct 28, 2020 •

edited

Loading