-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean BuildFiles in DetectorDescription #31663
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31663/18774
|
A new Pull Request was created by @guitargeek (Jonas Rembser) for master. It involves the following packages: DetectorDescription/DDCMS @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @santocch can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
The tests are being triggered in jenkins.
|
@guitargeek - Thanks! The changes for DD and Geometry look good to me :-) |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
merge |
The bot is asleep? |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
PR description:
Another quick partially automatic BuildFile cleaning PR in the style of many before (for example #31590).
As always, only the dependencies which are not included in any of the sources are removed, so these changes are orthogonal and complementary to the recent PRs which added all packages that are actually included.
PR validation:
CMSSW compiles. It was checked that all newly added dependencies are actually required by the package with
git grep
.