Add a customisation to run the "GRun" HLT menu on Run 2 data/MC #31655

fwyzard · 2020-10-02T15:50:57Z

PR description:

Add a customisation to run the "GRun" HLT menu on Run 2 data/MC.

customiseFor2018Input takes care of two things:

reverts the HCAL configuration that the one in 2018
reverts the Pixel calibrations to the scheme used in the Run 2 conditions

PR validation:

None yet.

cmsbuild · 2020-10-02T15:51:18Z

The code-checks are being triggered in jenkins.

fwyzard · 2020-10-02T15:55:48Z

This PR is incomplete: it adds the required customisation, but not a way to call it.

Some ideas

add an extra "2018" menu, identical to the "GRun" menu, but including the extra customisation
add an extra "2018" menu, that is just a thin wrapper that imports the "GRun" menu and aplies the extra customisation:
```
from HLT_GRun_cff import fragmet
from customizeHLTforCMSSW import *
fragment = customiseFor2018Input(fragment)
```
apply the customisation to the HLT menus based on the process Era:
```
(~run3_common).toModify(fragment, customiseFor2018Input)
```
However, to work for the self-contained HLT menus, one would need to start using eras correctly there - and we would still need two dumps, one for 2018 and one for Run3.

fwyzard · 2020-10-02T15:56:16Z

@Martin-Grunewald what do you think ?

cmsbuild · 2020-10-02T15:58:20Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31655/18756

This PR adds an extra 16KB to repository

cmsbuild · 2020-10-02T15:58:42Z

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

HLTrigger/Configuration

@Martin-Grunewald, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

Martin-Grunewald · 2020-10-05T15:26:28Z

please test

cmsbuild · 2020-10-05T15:26:48Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-10-05-1200/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9735/console Started: 2020/10/05 17:27

cmsbuild · 2020-10-05T16:36:06Z

+1
Tested at: 8af9c7c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-781ac8/9735/summary.html
CMSSW: CMSSW_11_2_X_2020-10-05-1200
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-10-05T16:36:08Z

Comparison job queued.

cmsbuild · 2020-10-05T18:01:04Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-781ac8/9735/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2542225
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2542202
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 149 log files, 22 edm output root files, 35 DQM output files

Martin-Grunewald · 2020-10-06T13:07:23Z

+1

cmsbuild · 2020-10-06T20:28:04Z

The code-checks are being triggered in jenkins.

silviodonato · 2020-10-06T20:29:50Z

please test
I trivially solved the conflict with #31671
please double check

cmsbuild · 2020-10-06T20:33:39Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31655/18832

This PR adds an extra 16KB to repository

cmsbuild · 2020-10-06T20:34:03Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-10-06-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9763/console Started: 2020/10/06 22:35

cmsbuild · 2020-10-06T20:34:04Z

Pull request #31655 was updated. @Martin-Grunewald, @cmsbuild, @fwyzard can you please check and sign again.

cmsbuild · 2020-10-06T23:44:19Z

+1
Tested at: f4d9ad5
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-781ac8/9763/summary.html
CMSSW: CMSSW_11_2_X_2020-10-06-1100
SCRAM_ARCH: slc7_amd64_gcc820

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

Clean BuildFiles in DetectorDescription #31663 @guitargeek: Clean BuildFiles in DetectorDescription
Migration of HLT menus to CMSSW_11_2_0_pre7 #31671 @cms-tsg-storm: Migration of HLT menus to CMSSW_11_2_0_pre7
Use akCs4PFJets for candidate-based tagInfos for HI workflows #31674 @mandrenguyen: Use akCs4PFJets for candidate-based tagInfos for HI workflows
Remove dependency from DDCMS/interface/DDShapes.h #31649 @namapane: Remove dependency from DDCMS/interface/DDShapes.h
[DD4hep] Remove Shape Wrapper Classes #31581 @ianna: [DD4hep] Remove Shape Wrapper Classes
[DD4hep] Remove Spurious Include #31652 @ianna: [DD4hep] Remove Spurious Include
[DD4hep] Filtered View Performance - Step 3 #31662 @ianna: [DD4hep] Filtered View Performance - Step 3

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-781ac8/9763/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-781ac8/9763/git-merge-result

cmsbuild · 2020-10-06T23:44:23Z

Comparison job queued.

cmsbuild · 2020-10-07T03:03:01Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-781ac8/9763/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 142 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2542221
DQMHistoTests: Total failures: 1612
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2540587
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.002 KiB( 34 files compared)
DQMHistoSizes: changed ( 11634.0,... ): 0.001 KiB HLT/Filters
Checked 149 log files, 22 edm output root files, 35 DQM output files

Martin-Grunewald · 2020-10-07T04:25:02Z

@silviodonato Thanks!

Martin-Grunewald · 2020-10-07T04:25:07Z

+1

cmsbuild · 2020-10-07T04:25:24Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2020-10-07T07:59:23Z

+1
The differences are related to #31674

Add a customisation to run the "GRun" HLT menu on Run 2 data/MC

8af9c7c

cmsbuild added this to the CMSSW_11_2_X milestone Oct 2, 2020

cmsbuild added code-checks-pending comparison-pending hlt-pending orp-pending pending-signatures tests-pending labels Oct 2, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 2, 2020

cmsbuild added tests-started and removed tests-pending labels Oct 5, 2020

cmsbuild mentioned this pull request Oct 5, 2020

Migration of HLT menus to CMSSW_11_2_0_pre7 #31671

Merged

cmsbuild added tests-approved and removed tests-started labels Oct 5, 2020

cmsbuild added comparison-available and removed comparison-pending labels Oct 5, 2020

cmsbuild removed hlt-pending pending-signatures labels Oct 6, 2020

cmsbuild added the tests-pending label Oct 6, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 6, 2020

cmsbuild added tests-started and removed tests-pending labels Oct 6, 2020

cmsbuild added tests-approved and removed tests-started labels Oct 6, 2020

cmsbuild added comparison-available and removed comparison-pending labels Oct 7, 2020

cmsbuild added fully-signed hlt-approved and removed hlt-pending pending-signatures labels Oct 7, 2020

cmsbuild added orp-approved and removed orp-pending labels Oct 7, 2020

cmsbuild merged commit c51856d into cms-sw:master Oct 7, 2020

fwyzard mentioned this pull request Nov 9, 2020

add customisation for pixel gains to 11_1_X #32057

Merged

fwyzard deleted the customiseHLTfor2018_112x branch December 27, 2020 09:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add a customisation to run the "GRun" HLT menu on Run 2 data/MC #31655

Add a customisation to run the "GRun" HLT menu on Run 2 data/MC #31655

fwyzard commented Oct 2, 2020

cmsbuild commented Oct 2, 2020

fwyzard commented Oct 2, 2020

fwyzard commented Oct 2, 2020

cmsbuild commented Oct 2, 2020

cmsbuild commented Oct 2, 2020

Martin-Grunewald commented Oct 5, 2020

cmsbuild commented Oct 5, 2020 •

edited

Loading

cmsbuild commented Oct 5, 2020

cmsbuild commented Oct 5, 2020

cmsbuild commented Oct 5, 2020

Martin-Grunewald commented Oct 6, 2020

cmsbuild commented Oct 6, 2020

silviodonato commented Oct 6, 2020

cmsbuild commented Oct 6, 2020

cmsbuild commented Oct 6, 2020 •

edited

Loading

cmsbuild commented Oct 6, 2020

cmsbuild commented Oct 6, 2020

cmsbuild commented Oct 6, 2020

cmsbuild commented Oct 7, 2020

Martin-Grunewald commented Oct 7, 2020

Martin-Grunewald commented Oct 7, 2020

cmsbuild commented Oct 7, 2020

silviodonato commented Oct 7, 2020

Add a customisation to run the "GRun" HLT menu on Run 2 data/MC #31655

Add a customisation to run the "GRun" HLT menu on Run 2 data/MC #31655

Conversation

fwyzard commented Oct 2, 2020

PR description:

PR validation:

cmsbuild commented Oct 2, 2020

fwyzard commented Oct 2, 2020

fwyzard commented Oct 2, 2020

cmsbuild commented Oct 2, 2020

cmsbuild commented Oct 2, 2020

Martin-Grunewald commented Oct 5, 2020

cmsbuild commented Oct 5, 2020 • edited Loading

cmsbuild commented Oct 5, 2020

cmsbuild commented Oct 5, 2020

cmsbuild commented Oct 5, 2020

Martin-Grunewald commented Oct 6, 2020

cmsbuild commented Oct 6, 2020

silviodonato commented Oct 6, 2020

cmsbuild commented Oct 6, 2020

cmsbuild commented Oct 6, 2020 • edited Loading

cmsbuild commented Oct 6, 2020

cmsbuild commented Oct 6, 2020

cmsbuild commented Oct 6, 2020

cmsbuild commented Oct 7, 2020

Martin-Grunewald commented Oct 7, 2020

Martin-Grunewald commented Oct 7, 2020

cmsbuild commented Oct 7, 2020

silviodonato commented Oct 7, 2020

cmsbuild commented Oct 5, 2020 •

edited

Loading

cmsbuild commented Oct 6, 2020 •

edited

Loading