Fix Service access from ES modules #30688
Conversation
Now the ServiceToken is used before calling the methods of an ES module.
If the Service system is not available, tests using this module will throw an exception.
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30688/16979
|
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: FWCore/Framework @makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins.
|
|
Comparison job queued. |
|
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
|
+1 |
cmsbuild
added
core-approved
fully-signed
and removed
core-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
Fix: Make Services available to ES Modules Now the ServiceToken is used before calling the methods of an ES module. Check that Services are accessible from ESProducer If the Service system is not available, tests using this module will throw an exception. Co-authored-by: Chris Jones <chrisdjones15@gmail.com>
PR description:
It was found that when using multiple threads an ES module might not be able to access a Service. This change properly propagates the Service access to any task that will run an ES module.
PR validation:
The code compiles and a simple test did not exhibit the problem after repeating the test 10 times. Previously it was failing around 1 out of 3 tries.