EventSetup conditions fail using ESGetToken for a product that uses a Service

[fwyzard]

We are seeing an issue with the use of ESGetToken after migrating the Patatrack branch to CMSSW_11_2_X .

Some modules fail with an error like

----- Begin Fatal Exception 13-Jul-2020 19:11:32 CEST-----------------------
An exception of category 'NotFound' occurred while
   [0] Running EventSetup component SiPixelGainCalibrationForHLTGPUESProducer/'siPixelGainCalibrationForHLTGPU
Exception Message:
Service no ServiceRegistry has been set for this thread
----- End Fatal Exception -------------------------------------------------

A cursory investigation following a suggestion by @makortel suggests that this happens when an ESGetToken is used to access a product, produced by an ESProducers that accesses a Service (in our case likely the CUDAService) when the product is being produced.

[cmsbuild]

A new Issue was created by @fwyzard Andrea Bocci.

@Dr15Jones, @silviodonato, @dpiparo, @smuzaffar, @makortel can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

[makortel]

assign core

[cmsbuild]

New categories assigned: core

@Dr15Jones,@smuzaffar,@makortel you have been requested to review this Pull request/Issue and eventually sign? Thanks

[makortel]

The CUDAService gets called in the constructor of the ESProduct, that has cms::cuda::ESProduct member

cmssw/HeterogeneousCore/CUDACore/interface/ESProduct.h

Line 21 in 692a8d5

ESProduct() : gpuDataPerDevice_(numberOfDevices()) {

cmssw/HeterogeneousCore/CUDAServices/src/numberOfDevices.cc

Lines 5 to 10 in 692a8d5

	namespace cms::cuda {
	int numberOfDevices() {
	edm::Service<CUDAService> cs;
	return cs->enabled() ? cs->numberOfDevices() : 0;
	}
	} // namespace cms::cuda

[Dr15Jones]

#30688 should fix this. Thanks for the report.

[makortel]

+1

Fix has been merged

[cmsbuild]

This issue is fully signed and ready to be closed.