Trackjets as seeds of JetPlusTrack at RECO and MINIAOD #30430

kodolova · 2020-06-26T15:18:57Z

PR description:

Improved efficiency for low Pt jets via TrackJets seeding. Possibility to rereconstructed with MiniAOD objects.
PR description:

Presented at Reconstruction meeting
https://indico.cern.ch/event/923095/
PR validation:

Tests are performed according:https://cms-sw.github.io/PRWorkflow.html
Result of runTheMatrix test is in:
/afs/cern.ch/work/k/kodolova/public/HMUMUBB/CMSSW_11_2_X_2020-06-10-2300/src/TEST

if this PR is a backport please specify the original PR and why you need to backport that PR:

Before submitting your pull requests, make sure you followed this checklist:

verify that the PR is really intended for the chosen branch
verify that changes follow CMS Naming, Coding, And Style Rules
verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

cmsbuild · 2020-06-26T15:19:25Z

The code-checks are being triggered in jenkins.

kodolova · 2020-06-26T15:21:08Z

I was forced to create the new PR as I got for 30188:
hint: Updates were rejected because the tip of your current branch is behind
hint: its remote counterpart. Integrate the remote changes (e.g.
hint: 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.

cmsbuild · 2020-06-26T15:53:13Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30430/16525

This PR adds an extra 212KB to repository
Found files with invalid states:
- RecoJets/JetPlusTracks/plugins/JetPlusTrackProducer.cc.rej:
  - Added: b0922ca
  - Deleted: 4183b77
- RecoJets/JetPlusTracks/plugins/TrackFromPFProducer.cc:
  - Added: cca30d3
  - Modified: 79ee624, b0922ca
  - Deleted: 73097d4
- RecoJets/JetPlusTracks/plugins/JetPlusTrackProducer.h.rej:
  - Added: b0922ca
  - Deleted: 4183b77
- RecoJets/JetPlusTracks/plugins/TrackFromPFProducer.h:
  - Added: cca30d3
  - Modified: b0922ca
  - Deleted: 73097d4
- RecoJets/JetPlusTracks/plugins/JetPlusTrackProducer.cc.orig:
  - Added: b0922ca
  - Deleted: 4183b77
- RecoJets/JetPlusTracks/plugins/JetPlusTrackProducer.h.orig:
  - Added: b0922ca
  - Deleted: 4183b77
There are other open Pull requests which might conflict with changes you have proposed:
- File RecoJets/JetPlusTracks/plugins/JetPlusTrackCorrector.cc modified in PR(s): [RFC] Test clang-tidy --checks performance-unnecessary-value-param #29933, [RFC] Test clang-tidy --checks modernize-loop-convert #29935
- File RecoJets/JetPlusTracks/plugins/JetPlusTrackCorrector.h modified in PR(s): [RFC] Test clang-tidy --checks performance-unnecessary-value-param #29933
- File RecoJets/JetPlusTracks/plugins/JetPlusTrackProducer.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935
- File RecoJets/JetPlusTracks/plugins/JetPlusTrackProducerAA.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-emplace #29937

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30430/16525/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30430/16525/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

slava77 · 2020-06-26T15:54:48Z

hint: Updates were rejected because the tip of your current branch is behind

you can git push --force when it's clear what's been done. (the existing/old PR needs to be in an open state for this to work)
It would be easier to stay in the original PR to keep track of the comments from the previous review round.

kodolova · 2020-06-26T16:16:40Z

Ok, I will try to do

kodolova · 2020-06-26T16:22:35Z

I succeeded with --force option. Thus, what I should do? I have two identical PR: 30188 and 30430... We have to keep one of them.
Please, advice.

cmsbuild · 2020-06-26T16:27:54Z

The code-checks are being triggered in jenkins.

slava77 · 2020-06-26T16:32:54Z

I succeeded with --force option. Thus, what I should do? I have two identical PR: 30188 and 30430... We have to keep one of them.
Please, advice.

I'm not sure about the meaning of "identical"

JPT_TrackJets seed reco and PAT rereco 11_2_x based #30188 is done with kodolova:JPT_TrackJetsSeedReco_PATrereco_11_2_Xbased
Trackjets as seeds of JetPlusTrack at RECO and MINIAOD #30430 (this PR) is done with kodolova:JPT_TrackJetsSeedReco_PATrereco_11_2_X_newrules

My moderate preference is to have #30188 reopened and its branch updated instead of advancing to this PR.

kodolova · 2020-06-26T16:46:00Z

That's ok. The problem is that I do not know how to reopen... I push the button at the bottom of the page but who knows what it is doing...

slava77 · 2020-06-26T17:57:04Z

if you force-pushed to the branch of #30188 (kodolova:JPT_TrackJetsSeedReco_PATrereco_11_2_Xbased) before reopening, then the PR is locked out and I've seen the "reopen" button stop working.

slava77 · 2020-06-26T17:58:14Z

if you force-pushed to the branch of #30188 (kodolova:JPT_TrackJetsSeedReco_PATrereco_11_2_Xbased) before reopening, then the PR is locked out and I've seen the "reopen" button stop working.

it's not a huge deal, I can continue the review in this PR.

slava77 · 2020-06-26T18:00:09Z

code-checks

trying manually, it looks like the automated attempt from 2 hours ago got stuck
#30430 (comment)

cmsbuild · 2020-06-26T18:00:36Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-06-26T18:28:48Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30430/16533

This PR adds an extra 212KB to repository
Found files with invalid states:
- RecoJets/JetPlusTracks/plugins/JetPlusTrackProducer.cc.rej:
  - Added: b0922ca
  - Deleted: 4183b77
- RecoJets/JetPlusTracks/plugins/TrackFromPFProducer.cc:
  - Added: cca30d3
  - Modified: 79ee624, b0922ca
  - Deleted: 73097d4
- RecoJets/JetPlusTracks/plugins/JetPlusTrackProducer.h.rej:
  - Added: b0922ca
  - Deleted: 4183b77
- RecoJets/JetPlusTracks/plugins/TrackFromPFProducer.h:
  - Added: cca30d3
  - Modified: b0922ca
  - Deleted: 73097d4
- RecoJets/JetPlusTracks/plugins/JetPlusTrackProducer.cc.orig:
  - Added: b0922ca
  - Deleted: 4183b77
- RecoJets/JetPlusTracks/plugins/JetPlusTrackProducer.h.orig:
  - Added: b0922ca
  - Deleted: 4183b77
There are other open Pull requests which might conflict with changes you have proposed:
- File RecoJets/JetPlusTracks/plugins/JetPlusTrackCorrector.cc modified in PR(s): [RFC] Test clang-tidy --checks performance-unnecessary-value-param #29933, [RFC] Test clang-tidy --checks modernize-loop-convert #29935
- File RecoJets/JetPlusTracks/plugins/JetPlusTrackCorrector.h modified in PR(s): [RFC] Test clang-tidy --checks performance-unnecessary-value-param #29933
- File RecoJets/JetPlusTracks/plugins/JetPlusTrackProducer.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935
- File RecoJets/JetPlusTracks/plugins/JetPlusTrackProducerAA.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-emplace #29937

cmsbuild · 2020-06-26T18:29:07Z

A new Pull Request was created by @kodolova (kodolova) for master.

It involves the following packages:

CommonTools/RecoAlgos
RecoJets/JetPlusTracks

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @jdolen, @ahinzmann, @riga, @abbiendi, @jhgoh, @jdamgov, @makortel, @nhanvtran, @gkasieczka, @clelange, @hatakeyamak, @schoef, @mariadalfonso, @seemasharmafnal this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

slava77 · 2020-06-26T18:46:23Z

@cmsbuild please test

cmsbuild · 2020-06-26T18:46:49Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-06-26-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7442/console Started: 2020/06/26 21:14

cmsbuild · 2020-08-05T12:44:24Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-08-05T12:51:34Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30430/17570

This PR adds an extra 140KB to repository
Found files with invalid states:
- RecoJets/JetPlusTracks/plugins/JetPlusTrackAddonSeedProducer.h:
  - Added: e7b3856
  - Modified: 7a0d2c9, b186e5a
  - Deleted: 7c4bc90
- RecoJets/JetPlusTracks/plugins/JetPlusTrackProducer.cc.rej:
  - Added: b186e5a
  - Deleted: 93a676c
- CommonTools/RecoAlgos/python/trackFromPackedCandidateProducer_cfi.py:
  - Added: 357f323
  - Deleted: 7c4bc90
- RecoJets/JetPlusTracks/plugins/TrackFromPFProducer.cc:
  - Added: e7b3856
  - Modified: 7a0d2c9, b186e5a
  - Deleted: 0bf62c8
- RecoJets/JetPlusTracks/plugins/JetPlusTrackProducer.h.rej:
  - Added: b186e5a
  - Deleted: 93a676c
- RecoJets/JetPlusTracks/plugins/TrackFromPFProducer.h:
  - Added: e7b3856
  - Modified: b186e5a
  - Deleted: 0bf62c8
- RecoJets/JetPlusTracks/python/jetPlusTrackAddonSeedProducer_cfi.py:
  - Added: 357f323
  - Deleted: 7c4bc90
- RecoJets/JetPlusTracks/plugins/JetPlusTrackProducer.cc.orig:
  - Added: b186e5a
  - Deleted: 93a676c
- RecoJets/JetPlusTracks/plugins/JetPlusTrackProducer.h.orig:
  - Added: b186e5a
  - Deleted: 93a676c

cmsbuild · 2020-08-05T12:52:02Z

Pull request #30430 was updated. @perrotta, @jpata, @cmsbuild, @slava77 can you please check and sign again.

slava77 · 2020-08-05T13:09:39Z

@cmsbuild please test

cmsbuild · 2020-08-05T13:10:04Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-08-04-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8580/console Started: 2020/08/05 16:01

cmsbuild · 2020-08-05T15:13:26Z

+1
Tested at: aa78787
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e82886/8580/summary.html
CMSSW: CMSSW_11_2_X_2020-08-04-2300
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-08-05T15:13:28Z

Comparison job queued.

cmsbuild · 2020-08-05T16:41:36Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e82886/8580/summary.html

Comparison Summary:

No significant changes to the logs found
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 151 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2612401
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2612352
DQMHistoTests: Total skipped: 48
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 149 log files, 22 edm output root files, 35 DQM output files

slava77 · 2020-08-06T14:02:44Z

@jfernan2 @ahinzmann @lathomas @kirschen
please take a note that we may need to re-enable the JPT jet monitoring in DQM.
It seems like it was lost after the AK5 -> AK4 migration a while back.

slava77 · 2020-08-06T15:31:30Z

+1

for #30430 aa78787

code changes are in line with the PR description and the follow up review
- somewhat small changes in physics are expected for regular reco, only at lower pt JPT jets where the track jets can contribute in a less correlated way than calojetes already used for seeding
- the setup of running on (or in) miniAOD is working with a test config and will stay "experimental"/analysis-only for some time
jenkins tests pass and comparisons with the baseline show differences only in JPT jets

e.g. in wf 136.874 in egamma 2018C PD
more jets appear in the lower energy part of the spectrum

cmsbuild · 2020-08-06T15:31:55Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2020-08-07T08:15:13Z

+1

cmsbuild added this to the CMSSW_11_2_X milestone Jun 26, 2020

cmsbuild added code-checks-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Jun 26, 2020

cmsbuild added code-checks-rejected and removed code-checks-pending labels Jun 26, 2020

cmsbuild added code-checks-pending and removed code-checks-rejected labels Jun 26, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 26, 2020

cmsbuild added code-checks-pending comparison-pending tests-pending labels Aug 5, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 5, 2020

cmsbuild added tests-started and removed tests-pending labels Aug 5, 2020

cmsbuild added tests-approved and removed tests-started labels Aug 5, 2020

cmsbuild added comparison-available and removed comparison-pending labels Aug 5, 2020

cmsbuild added fully-signed reconstruction-approved and removed pending-signatures reconstruction-pending labels Aug 6, 2020

silviodonato merged commit 8424155 into cms-sw:master Aug 7, 2020

cmsbuild added orp-approved and removed orp-pending labels Aug 7, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Trackjets as seeds of JetPlusTrack at RECO and MINIAOD #30430

Trackjets as seeds of JetPlusTrack at RECO and MINIAOD #30430

kodolova commented Jun 26, 2020

cmsbuild commented Jun 26, 2020

kodolova commented Jun 26, 2020

cmsbuild commented Jun 26, 2020

slava77 commented Jun 26, 2020

kodolova commented Jun 26, 2020

kodolova commented Jun 26, 2020

cmsbuild commented Jun 26, 2020

slava77 commented Jun 26, 2020

kodolova commented Jun 26, 2020

slava77 commented Jun 26, 2020

slava77 commented Jun 26, 2020

slava77 commented Jun 26, 2020

cmsbuild commented Jun 26, 2020

cmsbuild commented Jun 26, 2020

cmsbuild commented Jun 26, 2020

slava77 commented Jun 26, 2020

cmsbuild commented Jun 26, 2020 •

edited

Loading

cmsbuild commented Aug 5, 2020

cmsbuild commented Aug 5, 2020

cmsbuild commented Aug 5, 2020

slava77 commented Aug 5, 2020

cmsbuild commented Aug 5, 2020 •

edited

Loading

cmsbuild commented Aug 5, 2020

cmsbuild commented Aug 5, 2020

cmsbuild commented Aug 5, 2020

slava77 commented Aug 6, 2020

slava77 commented Aug 6, 2020

cmsbuild commented Aug 6, 2020

silviodonato commented Aug 7, 2020

Trackjets as seeds of JetPlusTrack at RECO and MINIAOD #30430

Trackjets as seeds of JetPlusTrack at RECO and MINIAOD #30430

Conversation

kodolova commented Jun 26, 2020

PR description:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Jun 26, 2020

kodolova commented Jun 26, 2020

cmsbuild commented Jun 26, 2020

slava77 commented Jun 26, 2020

kodolova commented Jun 26, 2020

kodolova commented Jun 26, 2020

cmsbuild commented Jun 26, 2020

slava77 commented Jun 26, 2020

kodolova commented Jun 26, 2020

slava77 commented Jun 26, 2020

slava77 commented Jun 26, 2020

slava77 commented Jun 26, 2020

cmsbuild commented Jun 26, 2020

cmsbuild commented Jun 26, 2020

cmsbuild commented Jun 26, 2020

slava77 commented Jun 26, 2020

cmsbuild commented Jun 26, 2020 • edited Loading

cmsbuild commented Aug 5, 2020

cmsbuild commented Aug 5, 2020

cmsbuild commented Aug 5, 2020

slava77 commented Aug 5, 2020

cmsbuild commented Aug 5, 2020 • edited Loading

cmsbuild commented Aug 5, 2020

cmsbuild commented Aug 5, 2020

cmsbuild commented Aug 5, 2020

slava77 commented Aug 6, 2020

slava77 commented Aug 6, 2020

cmsbuild commented Aug 6, 2020

silviodonato commented Aug 7, 2020

cmsbuild commented Jun 26, 2020 •

edited

Loading

cmsbuild commented Aug 5, 2020 •

edited

Loading