CLCT comparator code calculation (CCLUT-5) #30103

dildick · 2020-06-04T02:56:47Z

PR description:

This PR introduces the comparator code calculation in the CLCT processor (actually part of the OTMB/TMB firmware logic). Run-3 will use new CLCT patterns which, in combination with the CCLUT algorithm, allow for a more precise determination of LCT position and bending in the CSC local trigger. More information on the CCLUT algorithm and CSC trigger data formats can be found here: https://gitlab.cern.ch/tdr/notes/DN-20-016/blob/master/temp/DN-20-016_temp.pdf. The CCLUT algorithm uses a new CSCComparatorCodeLUT object that loads the LUTs in txt format. I do not yet have an actual position offset/slope LUT generator, but plan to add that in a follow-up PR.

The PR is the fifth in a series following #29233, #29205, #28846 and #28600. A related PR is this one cms-data/L1Trigger-CSCTriggerPrimitives#1 where the LUTs are introduced for position offset and slope.

To be clear: the code is not enabled yet - and won't be for quite some time as it requires precise coordination between EMTF, OMTF, DQM, packer/unpacker etc. There should be no differences in any of the workflows (and I didn't see any in local tests).

PR validation:

Tested with WF 27434.0

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

@tahuang1991

cmsbuild · 2020-06-04T02:57:13Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-06-04T03:04:01Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30103/15851

This PR adds an extra 64KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File L1Trigger/CSCTriggerPrimitives/src/CSCCathodeLCTProcessor.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-auto #29936, [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-emplace #29937
- File L1Trigger/CSCTriggerPrimitives/src/CSCGEMMotherboard.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-make-unique #29934
- File L1Trigger/CSCTriggerPrimitives/src/CSCMotherboard.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-make-unique #29934, [RFC] Test clang-tidy --checks modernize-loop-convert #29935
- File L1Trigger/CSCTriggerPrimitives/src/CSCUpgradeCathodeLCTProcessor.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-emplace #29937

cmsbuild · 2020-06-04T03:04:30Z

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

L1Trigger/CSCTriggerPrimitives

@cmsbuild, @rekovic, @benkrikler can you please review it and eventually sign? Thanks.
@valuev, @ptcox, @Martin-Grunewald this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2020-06-05T15:57:59Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-06-05T16:02:20Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30103/15898

This PR adds an extra 60KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File L1Trigger/CSCTriggerPrimitives/interface/CSCCathodeLCTProcessor.h modified in PR(s): Rewrite ALCT trigger patterns as 2D vector (ACLUT-2) #30104
- File L1Trigger/CSCTriggerPrimitives/src/CSCCathodeLCTProcessor.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-auto #29936, [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-emplace #29937
- File L1Trigger/CSCTriggerPrimitives/src/CSCGEMMotherboard.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-make-unique #29934
- File L1Trigger/CSCTriggerPrimitives/src/CSCMotherboard.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-make-unique #29934
- File L1Trigger/CSCTriggerPrimitives/src/CSCUpgradeCathodeLCTProcessor.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-emplace #29937

cmsbuild · 2020-06-05T16:02:44Z

Pull request #30103 was updated. @cmsbuild, @rekovic, @benkrikler can you please check and sign again.

cmsbuild · 2020-06-05T16:59:18Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-06-05T17:05:22Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30103/15907

This PR adds an extra 64KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File L1Trigger/CSCTriggerPrimitives/interface/CSCCathodeLCTProcessor.h modified in PR(s): Rewrite ALCT trigger patterns as 2D vector (ACLUT-2) #30104
- File L1Trigger/CSCTriggerPrimitives/src/CSCCathodeLCTProcessor.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-auto #29936, [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-emplace #29937
- File L1Trigger/CSCTriggerPrimitives/src/CSCGEMMotherboard.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-make-unique #29934
- File L1Trigger/CSCTriggerPrimitives/src/CSCMotherboard.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-make-unique #29934
- File L1Trigger/CSCTriggerPrimitives/src/CSCUpgradeCathodeLCTProcessor.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-emplace #29937

cmsbuild · 2020-06-05T17:05:47Z

Pull request #30103 was updated. @cmsbuild, @rekovic, @benkrikler can you please check and sign again.

dildick · 2020-06-09T14:47:46Z

@rekovic Can you run the tests, please?

smuzaffar · 2020-06-11T09:53:14Z

test parameters

pull_requests = Add LUTs for CSC stub position offset and bending value. cms-data/L1Trigger-CSCTriggerPrimitives#1

smuzaffar · 2020-06-11T09:53:20Z

please test

smuzaffar · 2020-07-02T13:02:40Z

@silviodonato , this also failed to merge
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7596/console

cmsbuild · 2020-07-02T14:49:47Z

+1
Tested at: f3c0589
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-db6b9d/7603/summary.html
CMSSW: CMSSW_11_2_X_2020-07-01-2300
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-07-02T14:49:53Z

Comparison job queued.

cmsbuild · 2020-07-02T16:45:14Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-db6b9d/7603/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2784120
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2784069
DQMHistoTests: Total skipped: 50
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
Checked 154 log files, 17 edm output root files, 37 DQM output files

dildick · 2020-07-02T16:54:15Z

The single failure is coming from the pixel system. So this looks good to me.

silviodonato · 2020-07-06T10:39:25Z

@rekovic, can you please check and eventually sign?

rekovic · 2020-07-07T13:20:54Z

+1

cmsbuild · 2020-07-07T13:21:13Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2020-07-07T19:21:25Z

+1

cmsbuild added this to the CMSSW_11_2_X milestone Jun 4, 2020

cmsbuild added code-checks-pending comparison-pending l1-pending orp-pending pending-signatures tests-pending labels Jun 4, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 4, 2020

dildick mentioned this pull request Jun 4, 2020

Rewrite ALCT trigger patterns as 2D vector (ACLUT-2) #30104

Merged

cmsbuild added code-checks-pending and removed code-checks-approved labels Jun 5, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 5, 2020

cmsbuild added code-checks-pending and removed code-checks-approved labels Jun 5, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 5, 2020

cmsbuild added requires-external tests-started labels Jul 2, 2020

cmsbuild added tests-approved and removed tests-started labels Jul 2, 2020

cmsbuild added comparison-available and removed comparison-pending labels Jul 2, 2020

cmsbuild mentioned this pull request Jul 3, 2020

[TEST ONLY][Do not merge] New clang tidy checks #30508

Closed

cmsbuild mentioned this pull request Jul 6, 2020

Fix out-of-bound issue in call to LUT in GEM-CSC trigger #30564

Merged

cmsbuild added fully-signed l1-approved and removed l1-pending pending-signatures labels Jul 7, 2020

cmsbuild added orp-approved and removed orp-pending labels Jul 7, 2020

cmsbuild merged commit 82755ca into cms-sw:master Jul 7, 2020

silviodonato mentioned this pull request Jul 8, 2020

DDXV2 cms-data/RecoBTag-Combined#31

Merged

This was referenced Jul 8, 2020

Phase2-hgx252 Make the new algorithm for dd4hep #30593

Merged

Clean BuildFiles in reco plugins #30535

Merged

Use ONNXRuntime for ParticleNet inference #30599

Merged

dildick deleted the from-CMSSW_11_2_X_2020-03-06-2300-CCLUT branch July 9, 2020 02:20

dildick mentioned this pull request Jul 16, 2020

Igprof analysis of 11_1_0_p3_ROOT618 : CSCMotherboard::CSCMotherboard #30745

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CLCT comparator code calculation (CCLUT-5) #30103

CLCT comparator code calculation (CCLUT-5) #30103

dildick commented Jun 4, 2020

cmsbuild commented Jun 4, 2020

cmsbuild commented Jun 4, 2020

cmsbuild commented Jun 4, 2020

cmsbuild commented Jun 5, 2020

cmsbuild commented Jun 5, 2020

cmsbuild commented Jun 5, 2020

cmsbuild commented Jun 5, 2020

cmsbuild commented Jun 5, 2020

cmsbuild commented Jun 5, 2020

dildick commented Jun 9, 2020

smuzaffar commented Jun 11, 2020

smuzaffar commented Jun 11, 2020

smuzaffar commented Jul 2, 2020

cmsbuild commented Jul 2, 2020

cmsbuild commented Jul 2, 2020

cmsbuild commented Jul 2, 2020

dildick commented Jul 2, 2020

silviodonato commented Jul 6, 2020

rekovic commented Jul 7, 2020

cmsbuild commented Jul 7, 2020

silviodonato commented Jul 7, 2020

CLCT comparator code calculation (CCLUT-5) #30103

CLCT comparator code calculation (CCLUT-5) #30103

Conversation

dildick commented Jun 4, 2020

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Jun 4, 2020

cmsbuild commented Jun 4, 2020

cmsbuild commented Jun 4, 2020

cmsbuild commented Jun 5, 2020

cmsbuild commented Jun 5, 2020

cmsbuild commented Jun 5, 2020

cmsbuild commented Jun 5, 2020

cmsbuild commented Jun 5, 2020

cmsbuild commented Jun 5, 2020

dildick commented Jun 9, 2020

smuzaffar commented Jun 11, 2020

smuzaffar commented Jun 11, 2020

smuzaffar commented Jul 2, 2020

cmsbuild commented Jul 2, 2020

cmsbuild commented Jul 2, 2020

cmsbuild commented Jul 2, 2020

dildick commented Jul 2, 2020

silviodonato commented Jul 6, 2020

rekovic commented Jul 7, 2020

cmsbuild commented Jul 7, 2020

silviodonato commented Jul 7, 2020